[APM] Show recommended minimum size when reducing rule interval below 5 minutes by sorenlouv · Pull Request #144170 · elastic/kibana

sorenlouv · 2022-10-28T14:32:01Z

We've seen that users create rules where the ingest delay is larger than the look back window. This means that alerts will not fire as expected because there's no data available when evaluating the rule.

This PR increases the default window size to 5 minutes, and adds a warning if the window size is lowered below this level.

elasticmachine · 2022-10-28T14:32:07Z

Pinging @elastic/apm-ui (Team:APM)

sorenlouv · 2022-10-28T14:33:06Z

x-pack/plugins/apm/public/components/alerting/rule_types/error_count_rule_type/index.tsx

Replace our custom units with units from alerting.

sorenlouv · 2022-10-28T14:33:30Z

x-pack/plugins/apm/public/components/alerting/rule_types/error_count_rule_type/index.tsx

Typecasting no longer needed because we use the same types as alerting

sorenlouv · 2022-10-28T14:34:12Z

x-pack/plugins/triggers_actions_ui/public/index.ts

I had to export this to access the runtime value

sophiec20 · 2022-10-28T15:47:57Z

cc @elastic/mlr-docs

pmuellr

alerting change LGTM

Poking through the rest of the PR, noticing a type change on RuleParams::windowUnit (TimeUnit -> TIME_UNITS). Which have the same values, but the types are different. Since this looks like params for a rule, which would be saved in the SO, need to consider migration issues.

I'm thinking this will not cause a migration, since the values remain unchanged, but thought I'd mention that sometimes changes similar to this could cause a migration - for instance, if the version was a value in the old type not in the new type, kinda thing. Does not look like that's the case here - both types support all the values.

cauemarcondes

LGTM. Just some nits that don't block it.

cauemarcondes · 2022-10-28T19:13:59Z

x-pack/plugins/apm/public/components/alerting/ui_components/apm_rule_params_container/index.tsx

What about using i18n and down below?!

cauemarcondes · 2022-10-28T19:16:25Z

x-pack/plugins/apm/public/components/alerting/ui_components/apm_rule_params_container/index.tsx

Looks like useShowMinimumWindowSize already checks if minimumWindowSize is defined and if not it returns false so I don't think you need these two checks.

Suggested change

{showMinimumWindowSizeWarning && minimumWindowSize && (

{showMinimumWindowSizeWarning && (

afair this is needed to satisfy Typescript because minimumWindowSize is optional. I'll see what I can do though

cauemarcondes · 2022-10-28T19:17:05Z

x-pack/plugins/apm/public/components/alerting/ui_components/apm_rule_params_container/index.tsx

Does it have to be a hook at all? It looks like a normal function that returns true/false?!

Are you suggesting to inline this? I think it's better to extract it but I don't feel strongly about it.

kibana-ci · 2022-10-31T01:37:13Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #38

Test Failures

[job] [logs] FTR Configs #38 / alerting api integration spaces only Alerting builtin alertTypes es_query rule runs correctly: use epoch millis - threshold on hit count < > for searchSource search type

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.1MB	3.1MB	+4.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	100.5KB	100.6KB	+54.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	57	63	+6
`osquery`	103	108	+5
`securitySolution`	439	443	+4
total			+17

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	65	71	+6
`osquery`	104	110	+6
`securitySolution`	516	520	+4
total			+18

History

💔 Build #83778 failed ecbd317934e965a5c2765c01bd847fcc9f895ade
💔 Build #83557 failed 837b99c923c6a908f3181225c7c51dbf4683c709

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* main: (43 commits) [Synthetics] Step details page screenshot (elastic#143452) [Lens] Datatable expression types improvement. (elastic#144173) [packages/kbn-journeys] start apm after browser start and stop after browser is closed (elastic#144267) [Files] Make files namespace agnostic (elastic#144019) Implement base browser-side logging system (elastic#144107) Correct wrong multiplier for byte conversion (elastic#143751) [Monaco] Add JSON syntax support to the Monaco editor (elastic#143739) CCS Smoke Test for Remote Clusters and Index Management (elastic#142423) [api-docs] Daily api_docs build (elastic#144294) chore(NA): include progress on Bazel tasks (elastic#144275) [RAM] Allow users to see event logs from all spaces they have access to (elastic#140449) [APM] Show recommended minimum size when going below 5 minutes (elastic#144170) [typecheck] delete temporary target_types dirs in packages (elastic#144271) [Security Solution][Endpoint] adds new alert loading utility and un-skip FTR test for endpoint (elastic#144133) [performance/journeys] revert data_stress_test_lens.ts journey step (elastic#144261) [TIP] Use search strategies in Threat Intelligence (elastic#143267) Optimize react-query dependencies (elastic#144206) [babel/node] invalidate cache when synth pkg map is updated (elastic#144258) [APM] AWS lambda estimated cost (elastic#143986) [Maps] layer group wizard (elastic#144129) ...

sorenlouv added release_note:fix v8.6.0 labels Oct 28, 2022

sorenlouv requested a review from a team as a code owner October 28, 2022 14:32

sorenlouv requested a review from a team October 28, 2022 14:32

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 28, 2022

sorenlouv commented Oct 28, 2022

View reviewed changes

x-pack/plugins/triggers_actions_ui/public/index.ts Outdated

Copy link

Member Author

sorenlouv Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to export this to access the runtime value

pmuellr approved these changes Oct 28, 2022

View reviewed changes

cauemarcondes approved these changes Oct 28, 2022

View reviewed changes

sorenlouv changed the title ~~[APM] Show recommended minimum size when going below~~ [APM] Show recommended minimum size when going below 5 minutes Oct 28, 2022

sorenlouv added 3 commits October 31, 2022 01:05

[APM] Show recommended minimum size when going below

80f30f5

Add i18n

53c0d5e

Fix story

06e8dbd

sorenlouv force-pushed the show-recommended-minimum-window-size branch from 1836766 to 06e8dbd Compare October 31, 2022 00:06

sorenlouv merged commit e502ecf into elastic:main Oct 31, 2022

sorenlouv deleted the show-recommended-minimum-window-size branch October 31, 2022 21:42

kibanamachine added the backport:skip This PR does not require backporting label Oct 31, 2022

sorenlouv changed the title ~~[APM] Show recommended minimum size when going below 5 minutes~~ [APM] Show recommended minimum size when reducing rule interval below 5 minutes Jan 5, 2023

sorenlouv mentioned this pull request Jan 5, 2023

[APM] Automatically select right resolution for transaction metrics #146683

Closed

	{showMinimumWindowSizeWarning && minimumWindowSize && (
	{showMinimumWindowSizeWarning && (

Conversation

sorenlouv commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Oct 28, 2022

Uh oh!

sorenlouv Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

sorenlouv Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

sorenlouv Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

sophiec20 commented Oct 28, 2022

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

cauemarcondes Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

sorenlouv Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

cauemarcondes Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sorenlouv Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

cauemarcondes Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

sorenlouv Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Oct 31, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sorenlouv commented Oct 28, 2022 •

edited

Loading

cauemarcondes Oct 28, 2022 •

edited

Loading

sorenlouv Oct 28, 2022 •

edited

Loading