[RAM] Allow users to see event logs from all spaces they have access to by Zacqary · Pull Request #140449 · elastic/kibana

Zacqary · 2022-09-09T19:57:23Z

Summary

Adds a property called namespaces to the global_execution_logs API. This is an array of Space IDs to fetch logs for.

In the global Logs tab, a switch will be enabled if the current user has access to multiple spaces. It will be disabled if the current user can only access one space. When this switch is toggled, it will send all accessible namespaces to the logs API.

Clicking a link to a rule on a different space will switch the user to that space in a new tab.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…itch # Conflicts: # x-pack/plugins/alerting/common/execution_log_types.ts # x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.ts # x-pack/plugins/alerting/server/rules_client/rules_client.ts

elasticmachine · 2022-10-18T20:43:16Z

Pinging @elastic/response-ops (Team:ResponseOps)

…itch

JiaweiWu

Looks good overall! I left some comments and it would be great to add some UI tests for this, especially for the spaces routing on click and the spaces switch.

JiaweiWu · 2022-10-19T21:17:36Z

x-pack/plugins/alerting/server/rules_client/rules_client.ts

  dateStart: string;
  dateEnd?: string;
  filter?: string;
+  namespaces?: Array<string | undefined>;


Is it possible to make this type a bit stricter? (I.e. just Array<string>). I see that getNameSpace could return undefined, could we filter those entries out or do they have some significance being undefined?

The Default namespace is referred to as undefined internally. As far as I can tell, this changed recently; it used to just be the string default.

...ugins/triggers_actions_ui/public/application/lib/rule_api/load_execution_log_aggregations.ts

..._actions_ui/public/application/sections/rule_details/components/rule_event_log_data_grid.tsx

...ui/public/application/sections/rule_details/components/rule_event_log_list_cell_renderer.tsx

...actions_ui/public/application/sections/rule_details/components/rule_event_log_list_table.tsx

x-pack/plugins/triggers_actions_ui/public/common/lib/kibana/use_spaces_data.tsx

…itch

…-fix'

…itch

…kibana into 137995-log-space-switch

Zacqary · 2022-10-28T17:47:16Z

Just pushed a fix for accessing action error logs from alternate spaces

JiaweiWu

I've tested the fix for the error logs, seems to work as expected. I just had some small comments

x-pack/plugins/event_log/server/es/cluster_client_adapter.ts

JiaweiWu · 2022-10-28T18:45:25Z

x-pack/plugins/event_log/server/es/cluster_client_adapter.ts

    }
  }

+  public async queryEventsWithAuthFilter(


I'm wondering if we should reduce some of the code duplication between this and queryEventsBySavedObjects, or maybe we can modify queryEventsBySavedObjects to support the new auth filters? Curious to hear your thoughts

I don't want to modify the existing queryEventsBySavedObjects functionality too much, I'm not sure if it'll modify expected error behaviors in unpredictable places.

x-pack/plugins/alerting/server/rules_client/rules_client.ts

…itch

kibana-ci · 2022-10-31T19:25:11Z

💚 Build Succeeded

Buildkite Build
Commit: cc99097

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	511	512	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`alerting`	373	374	+1
`eventLog`	106	115	+9
total			+10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	676.8KB	679.4KB	+2.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`eventLog`	10	11	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	100.5KB	100.9KB	+418.0B

Unknown metric groups

API count

id	before	after	diff
`alerting`	382	383	+1
`eventLog`	106	115	+9
total			+10

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	57	63	+6
`osquery`	103	108	+5
`securitySolution`	439	443	+4
`triggersActionsUi`	131	132	+1
total			+18

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	65	71	+6
`osquery`	104	110	+6
`securitySolution`	516	520	+4
`triggersActionsUi`	134	135	+1
total			+19

History

💔 Build #84099 failed 64e9442
💔 Build #84044 failed e21b64a
💔 Build #83712 failed ce620aa
💔 Build #83710 failed e192495
💔 Build #83700 failed c964fd8
💔 Build #83636 failed e37b3eb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

JiaweiWu

LGTM!

* main: (43 commits) [Synthetics] Step details page screenshot (elastic#143452) [Lens] Datatable expression types improvement. (elastic#144173) [packages/kbn-journeys] start apm after browser start and stop after browser is closed (elastic#144267) [Files] Make files namespace agnostic (elastic#144019) Implement base browser-side logging system (elastic#144107) Correct wrong multiplier for byte conversion (elastic#143751) [Monaco] Add JSON syntax support to the Monaco editor (elastic#143739) CCS Smoke Test for Remote Clusters and Index Management (elastic#142423) [api-docs] Daily api_docs build (elastic#144294) chore(NA): include progress on Bazel tasks (elastic#144275) [RAM] Allow users to see event logs from all spaces they have access to (elastic#140449) [APM] Show recommended minimum size when going below 5 minutes (elastic#144170) [typecheck] delete temporary target_types dirs in packages (elastic#144271) [Security Solution][Endpoint] adds new alert loading utility and un-skip FTR test for endpoint (elastic#144133) [performance/journeys] revert data_stress_test_lens.ts journey step (elastic#144261) [TIP] Use search strategies in Threat Intelligence (elastic#143267) Optimize react-query dependencies (elastic#144206) [babel/node] invalidate cache when synth pkg map is updated (elastic#144258) [APM] AWS lambda estimated cost (elastic#143986) [Maps] layer group wizard (elastic#144129) ...

Add all_namespaces prop to global logs api

b60fdce

Zacqary added Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Alerting/RulesManagement Issues related to the Rules Management UX 8.6 candidate labels Sep 9, 2022

Zacqary added 5 commits October 13, 2022 15:30

Merge remote-tracking branch 'upstream/main' into 137995-log-space-sw…

43780c6

…itch # Conflicts: # x-pack/plugins/alerting/common/execution_log_types.ts # x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.ts # x-pack/plugins/alerting/server/rules_client/rules_client.ts

Display space column and disable link on inactive spaces

ff24cc0

Add ability to link across spaces

c64baca

Fix allNamespace query on default space

d979592

Fix KPI and link space switch to permissions

30fcaf5

Zacqary changed the title ~~[RAM] Add all_namespaces prop to global logs api~~ [RAM] Allow users to see event logs from all spaces they have access to Oct 17, 2022

Zacqary added v8.6.0 and removed 8.6 candidate labels Oct 17, 2022

Zacqary added 5 commits October 17, 2022 15:43

Open alternate space rules in new tab

c1b68c7

Fix Jest 11

99dd960

Fix Jest 1

e0f83b1

Fix Jest 4 and 10

b336fe4

Fix i18n

a0619bc

Zacqary marked this pull request as ready for review October 18, 2022 20:43

Zacqary requested a review from a team as a code owner October 18, 2022 20:43

Merge remote-tracking branch 'upstream/main' into 137995-log-space-sw…

13bcd27

…itch

Zacqary added the release_note:feature Makes this part of the condensed release notes label Oct 18, 2022

JiaweiWu reviewed Oct 19, 2022

View reviewed changes

Zacqary added 3 commits October 20, 2022 11:57

Move space column visibility out of data grid

57b38da

Merge remote-tracking branch 'upstream/main' into 137995-log-space-sw…

0f18fbf

…itch

Merge remote-tracking branch 'upstream/main' into 137995-log-space-sw…

8c009ef

…itch

Zacqary enabled auto-merge (squash) October 26, 2022 17:00

Zacqary and others added 3 commits October 26, 2022 16:57

Add test for link routing

5a185a8

Merge remote-tracking branch 'upstream/main' into 137995-log-space-sw…

81d1e6f

…itch

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

90d1bc8

…-fix'

Zacqary added 3 commits October 28, 2022 12:45

Add auth and space access to action error log

eeff02c

Merge remote-tracking branch 'upstream/main' into 137995-log-space-sw…

0bb3bc7

…itch

Merge branch '137995-log-space-switch' of https://github.com/Zacqary/…

e37b3eb

…kibana into 137995-log-space-switch

JiaweiWu reviewed Oct 28, 2022

View reviewed changes

Zacqary added 7 commits October 28, 2022 16:52

Add test for getActionErrorLogWithAuth, fix types, consts

c964fd8

Fix undefined spaceids error

e192495

Fix base path support

ce620aa

Fix types and jest

de8d641

Merge remote-tracking branch 'upstream/main' into 137995-log-space-sw…

e21b64a

…itch

Fix types and jest

64e9442

Remove consolelog

cc99097

JiaweiWu approved these changes Nov 1, 2022

View reviewed changes

Zacqary merged commit 5c50cd4 into elastic:main Nov 1, 2022

kibanamachine added the backport:skip This PR does not require backporting label Nov 1, 2022

Zacqary mentioned this pull request Nov 7, 2022

[RAM] Add integration tests for all-space global logs view #144732

Closed

pmuellr mentioned this pull request Jan 3, 2023

[ResponseOps] space-agnostic admin-only route to return all rules / connectors #137352

Closed

stefnestor mentioned this pull request Apr 9, 2023

Enable Kibana Diagnostic to be Space Aware for Rules elastic/support-diagnostics#578

Open

Conversation

Zacqary commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Oct 18, 2022

Uh oh!

JiaweiWu left a comment

Choose a reason for hiding this comment

Uh oh!

JiaweiWu Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

Zacqary Oct 20, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zacqary commented Oct 28, 2022

Uh oh!

JiaweiWu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JiaweiWu Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

Zacqary Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kibana-ci commented Oct 31, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

JiaweiWu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zacqary commented Sep 9, 2022 •

edited

Loading