[TIP] Use search strategies in Threat Intelligence#143267
Merged
PhilippeOberti merged 3 commits intoelastic:mainfrom Oct 31, 2022
lgestc:utilize-search-stragies
Merged
[TIP] Use search strategies in Threat Intelligence#143267PhilippeOberti merged 3 commits intoelastic:mainfrom lgestc:utilize-search-stragies
PhilippeOberti merged 3 commits intoelastic:mainfrom
lgestc:utilize-search-stragies
Conversation
lgestc
added
release_note:skip
PhilippeOberti
approved these changes
Oct 14, 2022
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
cool to have have some server side code! Couple of super minor comments
| @@ -0,0 +1,32 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
why not renaming this file to types.ts to be consistent with the frontend side of the plugin?
| */ | ||
|
|
||
| import { threatIndicatorNamesOriginScript, threatIndicatorNamesScript } from './display_name'; | ||
| import { threatIndicatorNamesOriginScript, threatIndicatorNamesScript } from './indicator_name'; |
Contributor
There was a problem hiding this comment.
to be consistent with the rest of the plugin (after clean up) we could add a index.ts at the root of this utils folder and clean up the imports
| */ | ||
|
|
||
| import { threatIndicatorNamesOriginScript, threatIndicatorNamesScript } from './display_name'; | ||
| import { threatIndicatorNamesOriginScript, threatIndicatorNamesScript } from './indicator_name'; |
…o be used within public and server folders. Also rename plugin_contract to types
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 1, 2022
* main: (43 commits) [Synthetics] Step details page screenshot (elastic#143452) [Lens] Datatable expression types improvement. (elastic#144173) [packages/kbn-journeys] start apm after browser start and stop after browser is closed (elastic#144267) [Files] Make files namespace agnostic (elastic#144019) Implement base browser-side logging system (elastic#144107) Correct wrong multiplier for byte conversion (elastic#143751) [Monaco] Add JSON syntax support to the Monaco editor (elastic#143739) CCS Smoke Test for Remote Clusters and Index Management (elastic#142423) [api-docs] Daily api_docs build (elastic#144294) chore(NA): include progress on Bazel tasks (elastic#144275) [RAM] Allow users to see event logs from all spaces they have access to (elastic#140449) [APM] Show recommended minimum size when going below 5 minutes (elastic#144170) [typecheck] delete temporary target_types dirs in packages (elastic#144271) [Security Solution][Endpoint] adds new alert loading utility and un-skip FTR test for endpoint (elastic#144133) [performance/journeys] revert data_stress_test_lens.ts journey step (elastic#144261) [TIP] Use search strategies in Threat Intelligence (elastic#143267) Optimize react-query dependencies (elastic#144206) [babel/node] invalidate cache when synth pkg map is updated (elastic#144258) [APM] AWS lambda estimated cost (elastic#143986) [Maps] layer group wizard (elastic#144129) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
And last but not least, helps us understand the server side processing a bit more.
Checklist
Delete any items that are not applicable to this PR.
https://github.com/elastic/security-team/issues/4871