[Cases] Add severity field to create case by academo · Pull Request #131626 · elastic/kibana

academo · 2022-05-05T12:57:28Z

Summary

Adds the severity field to the create case form.

Partially addresses: #130019

Follow up to: #131521

Via the cases page

via the cases flyout

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Release note

Add severity field to Cases

…ity-field

… "long" in Elasticsearch) (#130819) * Convert event.duration to string in TypeScript, keep as long in Elasticsearch * Fix jest test * Fix functional tests * Add ecsStringOrNumber to event log schema * Fix jest test * Add utility functions to event log plugin * Use new event log utility functions * PR fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…31277)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Add fix license link * fix localization * fix CI error * fix more translation issues Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* rule state filter * turn off experiment * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Status filter API call * Fix tests * rename state to status, added tests * Address comments and fix tests * Revert experiment flag * Remove unused translations * Addressed comments Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

* [storybook] Watch for changes in packages * Update default_config.ts

* adjust vega doc * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

…ity-field

…ity-field-create-form

… into feature/cases-severity-field-create-form

…ity-field-create-form

elasticmachine · 2022-05-06T10:00:26Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2022-05-06T10:00:28Z

Pinging @elastic/response-ops-cases (Feature:Cases)

cnasikas

Could you please add the severity to x-pack/plugins/cases/public/components/create/schema.tsx?

kibana-ci · 2022-05-06T12:26:28Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cases`	424	425	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	292.6KB	293.7KB	+1.1KB

History

💛 Build #42970 was flaky 3ff11a2
💚 Build #42941 succeeded ca68fda
💚 Build #42806 succeeded da31573
💔 Build #42790 failed e3e0dca

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

peteharverson

Tested and LGTM

…hromium-to-print-pdf-part-1 * 'main' of github.com:elastic/kibana: (59 commits) [Cloud Posture] Enabled findings group by feature (elastic#131780) [EBT] Fix `userId` generation (elastic#131701) [RAM] Add shareable rule tag filter (elastic#130710) Optimize package installation performance, phase 2 (elastic#131627) [Screenshotting] instrument for benchmark tests using new EventLogger class (elastic#130356) [Connector] Adding internal route for requesting ad-hoc ServiceNow access token (elastic#131171) [ci] bump kibana-buildkite-library (elastic#131754) [Synthetics] UI clean up (elastic#131598) [RsponseOps] Fix flaky rules list test (elastic#131567) [Cases] Add severity field to create case (elastic#131626) [Discover] Monospace font in Document Explorer (elastic#131513) Sessions tab improvements (elastic#131583) Add cloud icon "ess-icon" at the end of the config keys in "alerting" documentation (elastic#131735) [DOCS] Updates deprecation text for legacy APIs (elastic#131741) [ci] break out skip patterns so they can change without triggering CI (elastic#131726) Adjust search session management page font size (elastic#131291) [Unified search] Fix uptime css problem (elastic#131730) [Actionable Observability] Link to filtered rules page (elastic#131629) Add openAPI specifications for cases endpoint (elastic#131275) Display rule API key owner to users who can manage API keys (elastic#131662) ... # Conflicts: # x-pack/plugins/screenshotting/server/formats/pdf/index.ts # x-pack/plugins/screenshotting/server/screenshots/observable.ts

Esteban Beltran and others added 30 commits May 3, 2022 14:18

Add severity field to create API and migration

8abc0d3

Adds integration test for severity field migration

c7986b0

remove exclusive test

8ff9f9b

Change severity levels

04c413e

Update integration tests for post case

9d488bc

Add more integration tests

13f3406

Fix all cases list test

a749da5

Fix some server test

f76213a

Fix util server test

d62bf70

Fix client util test

8906ccd

Merge remote-tracking branch 'upstream/main' into feature/cases-sever…

99923ec

…ity-field

Merge branch 'main' into feature/cases-severity-field

ede3328

filter o11y rule aggregations (#131301)

bcb2ab1

[Cloud Posture] Display and save rules per benchmark (#131412)

7caa070

Adding aria-label for discover data grid select document checkbox (#1…

ed7c949

…31277)

Update API docs (#130999)

e120e56

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[CI] Use GCS buckets for bazel remote caching (#131345)

16467d1

[Actionable Observability] Add license modal to rules table (#131232)

1186b3e

* Add fix license link * fix localization * fix CI error * fix more translation issues Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[storybook] Watch for changes in packages (#131467)

f11b843

* [storybook] Watch for changes in packages * Update default_config.ts

Improve saved objects migrations failure errors and logs (#131359)

c574ab6

[Unified observability] Add tour step to guided setup (#131149)

fed45c9

[Lens] Improved interval input (#131372)

9dd98b9

Merge remote-tracking branch 'upstream/main' into feature/cases-sever…

e2b8cf4

…ity-field

Excess intersections

de4a093

Create severity user action

87f2cd5

Add severity selector to the case vie wpage

6958994

Add test cases for the severity field

23417a1

academo added the v8.3.0 label May 5, 2022

academo self-assigned this May 5, 2022

Esteban Beltran and others added 6 commits May 5, 2022 16:05

Merge remote-tracking branch 'upstream/main' into feature/cases-sever…

da31573

…ity-field-create-form

Merge branch 'main' into feature/cases-severity-field-ui

4faab1e

Merge branch 'main' into feature/cases-severity-field-ui

918d56b

Merge remote-tracking branch 'upstream/main' into feature/cases-sever…

ca68fda

…ity-field-create-form

Merge remote-tracking branch 'origin/feature/cases-severity-field-ui'…

012972c

… into feature/cases-severity-field-create-form

Merge remote-tracking branch 'upstream/main' into feature/cases-sever…

3ff11a2

…ity-field-create-form

academo requested review from cnasikas and peteharverson May 6, 2022 10:00

academo marked this pull request as ready for review May 6, 2022 10:00

academo requested a review from a team as a code owner May 6, 2022 10:00

cnasikas reviewed May 6, 2022

View reviewed changes

Comment thread x-pack/plugins/cases/public/components/create/form.tsx

cnasikas reviewed May 6, 2022

View reviewed changes

Comment thread x-pack/plugins/cases/public/components/create/form_context.test.tsx

cnasikas reviewed May 6, 2022

View reviewed changes

Comment thread x-pack/plugins/cases/public/components/create/form_context.test.tsx

Add a test case for submit case with a selected severity

ec1f3e3

cnasikas approved these changes May 6, 2022

View reviewed changes

academo requested a review from cnasikas May 6, 2022 11:21

Add severity to the schema

e3e0560

cnasikas approved these changes May 6, 2022

View reviewed changes

peteharverson approved these changes May 6, 2022

View reviewed changes

academo merged commit c4b554a into elastic:main May 6, 2022

academo deleted the feature/cases-severity-field-create-form branch May 6, 2022 16:23

cnasikas mentioned this pull request May 10, 2022

[Cases] Add Severity field to cases #130019

Closed

5 tasks

kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022

[Cases] Add severity field to create case (elastic#131626)

09ece02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Add severity field to create case#131626

[Cases] Add severity field to create case#131626
academo merged 54 commits intoelastic:mainfrom
academo:feature/cases-severity-field-create-form

academo commented May 5, 2022 •

edited by cnasikas

Loading

Uh oh!

elasticmachine commented May 6, 2022

Uh oh!

elasticmachine commented May 6, 2022

Uh oh!

cnasikas left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibana-ci commented May 6, 2022

Uh oh!

peteharverson left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Conversation

academo commented May 5, 2022 • edited by cnasikas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Release note

Uh oh!

elasticmachine commented May 6, 2022

Uh oh!

elasticmachine commented May 6, 2022

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibana-ci commented May 6, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

academo commented May 5, 2022 •

edited by cnasikas

Loading