Display rule API key owner to users who can manage API keys#131662
Merged
mikecote merged 4 commits intoelastic:mainfrom May 6, 2022
Merged
Display rule API key owner to users who can manage API keys#131662mikecote merged 4 commits intoelastic:mainfrom
mikecote merged 4 commits intoelastic:mainfrom
Conversation
mikecote
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
approved these changes
May 6, 2022
Contributor
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
LGTM! Verified that the owner shows up in the rule details view for users with ability to manage API keys.
mdefazio
requested changes
May 6, 2022
Contributor
mdefazio
left a comment
mdefazio
left a comment
There was a problem hiding this comment.
Can we make this simply text instead of a badge? I think it takes away form the rule type with the same styling.
We can keep the text bold to help it stand out from the label though. In future iterations of this page, we will get away from using the badges for rule type, so hopefully this also avoids reworking this (too much).
Contributor
Author
|
@mdefazio thanks! I've updated the PR, and you can see the latest change / screenshot in the PR description. |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mikecote |
mikecote
added
release_note:enhancement
and removed
release_note:skip
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 9, 2022
…hromium-to-print-pdf-part-1 * 'main' of github.com:elastic/kibana: (59 commits) [Cloud Posture] Enabled findings group by feature (elastic#131780) [EBT] Fix `userId` generation (elastic#131701) [RAM] Add shareable rule tag filter (elastic#130710) Optimize package installation performance, phase 2 (elastic#131627) [Screenshotting] instrument for benchmark tests using new EventLogger class (elastic#130356) [Connector] Adding internal route for requesting ad-hoc ServiceNow access token (elastic#131171) [ci] bump kibana-buildkite-library (elastic#131754) [Synthetics] UI clean up (elastic#131598) [RsponseOps] Fix flaky rules list test (elastic#131567) [Cases] Add severity field to create case (elastic#131626) [Discover] Monospace font in Document Explorer (elastic#131513) Sessions tab improvements (elastic#131583) Add cloud icon "ess-icon" at the end of the config keys in "alerting" documentation (elastic#131735) [DOCS] Updates deprecation text for legacy APIs (elastic#131741) [ci] break out skip patterns so they can change without triggering CI (elastic#131726) Adjust search session management page font size (elastic#131291) [Unified search] Fix uptime css problem (elastic#131730) [Actionable Observability] Link to filtered rules page (elastic#131629) Add openAPI specifications for cases endpoint (elastic#131275) Display rule API key owner to users who can manage API keys (elastic#131662) ... # Conflicts: # x-pack/plugins/screenshotting/server/formats/pdf/index.ts # x-pack/plugins/screenshotting/server/screenshots/observable.ts
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
…131662) * Display rule owner for users who can manage API keys * Rename owner to API key owner * Make owner bold instead of a badge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131235.
Updated UI:
