Skip to content

[Actionable Observability] Link to filtered rules page#131629

Merged
mgiota merged 11 commits intoelastic:mainfrom
mgiota:link_to_filtered_rules_page
May 6, 2022
Merged

[Actionable Observability] Link to filtered rules page#131629
mgiota merged 11 commits intoelastic:mainfrom
mgiota:link_to_filtered_rules_page

Conversation

@mgiota
Copy link
Copy Markdown
Contributor

@mgiota mgiota commented May 5, 2022

Fixes #130985

Screenshot 2022-05-06 at 09 46 05

@mgiota mgiota force-pushed the link_to_filtered_rules_page branch from 0cf8038 to f30f62c Compare May 5, 2022 17:55
@mgiota mgiota changed the title Link to filtered rules page [Actionable Observability] Link to filtered rules page May 5, 2022
@mgiota mgiota self-assigned this May 5, 2022
@mgiota mgiota force-pushed the link_to_filtered_rules_page branch from d43c1ec to 4ff4df6 Compare May 5, 2022 21:52
@mgiota mgiota force-pushed the link_to_filtered_rules_page branch from 4ff4df6 to 69f6911 Compare May 5, 2022 21:54
@mgiota mgiota force-pushed the link_to_filtered_rules_page branch from 29e27e0 to c86583b Compare May 5, 2022 22:19
@mgiota mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 release_note:skip Skip the PR/issue when compiling release notes labels May 5, 2022
@mgiota mgiota marked this pull request as ready for review May 5, 2022 22:26
@mgiota mgiota requested a review from a team May 5, 2022 22:26
@mgiota mgiota force-pushed the link_to_filtered_rules_page branch from c86583b to 85591b7 Compare May 5, 2022 22:27
@mgiota mgiota force-pushed the link_to_filtered_rules_page branch from 85591b7 to f16fc71 Compare May 5, 2022 22:41
}: {
condition: boolean;
wrap: FunctionComponent;
children: any;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simianhacker Do you have any suggestion what I should put here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed

@mgiota mgiota requested a review from simianhacker May 6, 2022 07:52
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 392 394 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 442.9KB 443.7KB +840.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

Copy link
Copy Markdown
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgiota mgiota merged commit d2ea80a into elastic:main May 6, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 6, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 9, 2022
…hromium-to-print-pdf-part-1

* 'main' of github.com:elastic/kibana: (59 commits)
  [Cloud Posture] Enabled findings group by feature (elastic#131780)
  [EBT] Fix `userId` generation (elastic#131701)
  [RAM] Add shareable rule tag filter (elastic#130710)
  Optimize package installation performance, phase 2 (elastic#131627)
  [Screenshotting] instrument for benchmark tests using new EventLogger class (elastic#130356)
  [Connector] Adding internal route for requesting ad-hoc ServiceNow access token (elastic#131171)
  [ci] bump kibana-buildkite-library (elastic#131754)
  [Synthetics] UI clean up (elastic#131598)
  [RsponseOps] Fix flaky rules list test (elastic#131567)
  [Cases] Add severity field to create case (elastic#131626)
  [Discover] Monospace font in Document Explorer (elastic#131513)
  Sessions tab improvements (elastic#131583)
  Add cloud icon "ess-icon" at the end of the config keys in "alerting" documentation (elastic#131735)
  [DOCS] Updates deprecation text for legacy APIs (elastic#131741)
  [ci] break out skip patterns so they can change without triggering CI (elastic#131726)
  Adjust search session management page font size (elastic#131291)
  [Unified search] Fix uptime css problem (elastic#131730)
  [Actionable Observability] Link to filtered rules page (elastic#131629)
  Add openAPI specifications for cases endpoint (elastic#131275)
  Display rule API key owner to users who can manage API keys (elastic#131662)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/server/formats/pdf/index.ts
#	x-pack/plugins/screenshotting/server/screenshots/observable.ts
@mgiota mgiota deleted the link_to_filtered_rules_page branch May 10, 2022 09:02
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
* make stat counts clickable

* unit tests for rule stats

* rename test cases & add more cases

* more test cases

* use type for exporting types

* add types

* UI adjustments

* add more test cases that check the href link

* use const for the rules page link

* use consts for classes

* fix types in ConditionalWrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link to filtered view from Alerts summary counts

4 participants