Skip to content

[Unified search] Fix uptime css problem#131730

Merged
stratoula merged 1 commit intoelastic:mainfrom
stratoula:unified-search-uptime
May 6, 2022
Merged

[Unified search] Fix uptime css problem#131730
stratoula merged 1 commit intoelastic:mainfrom
stratoula:unified-search-uptime

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented May 6, 2022

Summary

Fixes the css problem on Uptime and other applications that use only the QueryStringInput component and not the SearchBar.

image

There will be a follow-up PR to lazy load some of the CSS files (and other cleanups) to decrease the bundle size of the unified search plugin but let's fix the problem first.

@stratoula stratoula requested review from muhammad-elastic and shahzad31 and removed request for muhammad-elastic May 6, 2022 14:14
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:Unified search Unified search related tasks v8.3.0 labels May 6, 2022
@stratoula stratoula marked this pull request as ready for review May 6, 2022 14:30
@stratoula stratoula requested a review from a team as a code owner May 6, 2022 14:30
Copy link
Copy Markdown
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #5 / analytics instrumented events from the browser Core Context Providers should have the properties provided by the "license info" context provider

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 188.3KB 166.9KB -21.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
unifiedSearch 30.6KB 48.5KB +17.9KB
Unknown metric groups

async chunk count

id before after diff
unifiedSearch 12 11 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 4a71a6e into elastic:main May 6, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 9, 2022
…hromium-to-print-pdf-part-1

* 'main' of github.com:elastic/kibana: (59 commits)
  [Cloud Posture] Enabled findings group by feature (elastic#131780)
  [EBT] Fix `userId` generation (elastic#131701)
  [RAM] Add shareable rule tag filter (elastic#130710)
  Optimize package installation performance, phase 2 (elastic#131627)
  [Screenshotting] instrument for benchmark tests using new EventLogger class (elastic#130356)
  [Connector] Adding internal route for requesting ad-hoc ServiceNow access token (elastic#131171)
  [ci] bump kibana-buildkite-library (elastic#131754)
  [Synthetics] UI clean up (elastic#131598)
  [RsponseOps] Fix flaky rules list test (elastic#131567)
  [Cases] Add severity field to create case (elastic#131626)
  [Discover] Monospace font in Document Explorer (elastic#131513)
  Sessions tab improvements (elastic#131583)
  Add cloud icon "ess-icon" at the end of the config keys in "alerting" documentation (elastic#131735)
  [DOCS] Updates deprecation text for legacy APIs (elastic#131741)
  [ci] break out skip patterns so they can change without triggering CI (elastic#131726)
  Adjust search session management page font size (elastic#131291)
  [Unified search] Fix uptime css problem (elastic#131730)
  [Actionable Observability] Link to filtered rules page (elastic#131629)
  Add openAPI specifications for cases endpoint (elastic#131275)
  Display rule API key owner to users who can manage API keys (elastic#131662)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/server/formats/pdf/index.ts
#	x-pack/plugins/screenshotting/server/screenshots/observable.ts
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants