[Unified observability] Add tour step to guided setup by afgomez · Pull Request #131149 · elastic/kibana

afgomez · 2022-04-28T12:38:22Z

Summary

Show a tour step on the "Guided setup" button on the header when the user dismisses the guided setup progress bar.

Notes for testing.

If you have previously dismissed the guided setup progress bar there is no way to test this PR. If that's the case reset the status running this in your browser's JS console

localStorage.removeItem('DISMISS_GUIDED_SETUP_PROGRESS')

and then reload the page.

elasticmachine · 2022-04-28T12:38:25Z

Pinging @elastic/unified-observability (Team:Unified observability)

formgeist

Looks good, thanks adding this. I noticed that the tour doesn't dismiss when clicking on the Guided setup button. Would be great if that could be implemented to avoid the tour component overlaying the flyout.

x-pack/plugins/observability/public/pages/overview/old_overview_page.tsx

estermv

Looks good! I have only some questions and I'll wait until you address Casper's comment for a second review.

x-pack/plugins/observability/public/pages/overview/old_overview_page.tsx

afgomez · 2022-04-29T13:47:26Z

I noticed that the tour doesn't dismiss when clicking on the Guided setup button.

@formgeist sorry about that! It should be solved now

x-pack/plugins/observability/public/pages/overview/index.tsx

formgeist

LGTM 🚢

kibana-ci · 2022-05-02T10:32:36Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	439.3KB	440.3KB	+970.0B

History

💚 Build #41472 succeeded 569df40
💚 Build #41157 succeeded e9040e203cde5258422d1365c1f91cf23db1f4f8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

estermv

Looks good!!

I noticed a weird animation when the tour appears

Screen.Recording.2022-05-03.at.11.12.33.mov

Is it happening because we use the anchor to render the tour step or is this happening only to me?

afgomez · 2022-05-03T09:53:22Z

@estermv looks like either a bug in the EuiTourStep component or maybe some interaction with any of the containers.

@elastic/eui-design could you chime in?

afgomez · 2022-05-04T07:23:54Z

We are tracking the animation error in elastic/eui#5861

kibanamachine · 2022-05-04T07:23:55Z

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 131149

Questions ?

Please refer to the Backport tool documentation

* Add severity field to create API and migration * Adds integration test for severity field migration * remove exclusive test * Change severity levels * Update integration tests for post case * Add more integration tests * Fix all cases list test * Fix some server test * Fix util server test * Fix client util test * Convert event log's duration from number to string in Kibana (keep as "long" in Elasticsearch) (#130819) * Convert event.duration to string in TypeScript, keep as long in Elasticsearch * Fix jest test * Fix functional tests * Add ecsStringOrNumber to event log schema * Fix jest test * Add utility functions to event log plugin * Use new event log utility functions * PR fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * filter o11y rule aggregations (#131301) * [Cloud Posture] Display and save rules per benchmark (#131412) * Adding aria-label for discover data grid select document checkbox (#131277) * Update API docs (#130999) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [CI] Use GCS buckets for bazel remote caching (#131345) * [Actionable Observability] Add license modal to rules table (#131232) * Add fix license link * fix localization * fix CI error * fix more translation issues Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [RAM] Add shareable rule status filter (#130705) * rule state filter * turn off experiment * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Status filter API call * Fix tests * rename state to status, added tests * Address comments and fix tests * Revert experiment flag * Remove unused translations * Addressed comments Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> * [storybook] Watch for changes in packages (#131467) * [storybook] Watch for changes in packages * Update default_config.ts * Improve saved objects migrations failure errors and logs (#131359) * [Unified observability] Add tour step to guided setup (#131149) * [Lens] Improved interval input (#131372) * [Vega] Adjust vega doc for usage of ems files (#130948) * adjust vega doc * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Excess intersections * Create severity user action * Add severity to create_case user action * Fix and add integration tests * Minor improvements Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: mgiota <panagiota.mitsopoulou@elastic.co> Co-authored-by: Jordan <51442161+JordanSh@users.noreply.github.com> Co-authored-by: Bhavya RM <bhavya@elastic.co> Co-authored-by: Thomas Neirynck <thomas@elastic.co> Co-authored-by: Brian Seeders <brian.seeders@elastic.co> Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co> Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: Nick Peihl <nickpeihl@gmail.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

* Add severity field to create API and migration * Adds integration test for severity field migration * remove exclusive test * Change severity levels * Update integration tests for post case * Add more integration tests * Fix all cases list test * Fix some server test * Fix util server test * Fix client util test * Convert event log's duration from number to string in Kibana (keep as "long" in Elasticsearch) (elastic#130819) * Convert event.duration to string in TypeScript, keep as long in Elasticsearch * Fix jest test * Fix functional tests * Add ecsStringOrNumber to event log schema * Fix jest test * Add utility functions to event log plugin * Use new event log utility functions * PR fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * filter o11y rule aggregations (elastic#131301) * [Cloud Posture] Display and save rules per benchmark (elastic#131412) * Adding aria-label for discover data grid select document checkbox (elastic#131277) * Update API docs (elastic#130999) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [CI] Use GCS buckets for bazel remote caching (elastic#131345) * [Actionable Observability] Add license modal to rules table (elastic#131232) * Add fix license link * fix localization * fix CI error * fix more translation issues Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [RAM] Add shareable rule status filter (elastic#130705) * rule state filter * turn off experiment * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Status filter API call * Fix tests * rename state to status, added tests * Address comments and fix tests * Revert experiment flag * Remove unused translations * Addressed comments Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> * [storybook] Watch for changes in packages (elastic#131467) * [storybook] Watch for changes in packages * Update default_config.ts * Improve saved objects migrations failure errors and logs (elastic#131359) * [Unified observability] Add tour step to guided setup (elastic#131149) * [Lens] Improved interval input (elastic#131372) * [Vega] Adjust vega doc for usage of ems files (elastic#130948) * adjust vega doc * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <nickpeihl@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Peihl <nickpeihl@gmail.com> * Excess intersections * Create severity user action * Add severity to create_case user action * Fix and add integration tests * Minor improvements Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: mgiota <panagiota.mitsopoulou@elastic.co> Co-authored-by: Jordan <51442161+JordanSh@users.noreply.github.com> Co-authored-by: Bhavya RM <bhavya@elastic.co> Co-authored-by: Thomas Neirynck <thomas@elastic.co> Co-authored-by: Brian Seeders <brian.seeders@elastic.co> Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co> Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: Nick Peihl <nickpeihl@gmail.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

afgomez added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:Unified observability v8.3.0 labels Apr 28, 2022

afgomez requested a review from a team as a code owner April 28, 2022 12:38

afgomez requested a review from formgeist April 28, 2022 12:39

formgeist reviewed Apr 28, 2022

View reviewed changes

x-pack/plugins/observability/public/pages/overview/old_overview_page.tsx Outdated Show resolved Hide resolved

estermv reviewed Apr 29, 2022

View reviewed changes

x-pack/plugins/observability/public/pages/overview/old_overview_page.tsx Outdated Show resolved Hide resolved

x-pack/plugins/observability/public/pages/overview/old_overview_page.tsx Outdated Show resolved Hide resolved

afgomez changed the title ~~Add prop to trigger the tour on the header~~ [Unified observability] Add tour step to guided setup Apr 29, 2022

Alejandro Fernández Gómez added 3 commits April 29, 2022 14:46

Add prop to trigger the tour on the header

87c95b1

Show a tour step in the guided setup button

3b99025

Show the tour step when the status is dismissed

09cd344

afgomez force-pushed the 127945-guided-setup-tour branch from e9040e2 to 09cd344 Compare April 29, 2022 13:26

Alejandro Fernández Gómez added 2 commits April 29, 2022 15:36

Move state of tour visibility to the parent

35a2033

Render tour step only if strictly necessary

569df40

afgomez requested review from estermv and formgeist April 29, 2022 13:47

estermv reviewed Apr 29, 2022

View reviewed changes

x-pack/plugins/observability/public/pages/overview/index.tsx Show resolved Hide resolved

formgeist approved these changes May 2, 2022

View reviewed changes

Alejandro Fernández Gómez added 2 commits May 2, 2022 11:06

Merge branch 'main' into 127945-guided-setup-tour

a0b0fba

Use an anchor point for the step

5dd891b

afgomez requested a review from estermv May 2, 2022 11:08

estermv reviewed May 3, 2022

View reviewed changes

afgomez mentioned this pull request May 3, 2022

[EuiTourStep] Strange behaviour when animating the tour step. elastic/eui#5861

Closed

afgomez merged commit b7d42ea into elastic:main May 4, 2022

afgomez deleted the 127945-guided-setup-tour branch May 4, 2022 07:23

kibanamachine added the backport:skip This PR does not require backporting label May 4, 2022

kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022

[Unified observability] Add tour step to guided setup (elastic#131149)

9b1b47d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unified observability] Add tour step to guided setup#131149

[Unified observability] Add tour step to guided setup#131149
afgomez merged 7 commits intoelastic:mainfrom
afgomez:127945-guided-setup-tour

afgomez commented Apr 28, 2022 •

edited

Loading

Uh oh!

elasticmachine commented Apr 28, 2022

Uh oh!

formgeist left a comment

Uh oh!

Uh oh!

estermv left a comment

Uh oh!

Uh oh!

Uh oh!

afgomez commented Apr 29, 2022

Uh oh!

Uh oh!

formgeist left a comment

Uh oh!

kibana-ci commented May 2, 2022

Uh oh!

estermv left a comment

Uh oh!

afgomez commented May 3, 2022 •

edited

Loading

Uh oh!

afgomez commented May 4, 2022

Uh oh!

kibanamachine commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

afgomez commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes for testing.

Uh oh!

elasticmachine commented Apr 28, 2022

Uh oh!

formgeist left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

estermv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

afgomez commented Apr 29, 2022

Uh oh!

Uh oh!

formgeist left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented May 2, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

estermv left a comment

Choose a reason for hiding this comment

Uh oh!

afgomez commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

afgomez commented May 4, 2022

Uh oh!

kibanamachine commented May 4, 2022

⚪ Backport skipped

Manual backport

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

afgomez commented Apr 28, 2022 •

edited

Loading

afgomez commented May 3, 2022 •

edited

Loading