Upgrade EUI to v51.1.0 by thompsongl · Pull Request #126926 · elastic/kibana

thompsongl · 2022-03-04T16:02:49Z

Summary

eui@48.1.1 ⏩ eui@51.1.0

All breaking changes have been accounted for

`51.1.0`

Updated testenv mock for EuiFlyout to include default aria-label on the close button (#5702)
Changed the I18n token euiDataGridToolbar.fullScreenButton to euiFullscreenSelector.fullscreenButton, and its text to Enter fullscreen (with no space) (#5680)
Changed the I18n token euiDataGridToolbar.fullScreenButtonActive to euiFullscreenSelector.fullscreenButtonActive, and its text to Exit fullscreen (with no space) (#5680)

Bug fixes

Fixed type of SharedRenderCellElementProps.schema to be optional (#5704)
Fixed generated type definition file referencing nonexistant Jest util (#5704)

`51.0.0`

Enhanced EuiSuggest to fire the onItemClick callback on Enter key press as well as clicks (#5693)

Bug fixes

Fixed non-searchable EuiSelectables not selecting items with the Enter & Space keys (#5693)

Breaking changes

Removed the 'all' option in EuiTablePagination.itemsPerPage and itemsPerPageOptions in EuiBasicTable and EuiDataGrid due to Typescript issues. Use 0 instead to represent a "Show all" option (#5699)

`50.0.0`

Updated EuiComboBox to WAI-ARIA 1.2 pattern and improved keyboard navigation (#5636)
Added readOnly prop to EuiMarkdownEditor (#5627)
Added support for supplying breadcrumbs and breadcrumbProps directly to EuiPageHeader (#5634)
Extended props of EuiBreadcrumb to include HTMLElement and color inherited from EuiLink (#5634)
Added "xxl" size to EuiLoadingSpinner (#5668)
Added isLoading prop to EuiButtonIcon (#5668)
Updated EuiDataGrid to allow setting individual cell isExpandable state via setCellProps (#5667)
Added the ability for EuiSelectable and EuiSuggest to accept controlled value props (#5658)
Added textWrap to EuiSelectableListItem, EuiSelectableList, and EuiSelectable.listOptions (#5679)
Forced truncation on EuiSuggest items when isVirtualize (#5679)
Changed proportion handling between content and image in horizontal EuiEmptyPrompt and added spacing between (#5663)
Reduced SASS compilation time using a different math pow implementation (#5674)

Bug fixes

Fixed EuiDataGrid cell props not resetting on column sort (#5665)
Fixed EuiDataGrid not correctly closing cell popovers when the originating cell is clicked (#5681)
Fixed EuiSuggest not correctly passing props to the search input (#5658)
Fixed EuiSelectable incorrectly rendering the passed id prop on the listbox instead of the parent wrapper (#5658)
Fixed EuiSelectable to no longer call searchProps.onChange when list items are clicked (#5658)
Fixed EuiSelectable not respecting searchProps.inputRef (#5658)
Fixed render of EuiSelectableListItem when no icons are present (#5679)
Fixed render of EuiSelectableTemplateSitewide items when no icons are present (#5679)

Breaking changes

Removed the incremental prop from EuiSuggest and EuiSelectable's searchProps (#5658)
Removed EuiSelectable's searchProps.onSearch prop (since Enter keypresses do not trigger a search callback) - use searchProps.onChange instead (#5658)
Renamed EuiSuggest's onInputChange and onSearchChange callbacks to onInput/onSearch respectively, for consistency with our existing callback naming conventions (#5658)
Removed EuiSuggest's isLoading prop - use status.loading instead (#5658)

`49.0.0`

Added new renderCellPopover prop to EuiDataGrid (#5640)
Added cell schema info to EuiDataGrid's renderCellValue props (#5640)
Added isLoading prop to EuiDualRange (#5648)
Added an 'all' option to EuiTablePagination.itemsPerPage and itemsPerPageOptions to render a "Show all" option and updated EuiBasicTable and EuiDataGrid usages (#5547)

Bug fixes

Fixed EuiImage images' width in small containers by adding max-width: 100% (#5547)
Fixed EuiTablePagination layout in small containers by adding wrap (#5547)
Fixed EuiDataGrid throwing a console error when grids without trailing control columns are sorted and then all columns are hidden (#5635)

Breaking changes

Removed popoverContents props from EuiDataGrid (use new renderCellPopover instead) (#5640)
Changed the EuiTablePagination prop hidePerPageOptions to the positive form showPerPageOptions (#5547)

…umeric popover content instead of `renderCellPopover` - since no especially custom popover rendering is occuring, just conditional content

This reverts commit 127c9e5.

estermv

Unified Observability changes LGTM

ymao1

Response Ops changes LGTM. Code review only.

YulNaumenko

Security Solution changes LGTM

walterra

ML/Transform changes LGTM, also did a local test. Thanks for the popover refactor!!

thompsongl · 2022-03-15T14:52:46Z

All remaining codeowner reviews are for snapshot updates or hidePerPageOptions to showPerPageOptions type changes. I'll merge (pending CI) EOD or first thing tomorrow morning (US Central).

thompsongl · 2022-03-16T15:46:23Z

@elastic/kibana-reporting-services @elastic/security-onboarding-and-lifecycle-mgt @elastic/uptime @elastic/apm-ui @elastic/kibana-vis-editors @joeypoon @dasansol92

🙏 Still looking for reviews; I'd like to get this merged this week.

joeypoon

👌 for OLM

awahab07

Uptime changes LGTM.

kibana-ci · 2022-03-16T21:12:19Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.7MB	2.7MB	+1.0B
`dataViewFieldEditor`	148.0KB	148.0KB	-37.0B
`lens`	1.1MB	1.1MB	-15.0B
`ml`	3.3MB	3.3MB	-189.0B
`observability`	408.6KB	408.4KB	-184.0B
`securitySolution`	4.8MB	4.8MB	-1.0B
total			-425.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	295.3KB	295.8KB	+574.0B
`globalSearchBar`	19.7KB	19.6KB	-153.0B
`kbnUiSharedDeps-css`	592.6KB	595.5KB	+3.0KB
`kbnUiSharedDeps-npmDll`	4.8MB	4.8MB	+1.4KB
total			+4.7KB

History

💛 Build #30981 was flaky c975946
💔 Build #30962 failed b6201dc
💚 Build #30717 succeeded 4fdd7e6
💔 Build #30588 failed 2148508
💔 Build #30542 failed 5619ca1
💔 Build #30511 failed cb09d99

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spalger · 2022-03-16T21:39:03Z

Merging early without the last few reviews, but we're pretty sure this won't be a problem and there have been tons of eyes on this already.

* eui to v50.0.0 * i18n tokens * Deprecate EuiDataGrid's `popoverContents` prop for `renderCellPopover` * [optional ML refactor] Use `renderCellValue.isDetails` to customize numeric popover content instead of `renderCellPopover` - since no especially custom popover rendering is occuring, just conditional content * onChangeItemsPerPage update * storyshots updates * snapshot updates * snapshot updates * snapshot updates * snapshot updates * EuiComboBox listbox -> combobox * remove invalid combobox aria attr * Revert "onChangeItemsPerPage update" This reverts commit 127c9e5. * eui to v51.0.0 * WIP: schema * WIP: schema * EuiSelectable API changes * WIP: schema * hidePerPageOptions -> showPerpageOptions * WIP: schema * hidePerPageOptions -> showPerpageOptions * WIP: schema * breadcrumbs type * clean up * snapshot updates * Fix E2E datagrid cell filter action test - This changed in 50.0.0 because of elastic/eui#5681 - `await testSubjects.click('filterForButton')` applies to both the cell action button icon and the cell popover button - The test was trying to click the cell action button icon and not the popover button, which closed the popover and caused nothing to actually get clicked - the solution I went with was to simply avoid opening the cell popover but instead click the cell action icon directly * WIP: selectable search * clean up * eui to v51.1.0 * i18n tokens * resolve SharedRenderCellElementProps.schema optionality * i18n, snapshot updates * shapshot update * consolidate url-parse Co-authored-by: Constance Chen <constance.chen@elastic.co>

kibanamachine · 2022-03-18T21:46:19Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126926 or prevent reminders by adding the backport:skip label.

thompsongl added 2 commits March 4, 2022 09:58

eui to v50.0.0

4178bf8

i18n tokens

6bae78b

thompsongl added release_note:skip Skip the PR/issue when compiling release notes EUI ci:deploy-cloud v8.2.0 labels Mar 4, 2022

cee-chen and others added 4 commits March 4, 2022 09:13

Deprecate EuiDataGrid's popoverContents prop for renderCellPopover

7a5e5a2

[optional ML refactor] Use renderCellValue.isDetails to customize n…

46f433e

…umeric popover content instead of `renderCellPopover` - since no especially custom popover rendering is occuring, just conditional content

onChangeItemsPerPage update

127c9e5

Merge branch 'main' into eui/50.0

08a8d82

cee-chen mentioned this pull request Mar 4, 2022

[EuiSuggest] Fire onItemClick callback on Enter key presses; [EuiSelectable] Fix Enter and Space key to select items on non-searchable listboxes elastic/eui#5693

Merged

10 tasks

thompsongl added 9 commits March 7, 2022 09:13

Merge branch 'main' into eui/50.0

65034f4

storyshots updates

dd6bbf9

snapshot updates

84c6606

snapshot updates

5129e1b

snapshot updates

0275e2d

Merge branch 'main' into eui/50.0

68957e9

snapshot updates

67f7112

EuiComboBox listbox -> combobox

226317b

Merge branch 'main' into eui/50.0

47734f0

thompsongl mentioned this pull request Mar 7, 2022

[EuiTablePagination] Incorrect type for itemsPerPage and itemsPerPageOptions depending on pagination.pageSizeOptions elastic/eui#5697

Closed

thompsongl added 5 commits March 7, 2022 17:50

remove invalid combobox aria attr

c85ea44

Merge branch 'main' into eui/50.0

23d2d8d

Revert "onChangeItemsPerPage update"

7b818a5

This reverts commit 127c9e5.

eui to v51.0.0

4f02def

Merge branch 'main' into eui/50.0

543a072

thompsongl changed the title ~~Upgrade EUI to v50.0.0~~ Upgrade EUI to v51.0.0 Mar 8, 2022

thompsongl added 3 commits March 8, 2022 16:38

WIP: schema

e2ce846

WIP: schema

765d827

EuiSelectable API changes

0292bd0

pgayvallet approved these changes Mar 14, 2022

View reviewed changes

estermv approved these changes Mar 14, 2022

View reviewed changes

ymao1 approved these changes Mar 14, 2022

View reviewed changes

thompsongl added 2 commits March 14, 2022 09:19

Merge branch 'main' into eui/50.0

959f244

Merge branch 'main' into eui/50.0

8069e77

YulNaumenko approved these changes Mar 14, 2022

View reviewed changes

walterra approved these changes Mar 15, 2022

View reviewed changes

thompsongl added 2 commits March 15, 2022 09:38

Merge branch 'main' into eui/50.0

87b7ddd

consolidate url-parse

cb09d99

thompsongl added 5 commits March 15, 2022 10:16

Merge branch 'main' into eui/50.0

5619ca1

Merge branch 'main' into eui/50.0

2148508

Merge branch 'main' into eui/50.0

4fdd7e6

Merge branch 'main' into eui/50.0

b6201dc

Merge branch 'main' into eui/50.0

c975946

joeypoon approved these changes Mar 16, 2022

View reviewed changes

awahab07 approved these changes Mar 16, 2022

View reviewed changes

Merge branch 'main' into eui/50.0

e81a59a

spalger merged commit 854da93 into elastic:main Mar 16, 2022

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2022

spalger added the backport:skip This PR does not require backporting label Mar 18, 2022

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2022

peteharverson mentioned this pull request Apr 14, 2022

[ML] Fixes cell popover in data frame analytics results grid #130293

Merged

1 task

tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v51.1.0#126926

Upgrade EUI to v51.1.0#126926
spalger merged 59 commits intoelastic:mainfrom
thompsongl:eui/50.0

thompsongl commented Mar 4, 2022 •

edited

Loading

Uh oh!

estermv left a comment

Uh oh!

ymao1 left a comment •

edited

Loading

Uh oh!

YulNaumenko left a comment

Uh oh!

walterra left a comment

Uh oh!

thompsongl commented Mar 15, 2022

Uh oh!

thompsongl commented Mar 16, 2022

Uh oh!

joeypoon left a comment

Uh oh!

awahab07 left a comment

Uh oh!

kibana-ci commented Mar 16, 2022

Uh oh!

spalger commented Mar 16, 2022

Uh oh!

kibanamachine commented Mar 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

thompsongl commented Mar 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

51.1.0

51.0.0

50.0.0

49.0.0

Uh oh!

estermv left a comment

Choose a reason for hiding this comment

Uh oh!

ymao1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Mar 15, 2022

Uh oh!

thompsongl commented Mar 16, 2022

Uh oh!

joeypoon left a comment

Choose a reason for hiding this comment

Uh oh!

awahab07 left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Mar 16, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

spalger commented Mar 16, 2022

Uh oh!

kibanamachine commented Mar 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

thompsongl commented Mar 4, 2022 •

edited

Loading

`51.1.0`

`51.0.0`

`50.0.0`

`49.0.0`

ymao1 left a comment •

edited

Loading