[EuiDualRange] Add isLoading prop#5648
Merged
elizabetdev merged 4 commits intoelastic:mainfrom Feb 17, 2022
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5648/ |
elizabetdev
commented
Feb 17, 2022
thompsongl
approved these changes
Feb 17, 2022
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding tests!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5648/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5648/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
isLoadingprop to EuiDualRange. Similar to EuiRange the loading only shows ifshowInput = inputWithPopover.Closes #5645.
Checklist
[ ] Checked in mobile[ ] Added documentation[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes