Skip to content

[ML] Fixes cell popover in data frame analytics results grid#130293

Merged
peteharverson merged 1 commit intoelastic:mainfrom
peteharverson:ml-dfa-results-popover-fix
Apr 15, 2022
Merged

[ML] Fixes cell popover in data frame analytics results grid#130293
peteharverson merged 1 commit intoelastic:mainfrom
peteharverson:ml-dfa-results-popover-fix

Conversation

@peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Apr 14, 2022

Summary

Fixes regression introduced by #126926, where the data frame analytics results page would fail to render if opening a popover on a cell (other than the feature importance or feature influence cells) in the results data grid.

Before: see example in #130277

After fix:

dfa_results_grid_popover

Checklist

Fixes #130277

@peteharverson peteharverson added review :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v8.2.0 v8.3.0 labels Apr 14, 2022
@peteharverson peteharverson requested a review from a team as a code owner April 14, 2022 16:28
@peteharverson peteharverson self-assigned this Apr 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.3MB 3.3MB +13.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡ 🙏

@peteharverson peteharverson added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 15, 2022
@peteharverson peteharverson merged commit a72d157 into elastic:main Apr 15, 2022
kibanamachine pushed a commit that referenced this pull request Apr 15, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 15, 2022
#130396)

(cherry picked from commit a72d157)

Co-authored-by: Pete Harverson <pete@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes review v8.2.0 v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ML] Data Frame Analytics result - show blank web page after clicking interact with cell content

5 participants