[EuiDataGrid] Fix cell expansion popover not correctly closing when clicking the originating cell#5681
Merged
cee-chen merged 4 commits intoelastic:mainfrom Mar 3, 2022
Merged
Conversation
(which should occur when clicking back into the originating cell)
- to associate certain props more with one another
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5681/ |
cchaos
approved these changes
Mar 3, 2022
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
🙌 LGTM! Thanks for the quick fix
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5681/ |
cee-chen
added a commit
to thompsongl/kibana
that referenced
this pull request
Mar 9, 2022
- This changed in 50.0.0 because of elastic/eui#5681 - `await testSubjects.click('filterForButton')` applies to both the cell action button icon and the cell popover button - The test was trying to click the cell action button icon and not the popover button, which closed the popover and caused nothing to actually get clicked - the solution I went with was to simply avoid opening the cell popover but instead click the cell action icon directly
spalger
pushed a commit
to elastic/kibana
that referenced
this pull request
Mar 16, 2022
* eui to v50.0.0 * i18n tokens * Deprecate EuiDataGrid's `popoverContents` prop for `renderCellPopover` * [optional ML refactor] Use `renderCellValue.isDetails` to customize numeric popover content instead of `renderCellPopover` - since no especially custom popover rendering is occuring, just conditional content * onChangeItemsPerPage update * storyshots updates * snapshot updates * snapshot updates * snapshot updates * snapshot updates * EuiComboBox listbox -> combobox * remove invalid combobox aria attr * Revert "onChangeItemsPerPage update" This reverts commit 127c9e5. * eui to v51.0.0 * WIP: schema * WIP: schema * EuiSelectable API changes * WIP: schema * hidePerPageOptions -> showPerpageOptions * WIP: schema * hidePerPageOptions -> showPerpageOptions * WIP: schema * breadcrumbs type * clean up * snapshot updates * Fix E2E datagrid cell filter action test - This changed in 50.0.0 because of elastic/eui#5681 - `await testSubjects.click('filterForButton')` applies to both the cell action button icon and the cell popover button - The test was trying to click the cell action button icon and not the popover button, which closed the popover and caused nothing to actually get clicked - the solution I went with was to simply avoid opening the cell popover but instead click the cell action icon directly * WIP: selectable search * clean up * eui to v51.1.0 * i18n tokens * resolve SharedRenderCellElementProps.schema optionality * i18n, snapshot updates * shapshot update * consolidate url-parse Co-authored-by: Constance Chen <constance.chen@elastic.co>
maksimkovalev
pushed a commit
to maksimkovalev/kibana
that referenced
this pull request
Mar 18, 2022
* eui to v50.0.0 * i18n tokens * Deprecate EuiDataGrid's `popoverContents` prop for `renderCellPopover` * [optional ML refactor] Use `renderCellValue.isDetails` to customize numeric popover content instead of `renderCellPopover` - since no especially custom popover rendering is occuring, just conditional content * onChangeItemsPerPage update * storyshots updates * snapshot updates * snapshot updates * snapshot updates * snapshot updates * EuiComboBox listbox -> combobox * remove invalid combobox aria attr * Revert "onChangeItemsPerPage update" This reverts commit 127c9e5. * eui to v51.0.0 * WIP: schema * WIP: schema * EuiSelectable API changes * WIP: schema * hidePerPageOptions -> showPerpageOptions * WIP: schema * hidePerPageOptions -> showPerpageOptions * WIP: schema * breadcrumbs type * clean up * snapshot updates * Fix E2E datagrid cell filter action test - This changed in 50.0.0 because of elastic/eui#5681 - `await testSubjects.click('filterForButton')` applies to both the cell action button icon and the cell popover button - The test was trying to click the cell action button icon and not the popover button, which closed the popover and caused nothing to actually get clicked - the solution I went with was to simply avoid opening the cell popover but instead click the cell action icon directly * WIP: selectable search * clean up * eui to v51.1.0 * i18n tokens * resolve SharedRenderCellElementProps.schema optionality * i18n, snapshot updates * shapshot update * consolidate url-parse Co-authored-by: Constance Chen <constance.chen@elastic.co>
cee-chen
added a commit
to cee-chen/eui
that referenced
this pull request
Apr 14, 2022
3 tasks
cee-chen
pushed a commit
that referenced
this pull request
Apr 15, 2022
…fecting complex cell popovers (#5797) * Revert #5681 * Fix closing the cell popover when the cell is clicked - in a more targeted manner that doesn't affect popovers with complex focus children (e.g. modals, nested popovers) * Add changelog entry * Fix for failing Cypress test - because I put the new logic inside the setTimeout, Cypress was opening the popover too quickly and the new logic was instantly closing it *derp* - the new logic probably doesn't need to be in a timeout, so moving it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #5190
The main fix is the
onTrapDeactivation={closeCellPopover}prop addition, the other diffs are me just reordering propsQA
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for breaking changes and labeled appropriately