[EuiComboBox] Revising to WAI-ARIA 1.2 spec.#5636
[EuiComboBox] Revising to WAI-ARIA 1.2 spec.#56361Copenut merged 10 commits intoelastic:mainfrom 1Copenut:feature/tpierce-eui-5301-combobox
Conversation
* Updated EuiCombobox to WAI-ARIA 1.2 pattern * Fixing one unit test selector.
|
Just to check, is this an intermediate step until we refactor EuiComboBox to use EuiSelectable? Or if that's coming up very soon, would it be more worth it to wait for that more holistic refactor? (Not sure if it is, this is fine if so) |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5636/ |
|
@constancecchen Yeah, that seems like an easy one to add to ^^ this PR. I'll fold it in. Should be working on the last items after lunch today. Appreciate the heads up. |
* Removing open/close button from tab order, updating snapshots. * Adding i18n to the listbox aria-label.
1Copenut
left a comment
1Copenut
left a comment
There was a problem hiding this comment.
Left general review notes about changes.
I don't think these rise to the level of breaking changes, but if reviewers feel different, I'll add the breaking change tag and make sure to be available to help with next Kibana upgrade.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5636/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5636/ |
1Copenut
requested review from
chandlerprall
and removed request for
thompsongl
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5636/ |
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks for super thoroughly responding to all my feedback! ❤️
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Needs to merge with main again & update the changelog entry to the right location (otherwise git'll merge it into the v49 release)
Otherwise this LGTM! That was a smaller changeset than I was expecting for this change 🎉 . Thanks for linking directly to the WAI 1.2 combobox example, definitely helped streamline the review to directly compare that with our implementation.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5636/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5636/ |
4 participants
Summary
The axe browser and CLI scan was throwing a few errors on our
EuiComboboxcomponent. I refactored it to match the WAI-ARIA 1.2 pattern for combobox with a listbox autocomplete.This PR closes #5301 and closes #5024.
Have a few items to complete before bringing the PR out of draft:
aria-autocomplete="list"attribute to the inputi18nto the default accessible listbox labelChecklist
Props have proper autodocs and playground toggles