Merged
Conversation
thompsongl
added
release_note:skip
Contributor
|
Pinging @elastic/eui-design (EUI) |
afharo
reviewed
Jan 25, 2022
src/core/public/overlays/flyout/__snapshots__/flyout_service.test.tsx.snap
Show resolved
Hide resolved
YulNaumenko
approved these changes
Jan 26, 2022
Contributor
YulNaumenko
left a comment
YulNaumenko
left a comment
There was a problem hiding this comment.
Tested locally Security Threat Hunting changes related to EuiDataGrid. LGTM!
Member
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Jan 28, 2022
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Jan 31, 2022
* eui to 46.1.0 * use optimize build * dataGridWrapper -> euiDataGridBody * remove unused dep from bazel * use column-index and row-index attrs * datagrid test fixes * prevent duplicate global styles * snapshot updates * rendering_service test * update comment * clean up Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eui@44.0.0⏩eui@46.1.0optimize/esbuild for smaller footprintkbnUiSharedDeps-npmDll | 6.1MB | 4.8MB | -1.3MBCoreContextProviderto conditionally add global styles46.1.0sunglyph toEuiIcon(#5548)EuiDescriptionListoftypeinline (#5534)46.0.0optimizebuild as a lighter weight option more suited to production environments (#5527)letteringglyph toEuiIcon(#5525)euiCustomControlFocusedmixin to use$euiFocusRingColorinstead ofcurrentColor(#5479)betaBadgeTooltipPropstoEuiKeyPadMenuItemto extend the wrappingEuiToolTip(#5541)globalStylesprop toEuiProviderto allow for global style customization (#5497)EuiGlobalStylescomponent (#5497)Bug fixes
euiCustomControlFocusedmixin to use$euiFocusRingColorinstead ofcurrentColor(#5479)EuiDataGridnot fully scrolling cells into view (#5515)EuiKeyPadMenuItemaccessibility issue where there was a nested focusable element (#5541)Deprecations
data-gridcell-idfromEuiDataGridin favor of 4 new and more flexible props -data-gridcell-column-id,data-gridcell-column-index,data-gridcell-row-index, anddata-gridcell-visible-row-index(#5515)Breaking changes
EuiKeyPadMenuItemnow wraps itself withEuiToolTipwhenbetaBadgeLabelis supplied forcing top element style props to be passed viabetaBadgeTooltipProps(#5541)45.0.0EuiSelectableListwithisVirtualized(#5521)EuiSelectableOptionwithdata(#5521)Bug fixes
EuiDataGridkeyboard focus restoration (#5530)EuiDataGrid's display toolbar control to update initial UI state when developergridStyleorrowHeightsOptionsprops are updated (#5525)Breaking changes
EuiSearchBarto preserve phrases with leading and trailing spaces, instead of dropping surrounding whitespace (#5514)data-test-subj="dataGridWrapper"fromEuiDataGridin favor ofdata-test-subj="euiDataGridBody"(#5506)