[EuiSelectable] isVirtualized and data#5521
Merged
thompsongl merged 7 commits intoelastic:mainfrom Jan 11, 2022
Merged
Conversation
9 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5521/ |
cchaos
suggested changes
Jan 6, 2022
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Thank you for splitting this off. It's much easier to concentrate on specific changes.
src/components/selectable/selectable_list/selectable_list.test.tsx
Outdated
Show resolved
Hide resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5521/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5521/ |
thompsongl
changed the title
isVirtualized and labelPropsisVirtualized and data
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5521/ |
cchaos
approved these changes
Jan 11, 2022
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Pushed you a quick update to the docs and fix in the Sass to hide overflow of the items.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5521/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convenience PR to pull out shared features in #5157 and #5387:
isVirtualizedoption to EuiSelectableListEuiSuggestwill usefalsewhen implementeddatato EuiSelectableList items for passing through dataFieldValueSelectionFilterandEuiSuggest)EuiSelectableChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile