Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5527/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5527/ |
|
Changes LGTM, build runs locally. Have you tested building Kibana with the optimize version & the webpack alias? |
Yep! That's how I validated the
|
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5527/ |
chandlerprall
left a comment
There was a problem hiding this comment.
Looking forward to seeing the dll bundle difference!
cee-chen
left a comment
There was a problem hiding this comment.
🎉 also similarly excited!!
Summary
Begins #5537
optimizebuild:kbn-ui-shared-depsuses (without possible exception) the production version of librariesprocess.env-based split in EUI without further planningpropTypesgeneration@babel/plugin-transform-runtime@babel/runtime(Kibana already does)optimize/lib/is nearly half the size oflib/(3.7MB vs 7.1MB) 😳Checklist