Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5548/ |
cchaos
approved these changes
Jan 19, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5548/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR adds a
sunglyph to EuiIcon.The idea of the
sunis to be used to toggle dark and light modes, so I focused on making the icon look similar to themoonicon. That's the reason the icon is filled and not linear.The ray of the
suncould have 1px to fit the grid. But this would make the icon not being centered and look smaller when compared with themoon. So I ended up with rays of 1.5px.In case there's an animation to toggle from a
moontosunthe animation would look better. Both icons will have the same center and similar weight.Here are some tests: https://codesandbox.io/s/eager-field-i8r8q?file=/demo.js
Design
Dark and light themes
My computer is using the macOS Monterey. I no longer have the option to open the browser in low res. So I'm using the following app http://easyresapp.com/ to test in low res. Hopefully, the tests correspond to reality.
Checklist