[EuiSearchBar] Allow phrases with leading and trailing spaces#5514
Merged
cee-chen merged 6 commits intoelastic:mainfrom Jan 6, 2022
Merged
[EuiSearchBar] Allow phrases with leading and trailing spaces#5514cee-chen merged 6 commits intoelastic:mainfrom
cee-chen merged 6 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5514/ |
chandlerprall
approved these changes
Jan 5, 2022
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Nice solve! We should mark this a breaking change as it does divert from that previous intention of dropping the white space.
Need to revert the example as well.
cee-chen
commented
Jan 5, 2022
cee-chen
commented
Jan 5, 2022
cee-chen
added
the
breaking change
This reverts commit 3454ad8.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5514/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See elastic/kibana#122237 - filter values with leading or trailing spaces were resulting in buggy behavior within EuiSearchBar. The search bar should now correctly preserve leading and trailing spaces within phrases.
Before
Notice in particular that
owner:" dewey"is not removing the correct filterAfter
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for accessibility including keyboard-only and screenreader modes