[babel] ensure TS preset runs before anything else#119107
Merged
spalger merged 5 commits intoelastic:mainfrom Nov 29, 2021
Merged
[babel] ensure TS preset runs before anything else#119107spalger merged 5 commits intoelastic:mainfrom
spalger merged 5 commits intoelastic:mainfrom
Conversation
spalger
force-pushed
the
implement/declare-support-ts
branch
7 times, most recently
from
c625624 to
eb1d67a
Compare
spalger
force-pushed
the
implement/declare-support-ts
branch
3 times, most recently
from
dd109a5 to
d5cfed8
Compare
spalger
force-pushed
the
implement/declare-support-ts
branch
from
d5cfed8 to
3cf65f9
Compare
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Nov 24, 2021
jportner
approved these changes
Nov 25, 2021
Contributor
jportner
left a comment
jportner
left a comment
There was a problem hiding this comment.
Security unit test changes LGTM. We should really remove these inline snapshots 🙈
sebelga
approved these changes
Nov 25, 2021
Contributor
sebelga
left a comment
sebelga
left a comment
There was a problem hiding this comment.
Stack management changes LGTM 👍
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ThomThomson
approved these changes
Nov 29, 2021
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Presentation team changes LGTM! Nice to see the viewport type error which has been bugging me locally hopefully getting resolved!
spalger
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 29, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2021
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 29, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # packages/kbn-storybook/src/webpack.config.ts # src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
spalger
pushed a commit
that referenced
this pull request
Nov 29, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # packages/kbn-storybook/src/webpack.config.ts # src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118926
In order to support
declareclass properties the@babel/preset-typescriptconfig needs to be executed first so that it can modify the AST for class properties before any other babel plugins. This required adopting new TS semantics around class property initializers (handled in #119130, #119227 and #119252) as well as upgrading storybook (handled in #119498) so that we can have the same support in storybooks unique babel config.This also leads to the order of properties on objects created via classes being subtly different, which is unfortunate but it doesn't seem like we are depending on that anywhere.
As you can see in https://github.com/spalger/kibana/blob/implement/declare-support-ts/src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx#L35 this is now functioning as of this PR.