[storybook] upgrade to 6.3.x by spalger · Pull Request #119498 · elastic/kibana

spalger · 2021-11-23T15:57:40Z

No description provided.

…sion

spalger · 2021-11-23T21:49:42Z

@elasticmachine merge upstream

kibana-ci · 2021-11-23T23:11:22Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1156	1155	-1
`dataVisualizer`	335	334	-1
`discover`	356	355	-1
`enterpriseSearch`	1328	1327	-1
`graph`	142	141	-1
`lens`	684	683	-1
`lists`	294	293	-1
`maps`	801	800	-1
`osquery`	238	237	-1
`presentationUtil`	266	265	-1
`securitySolution`	2758	2784	+26
`stackAlerts`	48	47	-1
total			+15

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/storybook`	18	20	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`advancedSettings`	872.2KB	872.3KB	+20.0B
`apm`	2.7MB	2.7MB	-314.0B
`canvas`	1020.4KB	1020.7KB	+398.0B
`cases`	299.8KB	300.2KB	+378.0B
`dashboard`	274.0KB	274.0KB	+72.0B
`dataEnhanced`	45.1KB	45.2KB	+40.0B
`dataViewFieldEditor`	142.2KB	142.4KB	+220.0B
`dataViewManagement`	79.7KB	79.7KB	+20.0B
`dataVisualizer`	538.4KB	538.1KB	-312.0B
`discover`	312.6KB	312.0KB	-608.0B
`enterpriseSearch`	1.3MB	1.3MB	-272.0B
`expressionError`	13.8KB	13.9KB	+40.0B
`expressionMetricVis`	8.3KB	8.3KB	+20.0B
`expressionTagcloud`	7.6KB	7.6KB	+20.0B
`fleet`	635.2KB	635.2KB	+20.0B
`graph`	390.5KB	390.2KB	-273.0B
`home`	77.1KB	77.1KB	+20.0B
`indexLifecycleManagement`	148.0KB	148.0KB	+20.0B
`infra`	928.7KB	928.7KB	+20.0B
`ingestPipelines`	452.7KB	452.7KB	+24.0B
`inputControlVis`	80.4KB	80.4KB	+40.0B
`kibanaLegacy`	57.3KB	57.3KB	+20.0B
`lens`	966.8KB	966.5KB	-271.0B
`lists`	142.6KB	142.2KB	-331.0B
`management`	8.5KB	8.5KB	+20.0B
`maps`	2.6MB	2.6MB	-272.0B
`ml`	3.5MB	3.5MB	+19.0B
`monitoring`	435.5KB	435.5KB	+20.0B
`observability`	354.6KB	354.6KB	+20.0B
`osquery`	943.2KB	942.2KB	-1001.0B
`presentationUtil`	207.5KB	207.5KB	+39.0B
`remoteClusters`	83.4KB	83.5KB	+20.0B
`reporting`	56.3KB	56.3KB	+40.0B
`rollup`	129.0KB	129.0KB	+20.0B
`savedObjectsManagement`	82.7KB	82.8KB	+40.0B
`savedObjectsTagging`	40.5KB	40.5KB	+20.0B
`securitySolution`	4.5MB	4.5MB	+4.2KB
`spaces`	152.3KB	152.3KB	+80.0B
`stackAlerts`	159.8KB	159.4KB	-314.0B
`timelines`	202.5KB	202.9KB	+378.0B
`triggersActionsUi`	778.0KB	778.3KB	+300.0B
`uiActionsEnhanced`	127.5KB	127.5KB	+40.0B
`upgradeAssistant`	134.7KB	134.7KB	+20.0B
`visDefaultEditor`	142.4KB	142.5KB	+20.0B
`visTypeMarkdown`	5.5KB	5.5KB	+20.0B
`visTypePie`	50.4KB	50.4KB	+20.0B
`visTypeTable`	15.7KB	15.7KB	+20.0B
`visTypeTimelion`	88.0KB	88.0KB	+60.0B
`visTypeTimeseries`	447.5KB	447.6KB	+60.0B
`visTypeVega`	1.9MB	1.9MB	+60.0B
`visTypeVislib`	359.3KB	359.3KB	+20.0B
`visTypeXy`	60.5KB	60.5KB	+20.0B
`visualizations`	59.1KB	59.2KB	+60.0B
`visualize`	49.7KB	49.7KB	+20.0B
total			+3.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`kibana`	895	894	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`banners`	6.5KB	6.5KB	+20.0B
`charts`	56.1KB	56.2KB	+20.0B
`console`	12.1KB	12.1KB	+20.0B
`core`	272.6KB	272.6KB	+20.0B
`data`	438.0KB	438.0KB	+20.0B
`dataViewEditor`	10.7KB	10.7KB	+20.0B
`devTools`	10.5KB	10.5KB	+20.0B
`embeddable`	63.4KB	63.4KB	+20.0B
`esUiShared`	122.5KB	122.5KB	+20.0B
`expressions`	87.2KB	87.2KB	+20.0B
`fieldFormats`	46.2KB	46.2KB	+20.0B
`globalSearchBar`	19.6KB	19.6KB	+20.0B
`indexManagement`	27.1KB	27.1KB	+20.0B
`inspector`	22.3KB	22.3KB	+20.0B
`interactiveSetup`	58.3KB	58.4KB	+20.0B
`kbnUiSharedDeps-npmDll`	5.0MB	5.0MB	+874.0B
`kibanaOverview`	15.5KB	15.5KB	+20.0B
`kibanaReact`	58.5KB	58.5KB	+20.0B
`licenseManagement`	10.2KB	10.2KB	+20.0B
`navigation`	8.7KB	8.7KB	+20.0B
`painlessLab`	10.5KB	10.5KB	+20.0B
`presentationUtil`	68.5KB	68.2KB	-311.0B
`savedObjects`	30.5KB	30.5KB	+20.0B
`searchprofiler`	21.3KB	21.3KB	+20.0B
`security`	50.0KB	50.1KB	+20.0B
`share`	52.9KB	52.9KB	+20.0B
`snapshotRestore`	26.6KB	26.6KB	+20.0B
`transform`	14.0KB	14.0KB	+20.0B
`watcher`	13.6KB	13.6KB	+20.0B
total			+1.1KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/storybook`	18	20	+2

History

💚 Build #8876 succeeded 73f9b72
💔 Build #8829 failed f5ad450
💔 Build #8789 failed 962641cf4b951a9ee024c50cf2d6795f72ef29e4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

clintandrewhall · 2021-11-24T02:09:42Z

@crob611 or @ThomThomson - can you review for Presentation?
@kpollich or @joshdover - can you review for Fleet?

juliaElastic

LGTM on behalf of Fleet

mshustov · 2021-11-24T12:19:17Z

typings/index.d.ts

 declare module 'monaco-editor/esm/vs/basic-languages/yaml/yaml';
+
+// Storybook uses this module and its types are defined in the source but not in the type output
+declare module 'file-system-cache' {


Is it possible to keep these definitions isolated in packages/kbn-storybook/src/typings.ts?

That didn't work, and I don't think I can import here or it will convert from an ambient definition... At this point I'm not sure but those two files are already very similar so maybe it's not a big deal...

ThomThomson

Changes LGTM! Ran storybook locally to smoke check the presentation team storybooks, and everything seems to work correctly after the upgrade - good stuff!

kibanamachine · 2021-11-26T19:54:59Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 119498 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-11-29T20:04:58Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 119498 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-11-30T00:27:26Z

💔 Backport failed

Status	Branch	Result
❌	8.0	Commit could not be cherrypicked due to conflicts
❌	7.16	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 119498

kibanamachine · 2021-12-01T00:24:59Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 119498 or prevent reminders by adding the backport:skip label.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # yarn.lock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap # packages/kbn-storybook/src/lib/theme_switcher.tsx # yarn.lock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # yarn.lock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap # packages/kbn-storybook/src/lib/theme_switcher.tsx # yarn.lock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[storybook] upgrade to 6.3.x

3b1d82a

spalger force-pushed the upgrade/storybook branch from 962641c to 3b1d82a Compare November 23, 2021 16:32

spalger added 5 commits November 23, 2021 09:54

duplicate axe to avoid breaking minor upgrade

02e26cb

use set +e to allow failures to be caught properly

f5ad450

fixup types, the way storybook handles its types is so annoying

d35aa05

update babel helpers now that new runtimes are pinned to the same ver…

fdc357a

…sion

update optimizer snapshot

73f9b72

spalger added Feature:Storybook release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.16.0 v8.0.0 v8.1.0 labels Nov 23, 2021

spalger marked this pull request as ready for review November 23, 2021 21:47

spalger requested review from a team as code owners November 23, 2021 21:47

Merge branch 'main' into upgrade/storybook

801071c

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 23, 2021

jbudz approved these changes Nov 23, 2021

View reviewed changes

juliaElastic approved these changes Nov 24, 2021

View reviewed changes

mshustov reviewed Nov 24, 2021

View reviewed changes

ThomThomson approved these changes Nov 24, 2021

View reviewed changes

spalger enabled auto-merge (squash) November 24, 2021 16:50

spalger requested a review from mshustov November 24, 2021 16:50

mshustov approved these changes Nov 24, 2021

View reviewed changes

spalger merged commit ac23dce into elastic:main Nov 24, 2021

spalger deleted the upgrade/storybook branch November 24, 2021 19:46

spalger mentioned this pull request Nov 24, 2021

[babel] ensure TS preset runs before anything else #119107

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 26, 2021

spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 30, 2021

spalger mentioned this pull request Dec 1, 2021

[8.0] [storybook] upgrade to 6.3.x (#119498) #120047

Merged

spalger pushed a commit to spalger/kibana that referenced this pull request Dec 1, 2021

[storybook] upgrade to 6.3.x (elastic#119498)

1b8c87b

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # yarn.lock

spalger mentioned this pull request Dec 1, 2021

[7.16] [storybook] upgrade to 6.3.x (#119498) #120048

Merged

spalger pushed a commit that referenced this pull request Dec 1, 2021

[storybook] upgrade to 6.3.x (#119498) (#120047)

6808187

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # yarn.lock

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 1, 2021

TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021

[storybook] upgrade to 6.3.x (elastic#119498)

c872f09

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[storybook] upgrade to 6.3.x#119498

[storybook] upgrade to 6.3.x#119498
spalger merged 7 commits intoelastic:mainfrom
spalger:upgrade/storybook

spalger commented Nov 23, 2021

Uh oh!

spalger commented Nov 23, 2021

Uh oh!

kibana-ci commented Nov 23, 2021

API count

Uh oh!

clintandrewhall commented Nov 24, 2021

Uh oh!

juliaElastic left a comment

Uh oh!

mshustov Nov 24, 2021

Uh oh!

spalger Nov 24, 2021

Uh oh!

ThomThomson left a comment

Uh oh!

kibanamachine commented Nov 26, 2021

Uh oh!

kibanamachine commented Nov 29, 2021

Uh oh!

kibanamachine commented Nov 30, 2021

Uh oh!

kibanamachine commented Dec 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

spalger commented Nov 23, 2021

Uh oh!

spalger commented Nov 23, 2021

Uh oh!

kibana-ci commented Nov 23, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

History

Uh oh!

clintandrewhall commented Nov 24, 2021

Uh oh!

juliaElastic left a comment

Choose a reason for hiding this comment

Uh oh!

mshustov Nov 24, 2021

Choose a reason for hiding this comment

Uh oh!

spalger Nov 24, 2021

Choose a reason for hiding this comment

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Nov 26, 2021

Uh oh!

kibanamachine commented Nov 29, 2021

Uh oh!

kibanamachine commented Nov 30, 2021

💔 Backport failed

Uh oh!

kibanamachine commented Dec 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants