[eslint] prevent using constructor property params in initializers#119130
Merged
spalger merged 2 commits intoelastic:mainfrom Nov 19, 2021
Merged
Conversation
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
azasypkin
approved these changes
Nov 19, 2021
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
Security plugin changes LGTM, thanks!
pgayvallet
approved these changes
Nov 19, 2021
jbudz
approved these changes
Nov 19, 2021
tylersmalley
approved these changes
Nov 19, 2021
ThomThomson
approved these changes
Nov 19, 2021
mattkime
approved these changes
Nov 19, 2021
Contributor
mattkime
left a comment
mattkime
left a comment
There was a problem hiding this comment.
app services changes lgtm
spalger
added
the
auto-backport
dmlemeshko
approved these changes
Nov 19, 2021
Contributor
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
Kibana QA changes look good
spalger
deleted the
implement/eslint-no-constructor-args-in-initializers
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2021
Contributor
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 19, 2021
…lastic#119130) # Conflicts: # packages/kbn-cli-dev-mode/src/log.ts # src/plugins/presentation_util/public/components/controls/control_group/embeddable/control_group_container_factory.ts
2 tasks
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to upgrade TS we need to stop referencing properties initialized by constructor arguments. This change is unfortunate but no longer supported by TS and this ESLint rule is designed to prevent us from adding more occurrences of this until we can get the TS upgrade complete.
Also fixes all existing violations manually by moving the initialization into the constructor.