[optimizer] pretty-print jest snapshots to help reviews#119404
Merged
spalger merged 1 commit intoelastic:mainfrom Nov 23, 2021
Merged
[optimizer] pretty-print jest snapshots to help reviews#119404spalger merged 1 commit intoelastic:mainfrom
spalger merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Nov 22, 2021
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 23, 2021
Contributor
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Nov 23, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#119107 ended up triggering an update to the bundle saved in a Jest snapshot. This snapshot isn't massive, but it's too large to spot a little change so I'd like to format the code with prettier before snapshotting it so that we can spot changes more easily.