[eslint] don't drop multiple uses when one is in a function#119252
Merged
spalger merged 5 commits intoelastic:mainfrom Nov 22, 2021
Merged
Conversation
spalger
added
Team:Operations
jbudz
approved these changes
Nov 22, 2021
kertal
reviewed
Nov 22, 2021
Comment on lines
+33
to
+44
| readonly newSearchSessionIdFromURL$: Rx.Observable<string | null>; | ||
|
|
||
| constructor(private readonly deps: DiscoverSearchSessionManagerDeps) {} | ||
| constructor(private readonly deps: DiscoverSearchSessionManagerDeps) { | ||
| this.newSearchSessionIdFromURL$ = createQueryParamObservable<string>( | ||
| this.deps.history, | ||
| SEARCH_SESSION_ID_QUERY_PARAM | ||
| ).pipe( | ||
| filter((searchSessionId) => { | ||
| if (!searchSessionId) return true; | ||
| return !this.deps.session.isCurrentSession(searchSessionId); | ||
| }) | ||
| ); |
Member
There was a problem hiding this comment.
LGTM dear @Dosant think you added this, could you have a 👀 ? many thx
Dosant
approved these changes
Nov 22, 2021
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
src/plugins/discover/public/application/main/services/discover_search_session.ts LGTM
Contributor
Author
|
@elasticmachine merge upstream |
kertal
approved these changes
Nov 22, 2021
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Data discovery team owned code LGTM
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
spalger
deleted the
implement/eslint-no-constructor-args-in-initializers
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2021
Contributor
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.