Skip to content

Make classnames a shared dep#111636

Merged
timroes merged 2 commits intoelastic:masterfrom
timroes:classnames-shared-deps
Sep 10, 2021
Merged

Make classnames a shared dep#111636
timroes merged 2 commits intoelastic:masterfrom
timroes:classnames-shared-deps

Conversation

@timroes
Copy link
Contributor

@timroes timroes commented Sep 8, 2021

Summary

Making classnames a shared deps. Yay or nay?

Checklist

Delete any items that are not applicable to this PR.

@timroes
Copy link
Contributor Author

timroes commented Sep 10, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
advancedSettings 59 58 -1
apm 1626 1625 -1
cases 422 421 -1
charts 73 72 -1
core 368 367 -1
dashboard 269 268 -1
data 574 573 -1
dataVisualizer 326 325 -1
discover 432 431 -1
embeddable 106 105 -1
enterpriseSearch 1467 1466 -1
esUiShared 187 186 -1
expressions 164 163 -1
graph 161 160 -1
indexManagement 515 514 -1
indexPatternEditor 109 108 -1
indexPatternFieldEditor 149 148 -1
infra 965 964 -1
ingestPipelines 498 497 -1
kibanaOverview 31 30 -1
kibanaReact 397 396 -1
lens 834 833 -1
management 36 35 -1
maps 848 847 -1
ml 1834 1833 -1
monitoring 578 577 -1
navigation 25 24 -1
presentationUtil 120 119 -1
searchprofiler 91 90 -1
security 484 483 -1
securitySolution 2402 2401 -1
timelines 329 328 -1
upgradeAssistant 110 109 -1
visTypeMetric 26 25 -1
visTypeTable 76 75 -1
visTypeTimeseries 540 539 -1
visTypeVislib 199 198 -1
visualizations 108 107 -1
total -38

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 912.9KB 912.2KB -783.0B
apm 4.4MB 4.4MB -784.0B
cases 712.3KB 711.7KB -625.0B
data 170.2KB 168.3KB -1.9KB
dataVisualizer 1.2MB 1.2MB -644.0B
discover 524.6KB 525.0KB +351.0B
enterpriseSearch 2.1MB 2.1MB +190.0B
esUiShared 558.7KB 557.8KB -878.0B
graph 644.5KB 644.0KB -554.0B
indexManagement 1.3MB 1.3MB -508.0B
indexPatternEditor 175.6KB 174.8KB -784.0B
indexPatternFieldEditor 264.6KB 263.9KB -761.0B
infra 1.7MB 1.7MB -785.0B
ingestPipelines 707.9KB 707.3KB -646.0B
kibanaOverview 19.1KB 18.4KB -787.0B
kibanaReact 318.7KB 318.8KB +94.0B
lens 1.6MB 1.6MB -344.0B
management 17.0KB 16.3KB -766.0B
maps 3.2MB 3.2MB -692.0B
ml 6.0MB 6.0MB -787.0B
monitoring 769.1KB 768.3KB -784.0B
presentationUtil 69.8KB 68.2KB -1.5KB
searchprofiler 644.7KB 643.9KB -784.0B
security 764.9KB 764.1KB -764.0B
securitySolution 6.5MB 6.5MB -550.0B
timelines 420.0KB 419.3KB -788.0B
upgradeAssistant 182.0KB 181.3KB -787.0B
visTypeMetric 16.3KB 15.6KB -766.0B
visTypeTable 104.0KB 103.2KB -787.0B
visTypeTimeseries 1004.7KB 1002.5KB -2.3KB
visTypeVislib 548.3KB 547.6KB -788.0B
total -22.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 9.6KB 9.7KB +70.0B
apm 46.1KB 46.2KB +70.0B
cases 133.4KB 133.5KB +70.0B
charts 91.9KB 91.3KB -691.0B
core 408.4KB 407.8KB -645.0B
dashboard 328.0KB 327.4KB -597.0B
data 777.8KB 777.9KB +29.0B
dataVisualizer 16.2KB 16.3KB +70.0B
discover 76.6KB 75.9KB -714.0B
embeddable 184.7KB 184.2KB -551.0B
enterpriseSearch 14.5KB 14.5KB +70.0B
esUiShared 195.7KB 195.8KB +70.0B
expressions 220.0KB 219.3KB -714.0B
graph 11.2KB 11.3KB +70.0B
indexManagement 37.1KB 37.2KB +70.0B
indexPatternEditor 21.7KB 21.8KB +70.0B
indexPatternFieldEditor 37.5KB 37.6KB +70.0B
infra 150.2KB 150.3KB +70.0B
ingestPipelines 22.3KB 22.3KB +70.0B
kbnUiSharedDeps-js 6.5MB 6.5MB +52.0B
kibanaOverview 29.6KB 29.6KB +70.0B
kibanaReact 156.0KB 155.8KB -177.0B
lens 58.6KB 58.7KB +70.0B
management 15.8KB 15.9KB +70.0B
maps 78.1KB 78.1KB +70.0B
ml 65.1KB 65.2KB +70.0B
monitoring 48.4KB 48.5KB +70.0B
navigation 18.0KB 17.3KB -714.0B
presentationUtil 69.7KB 69.8KB +70.0B
searchprofiler 40.4KB 40.5KB +70.0B
security 84.2KB 84.3KB +70.0B
securitySolution 207.8KB 207.9KB +70.0B
timelines 311.8KB 311.9KB +70.0B
upgradeAssistant 29.2KB 29.3KB +70.0B
visTypeMetric 22.2KB 22.3KB +70.0B
visTypeTable 8.5KB 8.5KB +70.0B
visTypeTimeseries 26.0KB 26.0KB +70.0B
visTypeVislib 31.9KB 32.0KB +70.0B
visualizations 59.0KB 58.3KB -714.0B
total -3.4KB
Unknown metric groups

async chunk count

id before after diff
data 11 10 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.16.0 v8.0.0 labels Sep 10, 2021
@timroes timroes marked this pull request as ready for review September 10, 2021 09:35
@timroes timroes requested a review from a team as a code owner September 10, 2021 09:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@timroes timroes added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 10, 2021
@timroes timroes merged commit 7da17a5 into elastic:master Sep 10, 2021
@timroes timroes deleted the classnames-shared-deps branch September 10, 2021 15:44
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 10, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 13, 2021
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (120 commits)
  [TSVB] Support custom field format (elastic#101245)
  [VisEditors] Add code ownership to the functional tests (elastic#111680)
  [Lens] Make Lens saved object share-capable (elastic#111403)
  [Graph] Make Graph saved object share-capable (elastic#111404)
  [Stack Monitoring] Add breadcrumb support (elastic#111850)
  Update Jira Cloud to use OAuth2.0 (elastic#111493)
  Show warning message when attempting to create an APM alert in stack management (elastic#111781)
  Skip suite blocking ES snapshot promotion (elastic#111907)
  Respect `auth_provider_hint` if session is not authenticated. (elastic#111521)
  Added in 'Responses' field in alert telemetry & updated test (elastic#111892)
  [Usage collection] refactor cloud detector collector (elastic#110439)
  Make classnames a shared dep (elastic#111636)
  Fix link to e2e tests in APM testing.md (elastic#111869)
  [Security Solution] Add host.os.name.caseless mapping and runtime field (elastic#111455)
  [APM] Removes the beta label from APM tutorial (elastic#111499) (elastic#111828)
  [RAC] [Observability] Expand Observability alerts page functional tests (elastic#111297)
  Fix extra white space on the alert table whe page size is 50 or 100 (elastic#111568)
  [Metrics UI] Add Inventory Timeline open/close state to context and URL state (elastic#111034)
  [Graph] Switch to SavedObjectClient.resolve  (elastic#109617)
  [APM] Adding lambda icon (elastic#111834)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 14, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 15, 2021
kibanamachine added a commit that referenced this pull request Sep 15, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tim Roes <tim.roes@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants