[Stack Monitoring] Add breadcrumb support#111850
Conversation
phillipb
added
v8.0.0
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
matschaffer
left a comment
matschaffer
left a comment
There was a problem hiding this comment.
I got a little turned around in the globalStateStr check but otherwise this looks good.
Actually better than the angular version which I noticed doesn't update breadcrumbs when you end up on the ES overview page (at least for the 1 cluster case, didn't test others).
I say let's merge it :)
| bcrumbs = currentBreadcrumbs.value; | ||
| } | ||
| } | ||
| const globalStateStr = location.hash.split('?')[1]; |
There was a problem hiding this comment.
The direct location hash parsing was a little surprising to see. I was expected we'd already have some sort of kibana level breadcrumb manager that look care of this sort of thing, but maybe not?
Seems like we should probably have a test on this, if not now then before we call the react conversion "done".
|
@elasticmachine merge upstream |
|
ignoring request to update branch, pull request is closed |
|
Oh neat. Automerge kicks in even if the branch is outdated. Nice. |
…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (120 commits) [TSVB] Support custom field format (elastic#101245) [VisEditors] Add code ownership to the functional tests (elastic#111680) [Lens] Make Lens saved object share-capable (elastic#111403) [Graph] Make Graph saved object share-capable (elastic#111404) [Stack Monitoring] Add breadcrumb support (elastic#111850) Update Jira Cloud to use OAuth2.0 (elastic#111493) Show warning message when attempting to create an APM alert in stack management (elastic#111781) Skip suite blocking ES snapshot promotion (elastic#111907) Respect `auth_provider_hint` if session is not authenticated. (elastic#111521) Added in 'Responses' field in alert telemetry & updated test (elastic#111892) [Usage collection] refactor cloud detector collector (elastic#110439) Make classnames a shared dep (elastic#111636) Fix link to e2e tests in APM testing.md (elastic#111869) [Security Solution] Add host.os.name.caseless mapping and runtime field (elastic#111455) [APM] Removes the beta label from APM tutorial (elastic#111499) (elastic#111828) [RAC] [Observability] Expand Observability alerts page functional tests (elastic#111297) Fix extra white space on the alert table whe page size is 50 or 100 (elastic#111568) [Metrics UI] Add Inventory Timeline open/close state to context and URL state (elastic#111034) [Graph] Switch to SavedObjectClient.resolve (elastic#109617) [APM] Adding lambda icon (elastic#111834) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
4 participants
Summary
Add breadcrumbs to the react app.