Skip to content

[7.x] Make classnames a shared dep (#111636)#111878

Merged
kibanamachine merged 2 commits intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-111636
Sep 15, 2021
Merged

[7.x] Make classnames a shared dep (#111636)#111878
kibanamachine merged 2 commits intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-111636

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Sep 10, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) September 10, 2021 15:47
@timroes
Copy link
Copy Markdown
Contributor

timroes commented Sep 15, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
advancedSettings 59 58 -1
apm 1626 1625 -1
cases 422 421 -1
charts 73 72 -1
core 368 367 -1
dashboard 269 268 -1
data 577 576 -1
dataVisualizer 326 325 -1
discover 433 432 -1
embeddable 84 83 -1
enterpriseSearch 1467 1466 -1
esUiShared 187 186 -1
expressions 164 163 -1
graph 161 160 -1
indexManagement 516 515 -1
indexPatternEditor 109 108 -1
indexPatternFieldEditor 149 148 -1
infra 965 964 -1
ingestPipelines 498 497 -1
kibanaOverview 31 30 -1
kibanaReact 397 396 -1
lens 834 833 -1
management 36 35 -1
maps 830 829 -1
ml 1834 1833 -1
monitoring 579 578 -1
navigation 25 24 -1
presentationUtil 120 119 -1
searchprofiler 91 90 -1
security 484 483 -1
securitySolution 2403 2402 -1
timelines 329 328 -1
upgradeAssistant 147 146 -1
visTypeMetric 26 25 -1
visTypeTable 40 39 -1
visTypeTimeseries 545 544 -1
visTypeVislib 199 198 -1
visualizations 108 107 -1
total -38

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 912.9KB 912.1KB -783.0B
apm 4.4MB 4.4MB -784.0B
cases 712.3KB 711.7KB -625.0B
data 170.2KB 168.3KB -1.9KB
dataVisualizer 1.2MB 1.2MB -644.0B
discover 593.5KB 592.2KB -1.3KB
enterpriseSearch 2.1MB 2.1MB +190.0B
esUiShared 558.7KB 557.8KB -878.0B
graph 646.0KB 645.5KB -554.0B
indexManagement 1.3MB 1.3MB -508.0B
indexPatternEditor 175.6KB 174.8KB -784.0B
indexPatternFieldEditor 264.6KB 263.9KB -761.0B
infra 1.7MB 1.7MB -785.0B
ingestPipelines 707.9KB 707.3KB -646.0B
kibanaOverview 19.1KB 18.4KB -787.0B
kibanaReact 318.7KB 318.8KB +94.0B
lens 1.6MB 1.6MB -344.0B
management 17.0KB 16.3KB -766.0B
maps 3.2MB 3.2MB -692.0B
ml 6.0MB 6.0MB -780.0B
monitoring 771.4KB 770.6KB -784.0B
presentationUtil 69.8KB 68.2KB -1.5KB
searchprofiler 644.7KB 643.9KB -784.0B
security 765.0KB 764.2KB -764.0B
securitySolution 6.5MB 6.5MB -550.0B
timelines 420.3KB 419.5KB -788.0B
upgradeAssistant 211.4KB 210.6KB -784.0B
visTypeMetric 16.3KB 15.6KB -766.0B
visTypeTable 28.9KB 28.1KB -766.0B
visTypeTimeseries 1021.5KB 1018.6KB -3.0KB
visTypeVislib 548.4KB 547.7KB -788.0B
total -24.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 9.6KB 9.7KB +70.0B
apm 46.1KB 46.2KB +70.0B
cases 133.4KB 133.5KB +70.0B
charts 91.9KB 91.3KB -691.0B
core 409.1KB 408.5KB -645.0B
dashboard 328.1KB 327.5KB -597.0B
data 783.2KB 783.2KB +29.0B
dataVisualizer 16.2KB 16.3KB +70.0B
discover 34.7KB 34.8KB +70.0B
embeddable 163.8KB 163.3KB -551.0B
enterpriseSearch 14.5KB 14.6KB +70.0B
esUiShared 195.7KB 195.8KB +70.0B
expressions 220.0KB 219.3KB -714.0B
graph 11.2KB 11.3KB +70.0B
indexManagement 37.1KB 37.2KB +70.0B
indexPatternEditor 21.7KB 21.8KB +70.0B
indexPatternFieldEditor 37.5KB 37.6KB +70.0B
infra 150.2KB 150.3KB +70.0B
ingestPipelines 22.3KB 22.3KB +70.0B
kbnUiSharedDeps-js 6.5MB 6.5MB +52.0B
kibanaOverview 29.6KB 29.6KB +70.0B
kibanaReact 156.0KB 155.8KB -177.0B
lens 58.6KB 58.7KB +70.0B
management 15.8KB 15.9KB +70.0B
maps 67.9KB 68.0KB +70.0B
ml 64.9KB 65.0KB +70.0B
monitoring 48.4KB 48.5KB +70.0B
navigation 18.0KB 17.3KB -714.0B
presentationUtil 69.7KB 69.8KB +70.0B
searchprofiler 40.4KB 40.5KB +70.0B
security 84.2KB 84.3KB +70.0B
securitySolution 208.6KB 208.6KB +70.0B
timelines 311.8KB 311.9KB +70.0B
upgradeAssistant 27.5KB 27.5KB +70.0B
visTypeMetric 22.2KB 22.3KB +70.0B
visTypeTable 24.2KB 24.2KB +70.0B
visTypeTimeseries 26.4KB 26.4KB +70.0B
visTypeVislib 32.0KB 32.0KB +70.0B
visualizations 59.0KB 58.3KB -714.0B
total -2.6KB
Unknown metric groups

async chunk count

id before after diff
data 11 10 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @timroes

@kibanamachine kibanamachine merged commit 64d99bb into elastic:7.x Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants