Skip to content

[RAC] [Observability] Expand Observability alerts page functional tests#111297

Merged
Kerry350 merged 8 commits intoelastic:masterfrom
Kerry350:110630-filter-bar-and-date-picker-tests
Sep 10, 2021
Merged

[RAC] [Observability] Expand Observability alerts page functional tests#111297
Kerry350 merged 8 commits intoelastic:masterfrom
Kerry350:110630-filter-bar-and-date-picker-tests

Conversation

@Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Sep 6, 2021 •
edited
Loading

Summary

Implements #110630 and #110634, regenerates the archive data, and unskips flakey tests.

Testing

Run: node scripts/functional_tests_server --config x-pack/test/observability_functional/with_rac_write.config.ts

Run: node scripts/functional_test_runner --config x-pack/test/observability_functional/with_rac_write.config.ts --grep='Observability alerts'

@Kerry350 Kerry350 added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 Feature:Observability RAC labels Sep 6, 2021
@Kerry350 Kerry350 requested a review from a team September 6, 2021 15:26
@Kerry350 Kerry350 self-assigned this Sep 6, 2021
@Kerry350 Kerry350 marked this pull request as ready for review September 7, 2021 16:49
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 7, 2021

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort self-requested a review September 7, 2021 17:06
weltenwort
weltenwort reviewed Sep 7, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests should prevent quite a few accidental breakages, thank you! 👏

I left just a few questions below.

@Kerry350 Kerry350 removed the v7.15.0 label Sep 9, 2021
@Kerry350
Amendments
5b19179 
- Use flyout service
- Use lower case "O" for observability
- Better function naming
@Kerry350
Merge remote-tracking branch 'upstream/master' into 110630-filter-bar…
0245c0d 
…-and-date-picker-tests
@Kerry350 Kerry350 requested a review from a team as a code owner September 9, 2021 14:11
@Kerry350
Copy link
Contributor Author

Kerry350 commented Sep 9, 2021

@weltenwort Thanks for the review ♥️ This should be ready for another look now.

@Kerry350 Kerry350 requested a review from weltenwort September 9, 2021 14:14
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 9, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 555.5KB 555.8KB +294.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 311.8KB 311.8KB +35.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kerry350

weltenwort
weltenwort approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

miltonhultgren
miltonhultgren reviewed Sep 10, 2021
View reviewed changes
x-pack/test/observability_functional/apps/observability/alerts/index.ts
rangeFrom: '2021-08-31T13:36:22.109Z',
rangeTo: '2021-09-01T13:36:22.109Z',
};
async function asyncForEach<T>(array: T[], callback: (item: T, index: number) => void) {
Copy link
Contributor

@miltonhultgren miltonhultgren Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it important that these happen in sequence (versus in parallel with Promise.all)?

Further, this is a big repo but I imagine this has been needed before. How common is it to extract common helpers like this on repo or "team" level?

Copy link
Contributor

@miltonhultgren miltonhultgren Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#111637

Copy link
Contributor

@spalger spalger Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally avoid extracting this type of stuff into repo level helpers. In the case that you want synchronous iteration I think that using a simple for...of loop makes the most sense.

for (const x of items) {
  await fn(x)
}

machadoum
machadoum approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security solution code LGTM.

@Kerry350 Kerry350 merged commit 7f6df4a into elastic:master Sep 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 10, 2021
@Kerry350 @kibanamachine
[RAC] [Observability] Expand Observability alerts page functional tes…
a0c24f2 
…ts (elastic#111297)

* Regenerate data and add tests
@kibanamachine kibanamachine mentioned this pull request Sep 10, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 10, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 13, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/add…
1249734 
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (120 commits)
  [TSVB] Support custom field format (elastic#101245)
  [VisEditors] Add code ownership to the functional tests (elastic#111680)
  [Lens] Make Lens saved object share-capable (elastic#111403)
  [Graph] Make Graph saved object share-capable (elastic#111404)
  [Stack Monitoring] Add breadcrumb support (elastic#111850)
  Update Jira Cloud to use OAuth2.0 (elastic#111493)
  Show warning message when attempting to create an APM alert in stack management (elastic#111781)
  Skip suite blocking ES snapshot promotion (elastic#111907)
  Respect `auth_provider_hint` if session is not authenticated. (elastic#111521)
  Added in 'Responses' field in alert telemetry & updated test (elastic#111892)
  [Usage collection] refactor cloud detector collector (elastic#110439)
  Make classnames a shared dep (elastic#111636)
  Fix link to e2e tests in APM testing.md (elastic#111869)
  [Security Solution] Add host.os.name.caseless mapping and runtime field (elastic#111455)
  [APM] Removes the beta label from APM tutorial (elastic#111499) (elastic#111828)
  [RAC] [Observability] Expand Observability alerts page functional tests (elastic#111297)
  Fix extra white space on the alert table whe page size is 50 or 100 (elastic#111568)
  [Metrics UI] Add Inventory Timeline open/close state to context and URL state (elastic#111034)
  [Graph] Switch to SavedObjectClient.resolve  (elastic#109617)
  [APM] Adding lambda icon (elastic#111834)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
kibanamachine added a commit that referenced this pull request Sep 13, 2021
@kibanamachine @Kerry350
[RAC] [Observability] Expand Observability alerts page functional tes…
3ee2b29 
…ts (#111297) (#111867)

* Regenerate data and add tests

Co-authored-by: Kerry Gallagher <471693+Kerry350@users.noreply.github.com>
@Kerry350 Kerry350 mentioned this pull request Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miltonhultgren miltonhultgren miltonhultgren left review comments

@weltenwort weltenwort weltenwort approved these changes

@machadoum machadoum machadoum approved these changes

+1 more reviewer

@spalger spalger spalger left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Kerry350 Kerry350

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Observability RAC release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Kerry350 @elasticmachine @kibanamachine @weltenwort @spalger @machadoum @miltonhultgren