Skip to content

[VisEditors] Add code ownership to the functional tests#111680

Merged
stratoula merged 7 commits intoelastic:masterfrom
stratoula:viseditors-tests-codeowners
Sep 13, 2021
Merged

[VisEditors] Add code ownership to the functional tests#111680
stratoula merged 7 commits intoelastic:masterfrom
stratoula:viseditors-tests-codeowners

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Sep 9, 2021

Summary

This PR just adds the kibana-vis-editors team as codeowners to the functional tests we own. After syncing with @ThomThomson we decided to move the input control vis and the markdown tests in another folder dashboard_elements and leave to the visualize folder all the other visualizations that we owm.

@stratoula stratoula changed the title [VisEditors] Add code owenership to the functional tests [VisEditors] Add code ownership to the functional tests Sep 9, 2021
@stratoula
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review September 10, 2021 06:00
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 labels Sep 10, 2021
@stratoula stratoula added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Sep 10, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@stratoula stratoula requested a review from dej611 September 10, 2021 08:45
Copy link
Copy Markdown
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@stratoula
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit d60fab1 into elastic:master Sep 13, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Sep 13, 2021
* [VisEditors] Add code owenership to the functional tests

* Remove the unnecessary imports

* Revert

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 13, 2021
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (120 commits)
  [TSVB] Support custom field format (elastic#101245)
  [VisEditors] Add code ownership to the functional tests (elastic#111680)
  [Lens] Make Lens saved object share-capable (elastic#111403)
  [Graph] Make Graph saved object share-capable (elastic#111404)
  [Stack Monitoring] Add breadcrumb support (elastic#111850)
  Update Jira Cloud to use OAuth2.0 (elastic#111493)
  Show warning message when attempting to create an APM alert in stack management (elastic#111781)
  Skip suite blocking ES snapshot promotion (elastic#111907)
  Respect `auth_provider_hint` if session is not authenticated. (elastic#111521)
  Added in 'Responses' field in alert telemetry & updated test (elastic#111892)
  [Usage collection] refactor cloud detector collector (elastic#110439)
  Make classnames a shared dep (elastic#111636)
  Fix link to e2e tests in APM testing.md (elastic#111869)
  [Security Solution] Add host.os.name.caseless mapping and runtime field (elastic#111455)
  [APM] Removes the beta label from APM tutorial (elastic#111499) (elastic#111828)
  [RAC] [Observability] Expand Observability alerts page functional tests (elastic#111297)
  Fix extra white space on the alert table whe page size is 50 or 100 (elastic#111568)
  [Metrics UI] Add Inventory Timeline open/close state to context and URL state (elastic#111034)
  [Graph] Switch to SavedObjectClient.resolve  (elastic#109617)
  [APM] Adding lambda icon (elastic#111834)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
stratoula added a commit that referenced this pull request Sep 13, 2021
…11927)

* [VisEditors] Add code owenership to the functional tests

* Remove the unnecessary imports

* Revert

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants