Upgrade EUI to v37.3.1 by cee-chen · Pull Request #109926 · elastic/kibana

cee-chen · 2021-08-24T19:31:48Z

Summary

eui@37.3.0 ⏩ eui@37.3.1

`37.3.1`

Bug fixes

Fixed bug in EuiDataGrid where a custom className was also being passed to the full screen button (#5050)
Fixed rerender state issues in PaginationButton inside EuiPagination (#5048)
Fixed bug in euiHeaderAffordForFixed mixin that was not accounting for situations where EuiDataGrid was in full screen mode (#5054)
Fixed z-index styles that were causing EuiModal and EuiFlyout components to appear behind EuiDataGrid when in full screen mode (#5054)
Fixed untranslated i18n strings for EuiFilterButton - adds 2 new tokens and removes old euiFilterButton.filterBadge token (#4750)
Fixed missing i18n token EuiFilePicker's default prompt, and improved i18n string for euiFilePicker.filesSelected (#5063)
Fixed EuiDataGrid sort button text pluralization (#5043)
Fixed styles of EuiButtonIcon when passing disabled prop (#5060)
Fixed EuiDataGrid not clearing cell styles when column position changes (#5068)

Theme: Amsterdam

Updated styles for EuiDatePicker (#5000)
Fixed styles for EuiSuperDatePicker (#5060)

src/core/public/i18n/i18n_eui_mapping.tsx

cee-chen · 2021-08-25T00:53:31Z

x-pack/plugins/lens/public/datatable_visualization/components/cell_value.tsx

cc @dej611 on this change: elastic/eui#4665 (comment)

I tested locally and I'm fairly sure this is still working with the hook cleanup gone:

Feel free to double check/confirm yourself of course! 🙏

The fix does work ok in that specific case, but it broke the table when removing the conditional coloring:

Keeping this code here the behaviour works as expected.

Super strange! Will definitely revert this for this release - hopefully we can get it figured out later. Thank you for QAing @dej611!

elasticmachine · 2021-08-25T18:31:07Z

Pinging @elastic/eui-design (EUI)

cee-chen · 2021-08-25T18:31:43Z

CI is now passing, so I went ahead and undrafted to start getting eyes/reviews from the various team CODEOWNERS affected by this upgrade. It's primarily Jest snapshot updates, with 1 slight test change for the Security team (d3ce53e), a cleanup for the Lens team (e40ebfa), and some i18n changes I'm talking through in a thread above.

…skipping

dominiqueclarke

uptime changes LGTM

sebelga

Stack management changes LGTM 👍

afharo

LGTM! Thank you for all these changes! 🧡

cee-chen · 2021-08-30T15:04:08Z

@elasticmachine merge upstream

vadimkibana

Test snapshot diffs LGTM, haven't tested locally.

poffdeluxe

Presentation team changes lgtm

dej611

The removed code in Lens is still required to make it work correctly the table conditional coloring as the EuiDataGrid is not cleaning it up correctly in all cases.

smith

APM changes look good

This reverts commit e40ebfa.

cee-chen · 2021-08-31T19:04:40Z

@elasticmachine merge upstream

kibanamachine · 2021-08-31T21:30:03Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.5MB	6.5MB	+494.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	417.5KB	419.0KB	+1.5KB
`kbnUiSharedDeps-css`	534.9KB	535.0KB	+164.0B
`kbnUiSharedDeps-elastic`	2.6MB	2.6MB	+40.6KB
`kbnUiSharedDeps-js`	6.5MB	6.5MB	+231.0B
total			+42.5KB

History

💔 Build #149835 failed 5861c94
💚 Build #149490 succeeded cd54a85
💚 Build #148701 succeeded a0853fe
💚 Build #148625 succeeded e40ebfa
💔 Build #148407 failed 670b00d6bbb05a844932290d3e2081bcfdf8b4f5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dej611

Tested on Safari 👍

cee-chen · 2021-09-01T15:39:14Z

Thanks everyone - super appreciate your reviews on this!

* Upgrade EUI to v37.3.1 * Update i18n token mappings * Skip i18n_eui_mapping defString checks for functions * Update snapshots * Update failing Security tests with extra nodes * Remove hook cleanup now that elastic/eui#5068 is merged * [i18n PR feedback] Prefer specific token skipping over all functions skipping * Revert "Remove hook cleanup now that elastic/eui#5068 is merged" This reverts commit e40ebfa. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-09-01T15:42:01Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Upgrade EUI to v37.3.1 * Update i18n token mappings * Skip i18n_eui_mapping defString checks for functions * Update snapshots * Update failing Security tests with extra nodes * Remove hook cleanup now that elastic/eui#5068 is merged * [i18n PR feedback] Prefer specific token skipping over all functions skipping * Revert "Remove hook cleanup now that elastic/eui#5068 is merged" This reverts commit e40ebfa. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com>

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Aug 24, 2021

cee-chen commented Aug 24, 2021

View reviewed changes

src/core/public/i18n/i18n_eui_mapping.tsx Outdated Show resolved Hide resolved

cee-chen commented Aug 25, 2021

View reviewed changes

cee-chen added 6 commits August 25, 2021 08:53

Upgrade EUI to v37.3.1

9530329

Update i18n token mappings

bbbe0c7

Skip i18n_eui_mapping defString checks for functions

922f536

Update snapshots

f7c240a

Update failing Security tests with extra nodes

d3ce53e

Remove hook cleanup now that elastic/eui#5068 is merged

e40ebfa

cee-chen force-pushed the eui-37.3.1 branch from 670b00d to e40ebfa Compare August 25, 2021 15:59

cee-chen marked this pull request as ready for review August 25, 2021 18:31

cee-chen requested review from a team August 25, 2021 18:31

cee-chen requested review from a team as code owners August 25, 2021 18:31

cee-chen requested a review from ashokaditya August 25, 2021 18:31

cee-chen requested a review from paul-tavares August 25, 2021 18:31

[i18n PR feedback] Prefer specific token skipping over all functions …

a0853fe

…skipping

dominiqueclarke approved these changes Aug 25, 2021

View reviewed changes

cee-chen mentioned this pull request Aug 25, 2021

[EUI i18n token mapping] Long-term approach for complex defStrings #110132

Closed

sebelga approved these changes Aug 26, 2021

View reviewed changes

afharo approved these changes Aug 26, 2021

View reviewed changes

ashokaditya approved these changes Aug 26, 2021

View reviewed changes

Merge branch 'master' into eui-37.3.1

cd54a85

vadimkibana approved these changes Aug 30, 2021

View reviewed changes

poffdeluxe approved these changes Aug 30, 2021

View reviewed changes

dej611 requested changes Aug 31, 2021

View reviewed changes

smith approved these changes Aug 31, 2021

View reviewed changes

cee-chen added 2 commits August 31, 2021 08:30

Merge branch 'master' into eui-37.3.1

f0b3360

Revert "Remove hook cleanup now that elastic/eui#5068 is merged"

5861c94

This reverts commit e40ebfa.

cee-chen requested a review from a team as a code owner August 31, 2021 15:31

cee-chen requested a review from dej611 August 31, 2021 15:33

Merge branch 'master' into eui-37.3.1

39db744

dej611 approved these changes Sep 1, 2021

View reviewed changes

cee-chen merged commit 47b86e1 into elastic:master Sep 1, 2021

cee-chen deleted the eui-37.3.1 branch September 1, 2021 15:39

kibanamachine mentioned this pull request Sep 1, 2021

[7.x] Upgrade EUI to v37.3.1 (#109926) #110833

Merged

kqualters-elastic mentioned this pull request Sep 2, 2021

[RAC][Security Solution] Make analyzer work with EuiDataGrid full screen #110913

Merged

1 task

cee-chen mentioned this pull request Sep 9, 2021

[i18n] core.euiFilterButton.filterBadge is setting hardcoded values elastic/eui#4786

Closed

ruchika-narang mentioned this pull request May 5, 2022

The Pagination links for 'Table View' not working. opensearch-project/observability#696

Closed

Comments

Conversation

cee-chen commented Aug 24, 2021

Summary

37.3.1

Uh oh!

Uh oh!

cee-chen Aug 25, 2021

Choose a reason for hiding this comment

Uh oh!

dej611 Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

dej611 Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

cee-chen Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 25, 2021

Uh oh!

cee-chen commented Aug 25, 2021

Uh oh!

dominiqueclarke left a comment

Choose a reason for hiding this comment

Uh oh!

sebelga left a comment

Choose a reason for hiding this comment

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Aug 30, 2021

Uh oh!

vadimkibana left a comment

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

dej611 left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Aug 31, 2021

Uh oh!

kibanamachine commented Aug 31, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

dej611 left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Sep 1, 2021

Uh oh!

kibanamachine commented Sep 1, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

`37.3.1`

cee-chen Aug 31, 2021 •

edited

Loading