[EuiSuperDatePicker] & [EuiButtonIcon] A couple quick fixes#5060
[EuiSuperDatePicker] & [EuiButtonIcon] A couple quick fixes#5060cchaos merged 9 commits intoelastic:masterfrom
Conversation
Which in turn fixes EuiPagination left/right arrows, and EuiListGroupItem extra action
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
snide
left a comment
There was a problem hiding this comment.
Checked code. Tested in browser and checked mobile render. Tests look good.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
|
Looks like a prettier error in |
|
Might have been from a previous PR where I added that. For some reason Prettier has just completely stopped working on that page in my IDE. I wonder if there's some exclusion that's including this file because it contains the work |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; Tested in deployed docs & locally
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
EuiSuperDatePicker
While I had been checking the EuiSuperDatePicker's use of EuiDatePicker during #5000, I must have missed a final pass and saw that the width wasn't growing. So this is now fixed.
Before

After

Also fixed the responsive sizes:
Before

After

EuiButtonIcon
While I was testing #5054 in Kibana, I noticed that the filter in/out buttons were sometimes "disabled" but were still
bluewith pointer events.I realized that EuiButtonIcon only afforded for
isDisabledeven thoughdisabledwas also a valid prop because ofPropsForButton. And whiledisabledwas still being applied to the rendered DOM element, the styling was not updated to get--isDisabledclass.Before:
**After: **
So now it checks for
disabledas well to apply the class which apparently also fixes some internal usages of justdisabledon EuiButtonIcon within EuiPagination and EuiListGroupItem.Checklist
[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes