Skip to content

Comments

[EuiSuperDatePicker] & [EuiButtonIcon] A couple quick fixes#5060

Merged
cchaos merged 9 commits intoelastic:masterfrom
cchaos:fix/super_date_picker_ams
Aug 23, 2021
Merged

[EuiSuperDatePicker] & [EuiButtonIcon] A couple quick fixes#5060
cchaos merged 9 commits intoelastic:masterfrom
cchaos:fix/super_date_picker_ams

Conversation

@cchaos
Copy link
Contributor

@cchaos cchaos commented Aug 20, 2021

EuiSuperDatePicker

While I had been checking the EuiSuperDatePicker's use of EuiDatePicker during #5000, I must have missed a final pass and saw that the width wasn't growing. So this is now fixed.

Before
Screen Shot 2021-08-20 at 11 18 22 AM

After
Screen Shot 2021-08-20 at 11 19 45 AM

Also fixed the responsive sizes:

Before
Screen Shot 2021-08-20 at 11 47 03 AM

After
Screen Shot 2021-08-20 at 11 49 56 AM

EuiButtonIcon

While I was testing #5054 in Kibana, I noticed that the filter in/out buttons were sometimes "disabled" but were still blue with pointer events.

Screen Shot 2021-08-20 at 11 05 21 AM

I realized that EuiButtonIcon only afforded for isDisabled even though disabled was also a valid prop because of PropsForButton. And while disabled was still being applied to the rendered DOM element, the styling was not updated to get --isDisabled class.

Before:

Screen Shot 2021-08-20 at 11 43 37 AM

**After: **

So now it checks for disabled as well to apply the class which apparently also fixes some internal usages of just disabled on EuiButtonIcon within EuiPagination and EuiListGroupItem.

Screen Shot 2021-08-20 at 11 44 56 AM

Screen Shot 2021-08-20 at 11 35 22 AM

Screen Shot 2021-08-20 at 11 45 27 AM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@cchaos cchaos changed the title A couple quick fixes [EuiSuperDatePicker] & [EuiButtonIcon] A couple quick fixes Aug 20, 2021
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked code. Tested in browser and checked mobile render. Tests look good.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/

@snide
Copy link
Contributor

snide commented Aug 20, 2021

Looks like a prettier error in icon_example.js even though this doesn't touch it.

@cchaos
Copy link
Contributor Author

cchaos commented Aug 20, 2021

Might have been from a previous PR where I added that. For some reason Prettier has just completely stopped working on that page in my IDE. I wonder if there's some exclusion that's including this file because it contains the work icon?

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/

@chandlerprall chandlerprall self-requested a review August 23, 2021 21:16
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; Tested in deployed docs & locally

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/

@cchaos cchaos merged commit d2d3a3c into elastic:master Aug 23, 2021
@cchaos cchaos deleted the fix/super_date_picker_ams branch August 23, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants