[EuiDatePicker] Update styles for Amsterdam#5000
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5000/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5000/ |
| <span> | ||
| <span className={classes}> |
There was a problem hiding this comment.
Here I just removed the extra plain wrapping <span> that I could not figure out why was here.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5000/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5000/ |
There was a problem hiding this comment.
The changes are looking great! 😍
I just found a few design issues. Going to list them by number so it is easier to track them.
1 - When focusing the time there are multiple black outlines. It only happens in Chrome and Edge. I was expecting to have a black outline to all the popover and then when pressing "arrow up" or "arrow down" just to have one focus state on the currently focused item.
2 - The months and years dropdowns grow in width when hovering the time items. It only happens in Safari.
Screen.Recording.2021-08-16.at.07.06.PM.mov
3 - The black focus outlines have some inconsistencies. Is it possible to both date and time popovers to have similar outlines? The outline on "months" looks better to me.
|
I have no idea what's goin on with those focus rings on the time selection. It should def not highlight all those items. 👀 @miukimiu , good spot on those other two issues and yes, unfortunately, they are known and a symptom of the library.
|
|
😅 Ok I pushed a fix to the time focus states. I had to dig deeper and find that because of moving where the overflow scroll was happening changed the browser's interpretation of |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5000/ |
elizabetdev
left a comment
There was a problem hiding this comment.
😅 Ok I pushed a fix to the time focus states
Thanks for making those changes. I tested again and LGTM! 🎉




This PR only affects the Amsterdam theme by separating out the date-picker imports completely and kinda hacky. But I wanted to start clean and not try to "override" the default theme because it's soo many selectors.
The updated version:

The main differences are:
Checklist
[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately