[RAC][Security Solution] Make analyzer work with EuiDataGrid full screen#110913
Conversation
kqualters-elastic
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
| document.body.classList.remove(SCROLLING_DISABLED_CLASS_NAME, 'euiDataGrid__restrictBody'); | ||
| resetScroll(); | ||
| } | ||
|
|
There was a problem hiding this comment.
are we able to dispatch setFullScreen for global full screen as well? I could find some style issue due to incorrect global full screen status? Although it seems that the toggle fullscreen button for events table is coming from data grid?
There was a problem hiding this comment.
ya this is an unrelated z-index issue that was/will be fixed by upgrading eui, #109926 via elastic/eui#5054 I think
There was a problem hiding this comment.
https://github.com/elastic/kibana/pull/110913/files/7a964244aea4b4c1c899fc1e405b06aa4db6b941#diff-9dafa871a9206508107bdcf810febcdd5e7689609dc09fcca94ade9210ce49aeR55 inputActions.setFullScreen is being dispatched in both callbacks as well
There was a problem hiding this comment.
Update: turns out it was not fixed, but fixed in this commit 0c1da5a
|
Fixed full screen z-index |
XavierM
left a comment
XavierM
left a comment
There was a problem hiding this comment.
That's a nice fix and it is all legal code in this PR. I appreciate all your effort to get the best way to fix this problem.
Thanks a lot
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
…een (elastic#110913) * Make analyzer work with EuiDataGrid full screen * Don't ever restrict the width, remove console.log * Remove isEventViewer prop no longer used * Make global filters appear below data grid
…een (elastic#110913) * Make analyzer work with EuiDataGrid full screen * Don't ever restrict the width, remove console.log * Remove isEventViewer prop no longer used * Make global filters appear below data grid
…een (#110913) (#111017) * Make analyzer work with EuiDataGrid full screen * Don't ever restrict the width, remove console.log * Remove isEventViewer prop no longer used * Make global filters appear below data grid Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
…een (#110913) (#111018) * Make analyzer work with EuiDataGrid full screen * Don't ever restrict the width, remove console.log * Remove isEventViewer prop no longer used * Make global filters appear below data grid Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (65 commits) Move to vis_types folder part 2 (elastic#110574) [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023) [Discover] Remove export* syntax (elastic#110934) [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365) [Security Solution][Detection Rules] Changes 'activated' text on rule details page (elastic#111044) [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300) [package testing] Update logging and pid configuration (elastic#111059) [Dashboard] Read App State from URL on Soft Refresh (elastic#109354) Add correct roles to test user for functional tests in dashboard (elastic#110880) [DOCS] Adds Lens Inspector and minor edits (elastic#109736) [DOCS] Updates Spaces page (elastic#111005) normalize initialNamespaces (elastic#110936) [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740) [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253) skip flaky suites: elastic#111001, elastic#111022 [Security Solution][RAC] - Update reason field text (elastic#110308) [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913) [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971) [DOCS] Updates Discover docs (elastic#110346) [RAC] Persistent timeline fields fix (elastic#110685) ...
5 participants
Summary
This pr makes the analyzer full screen mode compatible with EuiDataGrid full screen. This is done by adding/removing the same class to the body that the data grid does when going full screen, along with some css changes to stretch the graph overlay when in a table.
Checklist