[EuiFilePicker] Fix missing i18n for prompt text, improve filesSelected i18n#5063
Merged
cee-chen merged 4 commits intoelastic:masterfrom Aug 23, 2021
Merged
[EuiFilePicker] Fix missing i18n for prompt text, improve filesSelected i18n#5063cee-chen merged 4 commits intoelastic:masterfrom
cee-chen merged 4 commits intoelastic:masterfrom
Conversation
- which means we no longer need to pass a string param to onChange, and also means the wrapping EuiI18n does not need multiple tokens
cee-chen
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5063/ |
2 tasks
thompsongl
approved these changes
Aug 23, 2021
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up 🙏
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5063/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4698 - specifically addressing Michail's comment here.
Copy should be the same as before, no English regressions should have occurred as a result of this PR:
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes