Skip to content

[EuiDatGrid] Replace expandMini with expand icon in data grid #8646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryankeairns merged 3 commits into from
Apr 28, 2025
Merged

[EuiDatGrid] Replace expandMini with expand icon in data grid #8646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fde8110
Use new expand icon in data grid
ryankeairns Apr 25, 2025
c4fc238
add changelog
ryankeairns Apr 25, 2025
8143708
Merge branch 'main' into rk/mini-data-grid-improvement
ryankeairns Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eui/changelogs/upcoming/8646.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Update `EuiDataGrid` to use `expand` glyph
6 changes: 0 additions & 6 deletions packages/eui/src/components/datagrid/body/cell/data_grid_cell_actions.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,6 @@ export const euiDataGridCellActionsStyles = (euiThemeContext: UseEuiTheme) => {
}
/* stylelint-enable declaration-no-important */

/* Manually increase the size of the expand cell icon - it's a bit small by default */
&.euiDataGridRowCell__expandCell .euiIcon {
${logicalCSS('width', '120%')}
${logicalCSS('height', '100%')}
}

/* Remove button borders in high contrast mode */
${highContrastModeStyles(euiThemeContext, {
preferred: 'border: none;',
Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src/components/datagrid/body/cell/data_grid_cell_actions.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('EuiDataGridCellActions', () => {
aria-hidden="true"
class="euiButtonIcon__icon"
color="inherit"
data-euiicon-type="expandMini"
data-euiicon-type="expand"
/>
</button>
`);
Expand Down
4 changes: 2 additions & 2 deletions packages/eui/src/components/datagrid/body/cell/data_grid_cell_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ export const EuiDataGridCellActions = ({
data-test-subj="euiDataGridCellExpandButton"
display="fill"
color="primary"
iconSize="m"
iconType="expandMini"
iconSize="s"
iconType="expand"
aria-hidden
onClick={onExpandClick}
title={expandButtonTitle}
Expand Down
9 changes: 6 additions & 3 deletions packages/website/docs/components/tabular-content/data-grid/cells-and-popovers.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,8 @@ export default () => {
<EuiFlexGroup alignItems="center" gutterSize="xs" responsive={false}>
<EuiFlexItem grow={false}>
<EuiToken
iconType="expandMini"
iconSize="s"
iconType="expand"
color="euiColorVis0"
shape="square"
fill="dark"
Expand Down Expand Up @@ -822,7 +823,8 @@ export default () => {
<EuiFlexGroup alignItems="center" gutterSize="xs" responsive={false}>
<EuiFlexItem grow={false}>
<EuiToken
iconType="expandMini"
iconSize="s"
iconType="expand"
color="euiColorVis0"
shape="square"
fill="dark"
Expand Down Expand Up @@ -862,7 +864,8 @@ export default () => {
<EuiFlexGroup alignItems="center" gutterSize="xs" responsive={false}>
<EuiFlexItem grow={false}>
<EuiToken
iconType="expandMini"
iconSize="s"
iconType="expand"
color="euiColorVis0"
shape="square"
fill="dark"
Expand Down