ES|QL: Fix LIMIT after all columns are dropped#143463
ES|QL: Fix LIMIT after all columns are dropped#143463luigidellaquila merged 4 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
Team:Analytics
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
| - match: { values.1.1: null } | ||
|
|
||
| --- | ||
| "Limit truncation with zero columns #142473": |
There was a problem hiding this comment.
This bug was caused by a csv test right? Do we want a csv test apart from the yaml one? Or when do we use one vs the other?
There was a problem hiding this comment.
About YAML, we (or I) usually use them when we want to test not just query and output, but also the request/response. And I think sometimes we add extra special checks for YAML, and they're also validated against the API spec.
And my guess is that, because the output has no columns, CSV tests wouldn't support it. But Luigi will confirm
There was a problem hiding this comment.
In this case, I used yaml because I wanted a query that returns no columns (and I can't validate the output with CSV).
The failure happened on the CSV dataset, but it was on Generative tests
There was a problem hiding this comment.
Or when do we use one vs the other?
I use yaml tests when:
- I need a very specific dataset or a data combination I don't have in CSV, and that is not general enough to deserve an addition to that.
- I need more fine-grained validation (as Ivan said above)
- The test just can't be written in csv-spec (eg. a query that returns no columns)
In all the other cases, I try to use csv-spec just because it's easier to write, and because we run it in different configurations.
…locations * upstream/main: (51 commits) ESQL: Remaining serialization tests (elastic#143470) Eagerly release resources in `TransportAwaitClusterStateVersionAppliedAction` (elastic#143477) Stop and relocate sliced reindex on shutdown (elastic#143183) Documentation for query_vector base64 parameter (elastic#142675) ES|QL: Fix LIMIT after all columns are dropped (elastic#143463) Update docs-build.yml (elastic#142958) Fix KnnIndexTester to work with byte vectors (elastic#143493) Fix IndexInputUtils.withSlice to produce native-safe MemorySegments on Java 21 (elastic#143479) CPS fix: include only relevant projects in the search response metadata (elastic#143367) apm-data: explicit map of timestamp.us to long (elastic#143173) [Inference API] Add custom headers for Azure OpenAI Service (elastic#142969) ESQL: Add name IDs to golden tests and fix synthetic names (elastic#143450) Add getUnavailableShards to BaseBroadcastResponse (elastic#143406) Add description to reindex API without sensitive info (elastic#143112) SQL: fix CLI tests (elastic#143451) ES|QL: Add note of future removal of FORK implicit LIMIT (elastic#143457) [Test] Randomly disable doc values skippers in time-series indices (elastic#143389) Improve pattern text downgrade license test (elastic#143102) [Transform] Stop transforms at the end of tests (elastic#139783) Mute org.elasticsearch.compute.lucene.read.ValueSourceReaderTypeConversionTests testLoadAll elastic#143471 ...
5 participants
Fixes: #142473
Fix LIMIT when all the columns are dropped, by explicitly setting the page size.