Skip to content

CPS fix: include only relevant projects in the search response metadata#143367

Merged
pawankartik-elastic merged 5 commits intoelastic:mainfrom
pawankartik-elastic:pkar/cps-mrt-true-metadata
Mar 3, 2026
Merged

CPS fix: include only relevant projects in the search response metadata#143367
pawankartik-elastic merged 5 commits intoelastic:mainfrom
pawankartik-elastic:pkar/cps-mrt-true-metadata

Conversation

@pawankartik-elastic
Copy link
Copy Markdown
Contributor

For MRT=true, a linked-only index will still go through a local search on the origin/coordinator node, but because it does not exist, it will yield no results. However, it still shows up in the search response's metadata for no reason. This PR fixes it by looking at ResolvedIndexExpressions to see if there's at least 1 index that exists which is being targeted in the search op.

Note that MRT=false is not plagued with this issue, because TransportSearchAction#reconcileProjects() already performs a similar check.

@pawankartik-elastic pawankartik-elastic added >bug Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/CCS labels Mar 2, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @pawankartik-elastic, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Mar 2, 2026
@quux00 quux00 self-requested a review March 2, 2026 17:50
@pawankartik-elastic pawankartik-elastic marked this pull request as ready for review March 3, 2026 14:10
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Copy Markdown
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawankartik-elastic pawankartik-elastic merged commit 7b1a099 into elastic:main Mar 3, 2026
36 checks passed
@pawankartik-elastic pawankartik-elastic deleted the pkar/cps-mrt-true-metadata branch March 3, 2026 16:53
GalLalouche pushed a commit to GalLalouche/elasticsearch that referenced this pull request Mar 3, 2026
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 3, 2026
…locations

* upstream/main: (51 commits)
  ESQL: Remaining serialization tests (elastic#143470)
  Eagerly release resources in `TransportAwaitClusterStateVersionAppliedAction` (elastic#143477)
  Stop and relocate sliced reindex on shutdown (elastic#143183)
  Documentation for query_vector base64 parameter (elastic#142675)
  ES|QL: Fix LIMIT after all columns are dropped (elastic#143463)
  Update docs-build.yml (elastic#142958)
  Fix KnnIndexTester to work with byte vectors (elastic#143493)
  Fix IndexInputUtils.withSlice to produce native-safe MemorySegments on Java 21 (elastic#143479)
  CPS fix: include only relevant projects in the search response metadata (elastic#143367)
  apm-data: explicit map of timestamp.us to long (elastic#143173)
  [Inference API] Add custom headers for Azure OpenAI Service (elastic#142969)
  ESQL: Add name IDs to golden tests and fix synthetic names (elastic#143450)
  Add getUnavailableShards to BaseBroadcastResponse (elastic#143406)
  Add description to reindex API without sensitive info (elastic#143112)
  SQL: fix CLI tests (elastic#143451)
  ES|QL: Add note of future removal of FORK implicit LIMIT (elastic#143457)
  [Test] Randomly disable doc values skippers in time-series indices (elastic#143389)
  Improve pattern text downgrade license test (elastic#143102)
  [Transform] Stop transforms at the end of tests (elastic#139783)
  Mute org.elasticsearch.compute.lucene.read.ValueSourceReaderTypeConversionTests testLoadAll elastic#143471
  ...
shmuelhanoch pushed a commit to shmuelhanoch/elasticsearch that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search Foundations/CCS serverless-linked Added by automation, don't add manually Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants