Skip to content

SQL: fix CLI tests#143451

Merged
luigidellaquila merged 2 commits intoelastic:mainfrom
luigidellaquila:sql/fix_cli_tests
Mar 3, 2026
Merged

SQL: fix CLI tests#143451
luigidellaquila merged 2 commits intoelastic:mainfrom
luigidellaquila:sql/fix_cli_tests

Conversation

@luigidellaquila
Copy link
Copy Markdown
Contributor

Not consuming an empty line apparently leads to a race condition or to some buffering problems, that sometimes result in an incomplete exit message (the CLI close consumes the output too quickly).

Fixes: #143125

@luigidellaquila luigidellaquila requested a review from bpintea March 3, 2026 10:41
@luigidellaquila luigidellaquila added >bug >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying labels Mar 3, 2026
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.4.0 labels Mar 3, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Copy Markdown
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@luigidellaquila luigidellaquila enabled auto-merge (squash) March 3, 2026 11:15
@luigidellaquila luigidellaquila disabled auto-merge March 3, 2026 11:20
@luigidellaquila luigidellaquila merged commit 93f5669 into elastic:main Mar 3, 2026
36 checks passed
GalLalouche pushed a commit to GalLalouche/elasticsearch that referenced this pull request Mar 3, 2026
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 3, 2026
…locations

* upstream/main: (51 commits)
  ESQL: Remaining serialization tests (elastic#143470)
  Eagerly release resources in `TransportAwaitClusterStateVersionAppliedAction` (elastic#143477)
  Stop and relocate sliced reindex on shutdown (elastic#143183)
  Documentation for query_vector base64 parameter (elastic#142675)
  ES|QL: Fix LIMIT after all columns are dropped (elastic#143463)
  Update docs-build.yml (elastic#142958)
  Fix KnnIndexTester to work with byte vectors (elastic#143493)
  Fix IndexInputUtils.withSlice to produce native-safe MemorySegments on Java 21 (elastic#143479)
  CPS fix: include only relevant projects in the search response metadata (elastic#143367)
  apm-data: explicit map of timestamp.us to long (elastic#143173)
  [Inference API] Add custom headers for Azure OpenAI Service (elastic#142969)
  ESQL: Add name IDs to golden tests and fix synthetic names (elastic#143450)
  Add getUnavailableShards to BaseBroadcastResponse (elastic#143406)
  Add description to reindex API without sensitive info (elastic#143112)
  SQL: fix CLI tests (elastic#143451)
  ES|QL: Add note of future removal of FORK implicit LIMIT (elastic#143457)
  [Test] Randomly disable doc values skippers in time-series indices (elastic#143389)
  Improve pattern text downgrade license test (elastic#143102)
  [Transform] Stop transforms at the end of tests (elastic#139783)
  Mute org.elasticsearch.compute.lucene.read.ValueSourceReaderTypeConversionTests testLoadAll elastic#143471
  ...
shmuelhanoch pushed a commit to shmuelhanoch/elasticsearch that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/SQL SQL querying >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] CliApiKeyIT testCliConnectionWithApiKey failing

3 participants