ES|QL: Add note of future removal of FORK implicit LIMIT#143457
ES|QL: Add note of future removal of FORK implicit LIMIT#143457ioanatia merged 3 commits intoelastic:mainfrom
Conversation
ioanatia
added
>docs
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
| @@ -21,6 +21,10 @@ | |||
|
|
|||
| ::::{note} | |||
There was a problem hiding this comment.
@ioanatia I'd suggest changing this note to an applies-switch which is basically versioned tabs (in this case one tab for 9.1-9.3 and another for 9.4+/serverless)
Then we can keep the old information in the 9.1-9.3 tab and the new info in the 9.4+ tab.
example:
::::{applies-switch}
:::{applies-item} { serverless: , stack: ga 9.4+ }
<New content>
:::
:::{applies-item} stack: preview 9.1-9.3
<Old content>
:::
::::
| serverless: preview | ||
| stack: preview 9.1.0 |
There was a problem hiding this comment.
| serverless: ga | |
| stack: preview 9.1-9.3, ga 9.4+ |
- If ready to flip to GA on serverless, we should make this update too
- We should also update the applies_to tags in the list here: https://github.com/elastic/elasticsearch/blob/main/docs/reference/query-languages/esql/_snippets/lists/processing-commands.md
There was a problem hiding this comment.
we are not ready yet 🙈
leemthompo
left a comment
leemthompo
left a comment
There was a problem hiding this comment.
LGTM as this is early info note :)
…locations * upstream/main: (51 commits) ESQL: Remaining serialization tests (elastic#143470) Eagerly release resources in `TransportAwaitClusterStateVersionAppliedAction` (elastic#143477) Stop and relocate sliced reindex on shutdown (elastic#143183) Documentation for query_vector base64 parameter (elastic#142675) ES|QL: Fix LIMIT after all columns are dropped (elastic#143463) Update docs-build.yml (elastic#142958) Fix KnnIndexTester to work with byte vectors (elastic#143493) Fix IndexInputUtils.withSlice to produce native-safe MemorySegments on Java 21 (elastic#143479) CPS fix: include only relevant projects in the search response metadata (elastic#143367) apm-data: explicit map of timestamp.us to long (elastic#143173) [Inference API] Add custom headers for Azure OpenAI Service (elastic#142969) ESQL: Add name IDs to golden tests and fix synthetic names (elastic#143450) Add getUnavailableShards to BaseBroadcastResponse (elastic#143406) Add description to reindex API without sensitive info (elastic#143112) SQL: fix CLI tests (elastic#143451) ES|QL: Add note of future removal of FORK implicit LIMIT (elastic#143457) [Test] Randomly disable doc values skippers in time-series indices (elastic#143389) Improve pattern text downgrade license test (elastic#143102) [Transform] Stop transforms at the end of tests (elastic#139783) Mute org.elasticsearch.compute.lucene.read.ValueSourceReaderTypeConversionTests testLoadAll elastic#143471 ...
3 participants
As part of making FORK GA, in the following weeks we want to remove the implicit LIMIT we add to each FORK branch.
This adds a note in the documentation that this change is coming, with a recommendation to add a LIMIT to each FORK branch, in case users want to maintain the current behaviour of the queries after upgrading.