Skip to content

[Test] Randomly disable doc values skippers in time-series indices#143389

Merged
tlrx merged 5 commits intoelastic:mainfrom
tlrx:2026/03/02-es-14224-disable-docs-values-skippers
Mar 3, 2026
Merged

[Test] Randomly disable doc values skippers in time-series indices#143389
tlrx merged 5 commits intoelastic:mainfrom
tlrx:2026/03/02-es-14224-disable-docs-values-skippers

Conversation

@tlrx
Copy link
Copy Markdown
Member

@tlrx tlrx commented Mar 2, 2026

This change disables index.mapping.use_doc_values_skipper in about 10% of tests executions of the main TSDB with synthetic id tests, as well as in some unit tests. It also makes the necessary changes in the postings format to account for missing doc values skippers.

Relates ES-14224
Relates #143151 (comment)

This change disables `index.mapping.use_doc_values_skipper` in about
10% of tests executions of the main TSDB with synthetic id tests, as
well as in some unit tests.

Relates ES-14224
Relates elastic#143151 (comment)
@tlrx tlrx added >non-issue >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics labels Mar 2, 2026
// Use doc values skipper on timestamp to early exit or skip to the first document matching the timestamp
int nextDocID;
var skipper = docValues.docValuesSkipperForTimestamp();
if (timestamp > skipper.maxValue()) {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code has moved under the skipper != null check, otherwise it's unchanged

@tlrx tlrx marked this pull request as ready for review March 3, 2026 07:56
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@tlrx tlrx requested review from burqen, fcofdez and martijnvg and removed request for fcofdez March 3, 2026 08:28
Copy link
Copy Markdown
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx tlrx merged commit daa6161 into elastic:main Mar 3, 2026
35 checks passed
@tlrx tlrx deleted the 2026/03/02-es-14224-disable-docs-values-skippers branch March 3, 2026 15:11
@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Mar 3, 2026

Thanks Francisco!

GalLalouche pushed a commit to GalLalouche/elasticsearch that referenced this pull request Mar 3, 2026
…lastic#143389)

This change disables index.mapping.use_doc_values_skipper in about 10% 
of tests executions of the main TSDB with synthetic id tests, as well as in 
some unit tests. It also makes the necessary changes in the postings format 
to account for missing doc values skippers.

Relates ES-14224
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 3, 2026
…locations

* upstream/main: (51 commits)
  ESQL: Remaining serialization tests (elastic#143470)
  Eagerly release resources in `TransportAwaitClusterStateVersionAppliedAction` (elastic#143477)
  Stop and relocate sliced reindex on shutdown (elastic#143183)
  Documentation for query_vector base64 parameter (elastic#142675)
  ES|QL: Fix LIMIT after all columns are dropped (elastic#143463)
  Update docs-build.yml (elastic#142958)
  Fix KnnIndexTester to work with byte vectors (elastic#143493)
  Fix IndexInputUtils.withSlice to produce native-safe MemorySegments on Java 21 (elastic#143479)
  CPS fix: include only relevant projects in the search response metadata (elastic#143367)
  apm-data: explicit map of timestamp.us to long (elastic#143173)
  [Inference API] Add custom headers for Azure OpenAI Service (elastic#142969)
  ESQL: Add name IDs to golden tests and fix synthetic names (elastic#143450)
  Add getUnavailableShards to BaseBroadcastResponse (elastic#143406)
  Add description to reindex API without sensitive info (elastic#143112)
  SQL: fix CLI tests (elastic#143451)
  ES|QL: Add note of future removal of FORK implicit LIMIT (elastic#143457)
  [Test] Randomly disable doc values skippers in time-series indices (elastic#143389)
  Improve pattern text downgrade license test (elastic#143102)
  [Transform] Stop transforms at the end of tests (elastic#139783)
  Mute org.elasticsearch.compute.lucene.read.ValueSourceReaderTypeConversionTests testLoadAll elastic#143471
  ...
shmuelhanoch pushed a commit to shmuelhanoch/elasticsearch that referenced this pull request Mar 4, 2026
…lastic#143389)

This change disables index.mapping.use_doc_values_skipper in about 10% 
of tests executions of the main TSDB with synthetic id tests, as well as in 
some unit tests. It also makes the necessary changes in the postings format 
to account for missing doc values skippers.

Relates ES-14224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants