Skip to content

Conversation

@dibarbet
Copy link
Member

@dibarbet dibarbet commented Jan 7, 2025

No description provided.

CyrusNajmabadi and others added 30 commits December 19, 2024 13:30
This is an automatically generated pull request from release/dev17.13
into main.


Once all conflicts are resolved and all the tests pass, you are free to
merge the pull request. 🐯

## Troubleshooting conflicts

### Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its
path into the following searches:
- https://github.com/dotnet/roslyn/find/release/dev17.13
- https://github.com/dotnet/roslyn/find/main

Usually the most recent change to a file between the two branches is
considered to have introduced the conflicts, but sometimes it will be
necessary to look for the conflicting lines and check the blame in each
branch. Generally the author whose change introduced the conflicts
should pull down this PR, fix the conflicts locally, then push up a
commit resolving the conflicts.

### Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally
will work without conflicts. This is due to differences between the
merge algorithm used in local git versus the one used by GitHub.
``` bash
git fetch --all
git checkout -t upstream/merges/release/dev17.13-to-main
git reset --hard upstream/main
git merge upstream/release/dev17.13
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.13-to-main --force
```
* Update PublishData.json for telmet branch
CyrusNajmabadi and others added 10 commits January 6, 2025 09:37
For a full source build there should be no need for $(NetPrevious) to be included. Having it there creates complications in the build as we end up depending on projects that are not built during source build.
…76617)

Resolves microsoft/vscode-dotnettools#1686

When vscode is installed in (or an extension assembly is loaded from) a
path that contains a URI reserved character, the server crashes. This is
because VS-MEF (for compatibility with clr behavior) sets the code base
to a file URI with an unencoded path.

When parsing the URI, some reserved characters cause the path component
to be incorrectly split into query or fragment components if unescaped.
Then we get an invalid file path from the URI and cannot load the
extension dll.
@dibarbet dibarbet requested review from a team as code owners January 7, 2025 00:04
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 7, 2025
@dibarbet dibarbet changed the base branch from main to release/dev17.13 January 7, 2025 00:04
@dibarbet dibarbet requested review from a team as code owners January 7, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.