Add an option to control if unused members shoudl be faded out. #76520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
JoeRobich
approved these changes
Dec 19, 2024
sharwell
reviewed
Dec 19, 2024
Contributor
sharwell
left a comment
sharwell
left a comment
There was a problem hiding this comment.
I'm a bit surprised we went with this option instead of just reusing the option we already have, but either way gets the job done. A couple issues found.
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CodeStyle/FadingOptions.cs
Outdated
Show resolved
Hide resolved
| options:=Nothing, | ||
| "IDE0051", | ||
| DiagnosticSeverity.Info, | ||
| DiagnosticSeverity.Hidden, |
Contributor
There was a problem hiding this comment.
📝 The default severity for this should probably not change
…Style/FadingOptions.cs Co-authored-by: Sam Harwell <[email protected]>
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76396
Looks like: