Skip to content

Conversation

@RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Jan 6, 2025

Follow up to #76312
Closes #76641

#76641 (comment)

It was not our goal to make generator authors service the .NET 8 versions of their generators to start using InterceptableLocation. The goal was just to get people moved to the new way for .NET 9 and up. Our plan is to leave in support for the "old way" in the SDK, for as long as .NET 8 is supported. At the time .NET 8 goes out of support, we will fully remove the support for the "old way" from the newest SDK.

I think the resolution here should be to adjust the compiler so that warning InterceptsLocationAttribute(string, int, int) is not supported is only reported when targeting .NET 9 or later.

@RikkiGibson RikkiGibson requested a review from a team as a code owner January 6, 2025 20:03
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 6, 2025
@RikkiGibson
Copy link
Member Author

@cston @dotnet/roslyn-compiler for review of a small fix

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Interceptors untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CS9270 'InterceptsLocationAttribute(string, int, int)' is not supported when using Microsoft.Extensions.Configuration.Binder 8.0.x

5 participants