Make full source build pure NetCurrent #76640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
Member
Author
|
@dotnet/roslyn-infrastructure PTAL |
ViktorHofer
approved these changes
Jan 6, 2025
dibarbet
approved these changes
Jan 6, 2025
|
|
||
| - Build Tools: requires us to ship compilers on `net472` | ||
| - .NET SDK: requires us to ship compilers on current servicing target framework (presently `net8.0`) | ||
| - Source build: requires us to ship `$(NetCurrent)` and `$(NetPrevious)` in workspaces and below (presently `net9.0` and `net8.0` respectively) |
Member
Author
There was a problem hiding this comment.
Split this out into both repo and full source build discussion
333fred
approved these changes
Jan 6, 2025
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a full source build there should be no need for
$(NetPrevious)to be included. Having it there creates complications in the build as we end up depending on projects that are not built during source build.