Propagate marked attributes from primary constructor parameters to backing fields. #76475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking fields. Related to dotnet#73920.
ghost
added
the
untriaged
Contributor
Author
|
@dotnet/roslyn-compiler Please review |
AlekseyTs
changed the base branch from
main
to
features/GeneratedCodeAttributes
Contributor
Author
|
@dotnet/roslyn-compiler Please review |
cston
reviewed
Dec 18, 2024
|
|
||
| string source2 = @" | ||
| public record " + keyword + @" Test1( | ||
| [Preserve1] |
Contributor
Contributor
Author
There was a problem hiding this comment.
#73920 explicitly asks to not copy the attribute for records:
Cases where attributes should not flow:
- Primary constructor parameters of record types: the compiler allows adding [property: ...] annotations to primary constructor parameters of record types ...
Contributor
Author
There was a problem hiding this comment.
A user is able to explicitly apply attributes to backing fields in records
cston
approved these changes
Dec 18, 2024
Contributor
Author
|
@dotnet/roslyn-compiler For the second review |
Contributor
Author
|
@dotnet/roslyn-compiler For the second review |
333fred
approved these changes
Dec 19, 2024
AlekseyTs
merged commit cf5eed2
into
dotnet:features/GeneratedCodeAttributes
28 checks passed
checkedsums
pushed a commit
to checkedsums/roslynjourneys
that referenced
this pull request
Jan 5, 2025
…cking fields. (dotnet#76475) Related to dotnet#73920.
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #73920.