Skip to content

fix(skills): regenerate the 20 SKILL.md files drifted since #14381 - #15945

Open
BenjaminAronsson wants to merge 7 commits into
diegosouzapw:release/v3.8.52from
BenjaminAronsson:fix/release-v3.8.52-skills-sync
Open

BenjaminAronsson wants to merge 7 commits into
diegosouzapw:release/v3.8.52from
BenjaminAronsson:fix/release-v3.8.52-skills-sync

Conversation

@BenjaminAronsson

@BenjaminAronsson BenjaminAronsson commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Regenerates the 20 drifted SKILL.md files so check:agent-skills-sync passes on release/v3.8.52. Pure generator output — no hand edits, no instruction text changed.
  • This gate blocks every PR into the branch, not just one: .mergify.yml names Merge integrity (changelog + generated skills) as the always-on anchor that must be an affirmative check-success, and the only failure the config tolerates is Build (advisory).
  • Root cause: fix(cli): secure configuration previews and atomic writes #14381 (4df9ceae03) extracted the curl examples out of generator.ts into apiOperationExample.ts, replacing the hardcoded https://localhost:20128 with resolveOmniRouteBaseUrl() (default http://localhost:20128). The committed files were never regenerated, so every generated example has disagreed with the generator since that commit. The whole diff is that scheme change plus the endpoint-reference content that moved with it.

Related Issues

Validation

  • Change type: other — generated documentation artifacts (skills/**), no runtime code
  • Focused tests and category gates from the golden path — check:agent-skills-sync (the gate at issue) plus check:changelog-integrity, the other half of the Merge-integrity job
  • npm run lint — exit 0
  • Reconciled with the current active release base — worktree cut fresh from the release/v3.8.52 tip (61e07fb7e0); gates rerun afterward
  • Production-code changes include a new or updated automated test in this PR — n/a, no production code changed (see below)
check result
check:agent-skills-sync Generated: 0 · Unchanged: 46 · Errors: 0 — exit 0 (was 20 drifted)
check:changelog-integrity exit 0
check:docs-all exit 0
npm run lint exit 0
working tree after pre-commit hooks clean — lint-staged/prettier does not re-format generated output, so the two gates do not fight

Tests Added Or Updated

  • None. No production code changed — this PR contains only regenerated markdown under skills/ plus one changelog.d/ fragment. The generator itself is unchanged and its existing suites (agentSkills-generator, cli-api-generator-ref-params, cli-configuration-consumer-contract) still pass untouched.
  • The behaviour this PR restores is itself gated by check:agent-skills-sync in CI, which is the regression guard for drift.

Coverage Notes

  • No changes under src/, open-sse/, electron/ or bin/, so the coverage gate is unaffected and no file's coverage moves.

Reviewer Notes

  • Agent-instruction surface — worth one explicit look. This touches skills/**/SKILL.md, which AGENTS.md flags as executed-as-authority and requiring explicit operator approval before merge. Stated plainly: the diff adds no instruction text. It is https: → http: inside curl examples plus regenerated endpoint references. gh pr diff 15945 --name-only and a scheme-only spot check are enough to confirm.
  • The latent re-arm is fixed separately in fix(skills): stop ambient env leaking into generated SKILL.md output #15948. apiOperationExample.ts / cliConfigurationExample.ts resolve the base URL from process.env (OMNIROUTE_BASE_URL, BASE_URL, NEXT_PUBLIC_BASE_URL, PORT, …), so anyone running --apply with one of those set re-bakes their own host into the committed artifact and re-opens this exact drift. fix(skills): stop ambient env leaking into generated SKILL.md output #15948 makes generation deterministic and is verified byte-identical to this PR's output, so the two can land in either order without conflicting. Landing this one first is what clears the branch fastest.
  • Overlap with fix(release): drain two v3.8.52 base-reds — cycles membership test, drifted skills mirrors #15682. That PR also targets this base-red but is CONFLICTING, last updated 2026-10-06, and regenerates only skills/omni-auth/SKILL.md — 1 of the 20. This supersedes its skills half; its other half (the cycles membership test) is untouched here and still needs landing. Its author (woodsonl) deserves the credit for spotting the drift first — closing vs rebasing that PR is your call, not something I touched.
  • No migrations, no feature flags, no manual validation required.

…apw#14381

`check:agent-skills-sync` has been failing on the release/v3.8.52 tip,
reporting 20 drifted skills. It blocks every PR into the branch: the
`Merge integrity (changelog + generated skills)` job is named in
.mergify.yml as the always-on anchor that must be an affirmative success.

Root cause: diegosouzapw#14381 (4df9cea) extracted the curl examples out of
generator.ts into apiOperationExample.ts and swapped the hardcoded
`https://localhost:20128` for `resolveOmniRouteBaseUrl()`, whose default is
`http://localhost:20128`. The committed SKILL.md files were never
regenerated, so every generated example has disagreed with the generator
since that commit.

This is the mechanical output of `node --import tsx/esm
scripts/skills/generate-agent-skills.mjs --apply` with no base-url env vars
set, i.e. the documented default — the same environment CI runs in. No
hand edits, no instruction text touched. The gate goes 20 drifted -> 0.
…data docs

Preserve the original generated-skills contribution and merge release base 7510677. Regenerate the owner-approved PUT /api/provider-models reference from canonical inputs.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
@diegosouzapw

Copy link
Copy Markdown
Owner

Campaign coordination: the owner has now explicitly authorized regeneration of product artifacts under root skills/; installed operational agent skills remain excluded. I am revalidating the generated-output repair on VPS 192.168.0.15 against execution base d8e163a in a separate owned worktree. I will not overwrite this branch, the relay reconciliation worktree, or open a duplicate repair PR. Any current-base output delta and exact-SHA receipts will be posted here for adoption by the existing owner. Full CI/admission is separate from focused generator evidence.

@diegosouzapw

Copy link
Copy Markdown
Owner

Hi @BenjaminAronsson — closing this pull request to clear the open queue. The branch fix/release-v3.8.52-skills-sync is kept, so the commits stay. Comment here if it should be reopened.

Retain contributor history and current release changes. Additional new-base generated instruction changes remain preview-only until separately approved.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
@diegosouzapw

Copy link
Copy Markdown
Owner

Owner has explicitly requested reopening and merging the campaign PRs. This PR was already reopened by another session when I checked. I am preserving the active relay-15945-reconcile-20261010 worktree and will not push or merge over its owner. Current-base regeneration is prepared at 6718424 on fix/release-generated-skills-current-20261010; VPS evidence: 0 stale / 46 synchronized, 33 generator/consumer tests + 4 manifests PASS, docs and changelog gates PASS. Original head b9b525d still needs fresh exact-candidate validation; clean mergeability alone did not reproduce current output. Please coordinate adoption through this original PR to preserve Benjamin’s contribution credit. No administrative bypass or duplicate PR is authorized.

Merge release base 7a0bb87 without losing contributor work or release changes. Focused generator and consumer tests pass 33/33 with matching-lock dependencies. Two additional instruction hunks remain preview-only pending explicit approval.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
@diegosouzapw

Copy link
Copy Markdown
Owner

Reopened at the repository owner's explicit request, preserving this original contribution and branch. Thank you @BenjaminAronsson.

The normal fast-forward maintainer update publishes b96a19f6f8494c1b87a7dc3fb78758ec4f94abf0 against release base 7a0bb8754d7432c9fc6b899464d88adbb63d0bd0; tree ff52c8c1e8c314bc4ef7f27c68c899a0b45bcc76. Benjamin remains author, with the maintainer as co-author. The owner-approved PUT /api/provider-models generated instruction/reference is included.

Current matching-lock focused tests: 33 PASS, zero failures/skips/cancellations; docs-all, changelog, formatting, whitespace and normal hooks exit 0. The dependency cache comes from a completed clean npm ci, physically hard-linked with an identical lockfile, not a second clean install per worktree.

Admission remains HOLD: current-base serve --headless and version-channel description produce two additional protected generated instruction hunks. They were shown to the owner and remain preview-only pending specific approval; the dry-run is not falsely marked green. Fresh CI/Quality for this published head is pending/queued. No merge/admin override, force push, baseline increase or deploy occurred. Please coordinate further generated output on this original PR rather than duplicating the contribution.

@diegosouzapw

Copy link
Copy Markdown
Owner

Fresh VPS interaction validation found an additional current-head blocker: combining #15945 b96a19f and #15948 b9b3c20 with base 7a0bb87 (plus the four isolated campaign repairs) produces candidate f91a521. The official npm run check:agent-skills-sync still exits 2: Generated 2 / Unchanged 44 / Errors 0, specifically omni-db-backups and cli-serve. omni-providers is now synchronized. Evidence retained on .15 at /tmp/video-reopen-skills-default-20261010.log. The earlier generated-only candidate 6718424 contains the corresponding current-source output. Please regenerate these two remaining outputs in the original PR; I will not write over the active relay worktree. This is focused current-candidate evidence, not a CI/admission certificate.

Regenerate the two explicitly approved instruction hunks with the canonical generator. Neutral full dry-run reports 0 pending, 46 unchanged and 0 errors; focused generator and consumer tests pass 33/33.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
@diegosouzapw

Copy link
Copy Markdown
Owner

Owner explicitly approved both remaining protected generated hunks (cli-serve --headless and the omni-db-backups version-channel description). Applied through the canonical generator and published as contributor-authored commit 654cf60cd9f92576f763b86f8cae1f40d6634454, preserving Benjamin's authorship and maintainer co-author credit.

Scoped validation on the prepared head: neutral full generator dry-run 0 pending / 46 unchanged / 0 errors; focused generator/reference/configuration tests 33/33 PASS; changelog integrity, whitespace and normal commit hooks PASS. Exactly two files / three inserted lines in this final commit. Matching-lock dependencies are physically hard-linked from a completed clean install; this is not a separate clean install per PR.

The previous combined board (3ba43347aa836e05c67de05602e8ab1deb3b36d5) completed 64/64 focused tests and typecheck:core PASS, but predates this final commit and the latest release-base updates. Those receipts are scoped evidence, not admission for a different candidate. Release base advanced to 459bb3bcaba706a5df54e414788cdc743b2ba9f7 during reconciliation; the owned interaction board is being refreshed without touching other sessions' worktrees.

Approval is resolved. Merge authorization remains recorded; actual merge still waits for successful applicable checks on the current exact head/base/candidate. No admin/force/hook bypass, release publication or deploy.

@diegosouzapw

Copy link
Copy Markdown
Owner

Delivery reconciliation — 2026-10-13

Thank you @BenjaminAronsson and @woodsonl for the selected fixes. The repository owner has explicitly authorized merging the original PRs #15945, #15948 and #15682, including the previously reviewed generated instruction hunks. That approval remains settled; no replacement PR or contributor-branch overwrite is planned.

Reconciled the current release base 7f3cbb046b3706bf0bbc047b7eaa0cbada8d9e50 and all three exact published heads into an isolated local interaction candidate 2336a6d2e1f39e38da8ab8e54c37e189224a867b, tree bea8bc1a7f4f1538dfe97a89f7295363df8fa5e7. Preserved the author's latest #15682 Stryker registrations (b6716df...). All selected heads and the current base are real ancestors; no conflicts.

Current scoped results: 96/96 focused native tests PASS, typecheck:core PASS, canonical neutral skill generator 0 pending / 46 unchanged / 0 errors, changelog integrity PASS. These are focused interaction receipts, not a full CI certificate or admission for different intermediate squash trees.

The earlier pending-workflow snapshot has been superseded by terminal results. #15945's Gate / Quality passed, but Gate / CI failed on Docs Sync (Strict); #15948 and #15682 also have failed required lanes. Reproduced the blocking i18n checker on both the exact pure base and the selected interaction candidate: each exits 1, 27 drifted sources / 132 drifted targets, with identical affected path sets. The 264 separately reported stale targets are advisory, not the blocking count. The selected contribution clears generated-skill drift, not this global translation drift.

The retained full Release-Green report for exact base 7f3cbb..., run https://github.com/diegosouzapw/OmniRoute/actions/runs/38292478149 , also verifies FAIL through the versioned report verifier. Other test/package/typecheck signatures still need their own causal diagnosis; the older #15306 issue body is not treated as a current certificate.

Integration remains HOLD on required validation, not on owner approval. A separate base-repair scope has been raised with the owner. No admin merge, force push, gate/hash/baseline bypass, release or deploy was performed. Original PRs remain open and contributor credit is preserved.

@diegosouzapw

Copy link
Copy Markdown
Owner

The repository owner explicitly transferred #15945/#15948 to this Video Bridge campaign on 2026-10-13 and requested completion. I am assuming coordination without overwriting the prior relay worktrees or duplicating this contribution. Published head 654cf60 already resolves the two previously reported generated hunks; that old blocker is superseded. I will refresh exact-base/candidate validation on .15, retain contributor authorship, and merge only after the current applicable required checks pass. Existing Docs Sync failures are being reconciled separately; no administrative bypass is authorized.

No content changes. Refresh the original PR against the current release merge candidate after diegosouzapw#15840 restored translation synchronization.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
@diegosouzapw

Copy link
Copy Markdown
Owner

Transferred-campaign checkpoint: normal hooks and fast-forward fork pushes published content-preserving refresh heads #15945 56133ac and #15948 7f555ec, both Benjamin-authored with maintainer co-author. At exact release b0d5325 after #15840, isolated .15 interaction candidate 935247f passes 251 focused tests (4 existing skips, zero failures), official skill sync (0 pending/46 unchanged), and strict translation drift (zero drift/missing/stale). Exact pure-base drift also passes. The preceding 27-source/132-target blocker is superseded by the actual translation repair, not hash adoption. These are scoped receipts with borrowed diagnostic dependencies, not full CI/release acceptance. New matching-head CI/Quality runs are queued; current base has moved again, so admission will require a fresh identity check. Original video PR branches remain unchanged while an isolated conflict-resolution candidate is prepared. No merge, admin bypass, force push, paid call, production change or issue closure occurred.

@diegosouzapw

Copy link
Copy Markdown
Owner

Coordination for the transferred Video Bridge ownership: this Relay front has not mutated #15945/#15948. I published only original #15682 (be8a7c3), retaining Lance author credit and fixing its two cycle-document mirrors.

Fresh base movement matters: strict translation drift was indeed zero at b0d5325 after #15840. Later merged source-only additions #16441/#16408 introduced ENVIRONMENT/AUTO-COMBO drift; #16360 then added RESILIENCE_GUIDE drift at release ac590da. The canonical checker executed on BOTH pure exact ac590 and the #15682 candidate exits 1 with precisely those three sources, zero target drift/missing/stale. This is not the older 27/132 incident and must not be hash-adopted away.

An isolated owned fix/relay-i18n-deltas-20261013 front has applied actual 132-mirror ENV/AUTO additions with source/target preimage checks. Its c188 candidate passed 40 focused/canonical i18n tests, docs-all and strict drift (zero). Normal commit hooks are still formatting all 134 docs/state files; the resilience addition is being repaired separately before publication. No code or workflow/gate/baseline changes, translation API calls, paid calls or deploy.

Please retain your ownership of the two generator PRs; this front is preparing the bounded base-doc prerequisite rather than overwriting your contributor heads. Actual landing order still needs matching current-candidate checks for both the generated-skills and translated-doc requirements. No administrative or indirect-merge bypass is proposed.

@diegosouzapw

Copy link
Copy Markdown
Owner

Coordination update for the transferred Video Bridge ownership (2026-10-13): the bounded base prerequisites are now published, not merely in local preparation:

This front has recognized your newly published #15948 head f864627d0ac5a06eee7bb675e123fd3fb96aeb60; neither transferred PR/worktree has been modified here. A new owned diagnostic candidate 648d517873696da49d504931e2d2547f4a2c3792 includes exact release 47688ba5ea28223cf240d4a3a1b542e249ad63b2 and all five published heads, with unchanged combined tree 413f21f64a55862d7619a63e5f2ed7ddc0ff9131. A fresh normal npm ci completed; full local validation is still RUNNING, not PASS. Core typecheck and the 23-test security suite passed.

The expanded dashboard typecheck independently fails on BOTH this candidate and pure exact 47688ba5, with the same unbaselined ConnectionRow TS2339. Existing minimal repair #16482 addresses it and has another active owner; this front has not duplicated that repair or increased its baseline.

Current #15682 integrity job 115298758886 reports 20 pending generated artifacts, but its log proves checkout a131088d... combining that head with older base ac590daf.... This is not an acceptance receipt for current release or the combined candidate. The original generated-artifact and docs prerequisites still need coordinated exact-candidate landing; no individual failed or pending gate should be waived using the combined local report. Your ownership of #15945/#15948 remains unchanged. No merge, admin bypass, force push, release or deploy was performed here.

@diegosouzapw

Copy link
Copy Markdown
Owner

Current-candidate coordination update (2026-10-13 17:18 UTC): the owned diagnostic board now combines live release 5b16041b73da64d421021b6c469f0f0ffc51eba6, published #15945 56133ac6635fcd5d2601c2090b4d18a289f0bebc, #15948 f864627d0ac5a06eee7bb675e123fd3fb96aeb60, original #15682 be8a7c38adc6fc79ce83da61a3e90a303bfd7af4, #16504 3643b2b6e8045a43daa032b2131c9ec4b95c53f6, existing dashboard fix #16482 07b37af3c73d323190184b2f20fe059e85e8ee4d, and the separate observer correction #16533 b770261fdefdaf2f6402ad7ef3ccd1944d33f081. #16506 was merged by another maintainer front at b108b45e514240330a0854421a377bdfee7fd142; its delivered scripts/fragment were verified byte-identical to the published head.

Diagnostic candidate 8f646607913df35d2f0ba80c439d802a04ce2ae9, tree 802053d1db75fff6d787581dbccd0c7039190e80, unchanged dependency lock:

  • Official npm run check:agent-skills-sync: exit 0, generated 0 / unchanged 46 / errors 0, no writes.
  • npm run check:env-doc-sync: exit 0, no contract gaps.
  • node scripts/i18n/check-translation-drift.mjs --strict: exit 0, 152 sources / 10,032 targets match.

These are combined-board diagnostics, not individual squash-candidate admission. The old full observer/UI runs were stopped when release advanced through runtime changes, and are explicitly recorded CANCELLED/NOT RUN rather than reused as a full green result. Earlier 9c54e246 diagnostics passed 108 focused tests, core typecheck and docs-all; the first docs-all attempt had a collector execution failure that remains disclosed.

#15682's latest docs-sync failure still checked out a131088d over old base ac590daf, before #16506, and reports only the old MODEL_VARIANT contract defect. It must be refreshed on a current candidate, not fixed a second time.

Please retain the already transferred ownership of #15945/#15948 and coordinate their current-candidate validation/landing with the documentation prerequisites. This Relay front has not modified either head/worktree or taken over #16482. #16533 fixes a separately reproduced observer classification defect, preserves all baselines/thresholds/workflows and measured-drift advisory policy, and has 83 affected tests passing; its remote checks are pending. No administrative bypass or indirect merge is proposed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants