Repository navigation
fix(release): drain v3.8.52 base-reds — sqlite report stall (#15106), zh-CN glossary, route map, #15979 test fallout - #16092
Merged
Conversation
…ossary, route map, ToS-default test fallout - fix(db): construct better-sqlite3 with process.report.excludeNetwork on. Its isLinuxMusl() probe calls process.report.getReport(), which reverse-resolves every open TCP handle; with sockets open the first DB open blocked ~6s on hosts with slow reverse DNS — the shared root cause of the four autoCombo/antigravity vitest 5s timeouts (#15106). - fix(i18n): zh-CN codexKeyServiceMode 提供商 -> 提供者 (glossary) and regenerate routeNamespaces.generated.json for the namespace added by #13554. - test: opt out of excludeTosAvoid in the auto-combo suites whose subject is not the ToS filter — #15979 made uncataloged models inherit the provider verdict, so opencode/antigravity left every default auto pool (contract change). - test: zai-web #13232 pins DISPLAY so the missing-Chromium branch is exercised after #15851 started Xvfb first; quota-trackers-batch-init matches the awaited import independent of the Prettier reflow from #13330.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drains the base-reds on the
release/v3.8.52tip (977d006). Each item was reproduced red on the clean tip, run on its own (not under load), and traced to the PR that caused it.Fixed
1. Shared root cause of the 4 vitest 5s timeouts (production fix, #15106)
antigravity-quota-family,pipeline-router-taskfitness-mismatch,suffixComposition-4517andvision-filter-excludes-forced.getResolvedModelCapabilities()call showed 6.0s of the 6.6s insidebetter-sqlite3/lib/binding.js::isLinuxMusl(). That function callsprocess.report.getReport(). The report's network section reverse-resolves every open TCP handle, and the vitest worker holds 2. On a host with slow reverse DNS, the measured cost wasgetReport()= 5948 ms, and 6 ms withexcludeNetwork = true. Production pays the same cost on the first DB open when sockets are already open.src/lib/db/adapters/driverFactory.tsbuilds the better-sqlite3 Database withprocess.report.excludeNetwork = trueand restores the caller's value afterwards. better-sqlite3 only readsheader.glibcVersionRuntimefrom the report.tests/unit/db-adapters/driverFactory.test.ts(red first:actual: false, expected: true, then 29/29 green). All 4 vitest files are green alone: 7/7, 2/2, 6/6 and 5/5. The first test in each file dropped from ~6.5s to 0.6–1.2s.2.
i18n-glossary-consistency-check: zh-CN contains 提供商codexKeyServiceMode.descriptionand.warningusing 提供商. The glossary term is 提供者, which zh-TW already uses.src/i18n/messages/zh-CN.jsonchanged. 33/33 green.3.
i18n-route-namespaces: stale generated mapcodexKeyServiceModenamespace without regenerating the map.npm run gen:i18n-routes. 5/5 green. Note: fix(i18n): give the /home route a provider layout — it rendered raw keys #16056 also regenerates this file. Whichever PR merges second only needs to regenerate it again.4.
virtual-auto-combo: "restricts the no-auth pool", plus 4 sibling files with the same causeSiblings:
noauth-autocombo-allowlist,noauth-autocombo-hidden-7620,repro-6557-noauth-connection-disable-ignored,auto-combo-credentialed-model-pool.tos: "avoid"verdict and addedantigravity: "avoid". fix(auto): exclude tos:avoid providers from auto by default (#15059) #15839 had already turnedexcludeTosAvoidon by default. Together they remove every opencode and antigravity model from the default auto pool.FREE_TIER_TOSfallback andantigravity: "avoid") makes all 5 original files pass.updateSettings({ excludeTosAvoid: false })), the same pattern fix(auto): exclude tos:avoid providers from auto by default (#15059) #15839 used for the sibling test. Each change carries a// contract changed by #15979comment. No assertion changed. The ToS default stays covered byissue-15059-tos-avoid-auto-default(3/3 green).5.
zai-web-missing-browser-executable-13232DISPLAY=:99and restores it afterwards, so it exercises the missing-executable branch on any host. Playwright checks the binary before it touches the display. 1/1 green.6.
quota-trackers-batch-initawait import("…quotaTrackersBatch.ts")onto one line. The test matched a hard-coded line break.Not fixed here
quality-rail-gate-membership(fast-gates /cycles): already fixed by the open PR fix(release): drain two v3.8.52 base-reds — cycles membership test, drifted skills mirrors #15682, with the same needle change and a stronger guard. Dropped to avoid a conflict.issue-agent-route-execution("preserves the normal chat route provider failure response"): flaky / load. It passed 3/3 alone (33–40s per run) and failed only in the full suite at 60s with499 !== 429(client abort). Not touched.chaosVirtualCombo(also fix(auto): honor provider ToS for uncataloged models and clarify setup #15979 fallout, red alone): fixed by the open PR test(auto): seed eligible accounts in chaos combo fixture #16090.executor-map-golden(test(executors): refresh golden for integrated Twinmind aliases #16058),provider-validation-specialtygemini-web (order-dependent), and timing tests (9147, conversationTracker-7847, provider-request-failure-pipeline).Gates
Run in the worktree:
typecheck:corecleanorigin/release/v3.8.52: no weakening), changelog-integrity, test-discovery and env-doc-sync: all OK