Repository navigation
fix(dashboard): clear the two TS2345 dashboard-typecheck regressions on the release tip - #16000
Merged
Merged
Conversation
…on the release tip classifyModelImport (#15169) narrowed the discovered entries to { id, name, model }, so the import loop lost the forwarded fields and its model id became unknown; the cap normalizer from #15612 passed an unknown to Math.floor. Keep the entry open-ended, coerce the id exactly like the classifier does, and coerce the cap explicitly (same runtime result).
Contributor
CI Coverage Report
Coverage artifact was not available for this run. PR Test PolicyThis PR changes production code in |
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-dashboard-typecheckis red on the release tip with two new TS2345 (baseline 0, live 1):providers/[id]/hooks/useModelImportHandlers.ts:classifyModelImport(fix(dashboard): show a warning, not success, when model import fell back to the local catalog #15169) types the new entries as{ id, name, model }withunknownvalues, so the import loop's model id becameunknown(and every forwarded field — apiFormat, dimensions, inputTokenLimit… — lost its type).DiscoveredModelnow keeps the rest of the entry open-ended, and the loop coerces the id exactly like the classifier's own "already imported" check.compression/engineConfigSave.ts(fix(dashboard): treat an emptied engine number field as unset #15612):Math.floor(cap)on anunknown; nowMath.floor(Number(cap))— identical at runtime (Math.floor already applies ToNumber).Validation on the branch:
check-dashboard-typecheckred → green (196 pre-existing, all within baseline);model-import-degraded-catalog-15159,local-catalog-import-media-api-format,compression/engine-config-save,compression/engine-config-empty-number32/32; eslint clean on the 3 files.check:agent-skills-sync(generated SKILL.md drift since #15778; fix pending in #15945/#15948).