Repository navigation
fix(providers): recover rejected 9router fields and preserve retry bodies - #16133
Merged
Merged
Conversation
This was referenced Oct 10, 2026
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a 9router reasoning retry, the executor returned the original request body even though it had sent a corrected one. It also returned recoverable field-rejection 400s directly and repeated known reasoning failures on subsequent calls.
This completes the proven NineRouter portion after #15946:
Refs #14629
This is a partial umbrella delivery. Other named executor paths still require their own contract/probe checks; it does not migrate every override, extend generic recovery to 422, or add speculative static normalization. No shared helper or other provider is changed.
Validation
Three TDD slices on exact base
122b43b35dbacab03ea67d0f0b46e713280ccd86, with identical fixture hashes for each RED/GREEN pair:Final matrix: 17/17 passed. All direct importers and related reasoning/field/NineRouter suites: 26 files, 323/323 passed, no skips or cancellations. Tests cover both forwarded protocol shapes, caller immutability, transport preservation, bounded retries, unknown/absent fields, 401/429/500, generic 422 and service-unavailable behavior.
Core and dashboard typechecks, cyclomatic and cognitive complexity, focused ESLint/Prettier, file-size, test discovery, changelog integrity and normal automatic commit hooks passed. Independent SPEC/Standards review found no blocking issues; all three frozen file hashes remained unchanged through commit.
Tests use isolated HOME/DATA_DIR/plugins and blocked external sockets with intercepted HTTP. They prove executor dispatch/body behavior and abort-signal propagation, not a live 9router deployment or an upstream account run. The repository-wide CI/base work remains tracked in #15306; existing PRs #16130 and #15945/#15948 cover mutation selection and generated-skills issues rather than duplicating them here.