feat: hide loading indicator when index.js arrives#324

Closed

ggreif wants to merge 3 commits intomasterfrom

gabor/hide-load

Contributor

ggreif commented Jan 17, 2020 •

edited

Loading

The hiding seems reliable in Firefox, but not in Safari.

The delay is experimental and 50% effective in Safari. Maybe some DOM-change trigger should start the <script> instead of a delay.

Ideas welcome. IANAWD.

Maybe

delete loading indicator element entirely
fading out quickly


          feat: hide loading indicator when index.js arrives

98b9ef9

ggreif requested a review from a user

January 17, 2020 01:40

ggreif self-assigned this

Contributor Author

ggreif commented Jan 24, 2020

Possibly related to #305.

ggreif added 2 commits

January 27, 2020 10:52


          Merge branch 'master' into gabor/hide-load

9122b78


          Merge branch 'master' into gabor/hide-load

f603295

ggreif mentioned this pull request

style(bootstrap): Make loading indicator pretty #305

Merged

nikclayton-dfinity reviewed

View reviewed changes

src/userlib/js/bootstrap/index.js

                 // Load index.js from the canister.
                 icHttpAgent.retrieveAsset(canisterId, 'index.js')
                   .then(content => {
+                    document.body.firstElementChild.hidden = true; // "Loading ..."

Contributor

nikclayton-dfinity Feb 20, 2020

The .hidden property isn't a CSS thing.

I suspect that using CSS:

document.body.firstElementChild.style.visibility = 'hidden';

will be less likely to break. Two other reasons to do this.

You can use CSS classes (.hidden, .visible) with the appropriate rules, and then add/remove those classes with el.classList.remove / .add / .toggle
Since it's CSS you can animate the removal -- slide out, fade out, etc.

hansl mentioned this pull request

feat: remove progress bar after loading the Javascript #441

Merged

Contributor

hansl commented Mar 10, 2020

Closing this in favor of #441

hansl closed this

dfinity-bot added a commit that referenced this pull request


          build: niv advisory-db: update aa789b9c -> 6b10ce09

ce45381

## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0)

* [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967
* [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients
* [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src
* [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio
* [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13.
* [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead
* [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2
* [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir
* [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db⁠#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306))
* [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db⁠#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309))
* [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db⁠#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310))
* [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db⁠#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314))
* [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db⁠#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201)
* [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error
* [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db⁠#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321))
* [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db⁠#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311))
* [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db⁠#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322))
* [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db⁠#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304))
* [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323))
* [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db⁠#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317))
* [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db⁠#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324))
* [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db⁠#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307))
* [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325))
* [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen
* [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment
* [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326))
* [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone
* [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db⁠#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329))
* [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs
* [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db⁠#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))

dfinity-bot added a commit that referenced this pull request


          build: niv advisory-db: update aa789b9c -> 6b10ce09

ad66afa

## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0)

* [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967
* [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients
* [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src
* [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio
* [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13.
* [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead
* [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2
* [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir
* [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db⁠#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306))
* [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db⁠#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309))
* [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db⁠#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310))
* [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db⁠#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314))
* [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db⁠#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201)
* [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error
* [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db⁠#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321))
* [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db⁠#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311))
* [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db⁠#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322))
* [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db⁠#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304))
* [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323))
* [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db⁠#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317))
* [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db⁠#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324))
* [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db⁠#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307))
* [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325))
* [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen
* [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment
* [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326))
* [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone
* [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db⁠#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329))
* [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs
* [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db⁠#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))

mergify bot pushed a commit that referenced this pull request


          build: niv advisory-db: update aa789b9c -> 6b10ce09 (#799)

237f07e

## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0)

* [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967
* [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients
* [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src
* [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio
* [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13.
* [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead
* [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2
* [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir
* [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db⁠#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306))
* [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db⁠#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309))
* [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db⁠#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310))
* [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db⁠#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314))
* [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db⁠#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201)
* [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error
* [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db⁠#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321))
* [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db⁠#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311))
* [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db⁠#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322))
* [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db⁠#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304))
* [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323))
* [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db⁠#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317))
* [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db⁠#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324))
* [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db⁠#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307))
* [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325))
* [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen
* [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment
* [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326))
* [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone
* [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db⁠#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329))
* [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs
* [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db⁠#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))

lwshang deleted the gabor/hide-load branch

July 29, 2022 18:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet