Skip to content

Comments

feat: remove progress bar after loading the Javascript#441

Merged
hansl merged 2 commits intomasterfrom
indicator
Mar 10, 2020
Merged

feat: remove progress bar after loading the Javascript#441
hansl merged 2 commits intomasterfrom
indicator

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Mar 10, 2020

Before we did not remove it, so if the app Javascript has a bug or
uses synchronous code, the progress bar would still show up. Now at
least we remove the progress bar, and leave the page blank.

Closes #324.

@hansl
feat: remove progress bar after loading the Javascript
b99e5bc 
Before we did not remove it, so if the app Javascript has a bug or
uses synchronous code, the progress bar would still show up. Now at
least we remove the progress bar, and leave the page blank.
@hansl hansl requested a review from a team as a code owner March 10, 2020 17:23
@hansl hansl mentioned this pull request Mar 10, 2020
Closed
chenyan-dfinity
chenyan-dfinity approved these changes Mar 10, 2020
View reviewed changes
src/userlib/js/bootstrap/index.ts
// Load index.js from the canister and execute it.
await _loadJs(canisterId, 'index.js');
await _loadJs(canisterId, 'index.js', async () => {
document.getElementById('ic-progress')!.remove();
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does "!" mean?

Copy link
Contributor Author

@hansl hansl Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function can return HTMLElement | null, but we know it won't be null so we tell that to the type system so it accepts the return type as HTMLElement.

@hansl hansl merged commit 64bb3b8 into master Mar 10, 2020
@hansl hansl deleted the indicator branch October 5, 2020 22:13
dfinity-bot added a commit that referenced this pull request Oct 26, 2020
@dfinity-bot
build: niv advisory-db: update 6e48979d -> 0ad26bc7
9af7c84 
## Changelog for advisory-db:
Branch: master
Commits: [rustsec/advisory-db@6e48979d...0ad26bc7](rustsec/advisory-db@6e48979...0ad26bc)

* [`5751a5f4`](rustsec/advisory-db@5751a5f) CI: bump rustsec-admin to v0.3.0-pre2 ([RustSec/advisory-db⁠#438](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/438))
* [`65441901`](rustsec/advisory-db@6544190) Add unmaintained crate advisory for stdweb ([RustSec/advisory-db⁠#439](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/439))
* [`acc73d95`](rustsec/advisory-db@acc73d9) CI: bump rustsec-admin to v0.3.0-pre3 ([RustSec/advisory-db⁠#440](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/440))
* [`691a7504`](rustsec/advisory-db@691a750) Assigned RUSTSEC-2020-0056 to stdweb ([RustSec/advisory-db⁠#441](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/441))
* [`8505c957`](rustsec/advisory-db@8505c95) Add unmaintained crate advisory for `block-cipher` ([RustSec/advisory-db⁠#442](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/442))
* [`fa616899`](rustsec/advisory-db@fa61689) Assigned RUSTSEC-2020-0057 to block-cipher ([RustSec/advisory-db⁠#443](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/443))
* [`5c9ebbfa`](rustsec/advisory-db@5c9ebbf) Add unmaintained crate advisory for `stream-cipher` ([RustSec/advisory-db⁠#444](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/444))
* [`218de91a`](rustsec/advisory-db@218de91) Assigned RUSTSEC-2020-0058 to stream-cipher ([RustSec/advisory-db⁠#445](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/445))
* [`681a2040`](rustsec/advisory-db@681a204) Add advisory for notable UB fix in libpulse-binding v2.6.0 ([RustSec/advisory-db⁠#435](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/435))
* [`1e48ac39`](rustsec/advisory-db@1e48ac3) Assigned RUSTSEC-2019-0038 to libpulse-binding ([RustSec/advisory-db⁠#446](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/446))
* [`59bee556`](rustsec/advisory-db@59bee55) Add advisory for use-after-frees fixed in libpulse-binding v1.2.1 ([RustSec/advisory-db⁠#433](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/433))
* [`146de2d8`](rustsec/advisory-db@146de2d) Assigned RUSTSEC-2018-0021 to libpulse-binding ([RustSec/advisory-db⁠#447](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/447))
* [`3b1f08f2`](rustsec/advisory-db@3b1f08f) Unyank RUSTSEC-2020-0011 ([RustSec/advisory-db⁠#448](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/448))
* [`3796cc00`](rustsec/advisory-db@3796cc0) README.md: point chat badge to Zulip ([RustSec/advisory-db⁠#449](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/449))
* [`1bf68e0d`](rustsec/advisory-db@1bf68e0) RUSTSEC-2020-0015: use wildcards in version req ([RustSec/advisory-db⁠#450](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/450))
* [`67a2144b`](rustsec/advisory-db@67a2144) RUSTSEC-2020-0015: remove wildcards ([RustSec/advisory-db⁠#451](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/451))
* [`0ad26bc7`](rustsec/advisory-db@0ad26bc) Bump `rustsec-admin` to v0.3.0 ([RustSec/advisory-db⁠#452](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/452))
mergify bot pushed a commit that referenced this pull request Oct 26, 2020
@dfinity-bot
build: niv advisory-db: update 6e48979d -> 0ad26bc7 (#1143)
71404ee 
## Changelog for advisory-db:
Branch: master
Commits: [rustsec/advisory-db@6e48979d...0ad26bc7](rustsec/advisory-db@6e48979...0ad26bc)

* [`5751a5f4`](rustsec/advisory-db@5751a5f) CI: bump rustsec-admin to v0.3.0-pre2 ([RustSec/advisory-db⁠#438](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/438))
* [`65441901`](rustsec/advisory-db@6544190) Add unmaintained crate advisory for stdweb ([RustSec/advisory-db⁠#439](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/439))
* [`acc73d95`](rustsec/advisory-db@acc73d9) CI: bump rustsec-admin to v0.3.0-pre3 ([RustSec/advisory-db⁠#440](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/440))
* [`691a7504`](rustsec/advisory-db@691a750) Assigned RUSTSEC-2020-0056 to stdweb ([RustSec/advisory-db⁠#441](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/441))
* [`8505c957`](rustsec/advisory-db@8505c95) Add unmaintained crate advisory for `block-cipher` ([RustSec/advisory-db⁠#442](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/442))
* [`fa616899`](rustsec/advisory-db@fa61689) Assigned RUSTSEC-2020-0057 to block-cipher ([RustSec/advisory-db⁠#443](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/443))
* [`5c9ebbfa`](rustsec/advisory-db@5c9ebbf) Add unmaintained crate advisory for `stream-cipher` ([RustSec/advisory-db⁠#444](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/444))
* [`218de91a`](rustsec/advisory-db@218de91) Assigned RUSTSEC-2020-0058 to stream-cipher ([RustSec/advisory-db⁠#445](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/445))
* [`681a2040`](rustsec/advisory-db@681a204) Add advisory for notable UB fix in libpulse-binding v2.6.0 ([RustSec/advisory-db⁠#435](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/435))
* [`1e48ac39`](rustsec/advisory-db@1e48ac3) Assigned RUSTSEC-2019-0038 to libpulse-binding ([RustSec/advisory-db⁠#446](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/446))
* [`59bee556`](rustsec/advisory-db@59bee55) Add advisory for use-after-frees fixed in libpulse-binding v1.2.1 ([RustSec/advisory-db⁠#433](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/433))
* [`146de2d8`](rustsec/advisory-db@146de2d) Assigned RUSTSEC-2018-0021 to libpulse-binding ([RustSec/advisory-db⁠#447](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/447))
* [`3b1f08f2`](rustsec/advisory-db@3b1f08f) Unyank RUSTSEC-2020-0011 ([RustSec/advisory-db⁠#448](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/448))
* [`3796cc00`](rustsec/advisory-db@3796cc0) README.md: point chat badge to Zulip ([RustSec/advisory-db⁠#449](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/449))
* [`1bf68e0d`](rustsec/advisory-db@1bf68e0) RUSTSEC-2020-0015: use wildcards in version req ([RustSec/advisory-db⁠#450](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/450))
* [`67a2144b`](rustsec/advisory-db@67a2144) RUSTSEC-2020-0015: remove wildcards ([RustSec/advisory-db⁠#451](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/451))
* [`0ad26bc7`](rustsec/advisory-db@0ad26bc) Bump `rustsec-admin` to v0.3.0 ([RustSec/advisory-db⁠#452](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/452))
dfinity-bot added a commit that referenced this pull request Jul 8, 2021
@dfinity-bot
build: niv common: update 8a83ce5b -> b9272f9e
cd1b3e4 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@8a83ce5b...b9272f9e](https://github.com/dfinity-lab/common/compare/8a83ce5bfeb72144e74d591e50e6633aa67168ea...b9272f9ea5b2dc3ca7b81ab217e10e29d672c75b)

* [`d2e06bd5`](https://github.com/dfinity-lab/common/commit/d2e06bd5ba026f1060df1d72ab2c1bb21076764d) Add Valeriy's SSH key ([dfinity-lab/common⁠#441](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/441))
* [`b9272f9e`](https://github.com/dfinity-lab/common/commit/b9272f9ea5b2dc3ca7b81ab217e10e29d672c75b) Change pubkey comment to my Dfinity email and add some padding. ([dfinity-lab/common⁠#442](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/442))
mergify bot pushed a commit that referenced this pull request Jul 8, 2021
@dfinity-bot
build: niv common: update 8a83ce5b -> b9272f9e (#1748)
7fc2254 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@8a83ce5b...b9272f9e](https://github.com/dfinity-lab/common/compare/8a83ce5bfeb72144e74d591e50e6633aa67168ea...b9272f9ea5b2dc3ca7b81ab217e10e29d672c75b)

* [`d2e06bd5`](https://github.com/dfinity-lab/common/commit/d2e06bd5ba026f1060df1d72ab2c1bb21076764d) Add Valeriy's SSH key ([dfinity-lab/common⁠#441](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/441))
* [`b9272f9e`](https://github.com/dfinity-lab/common/commit/b9272f9ea5b2dc3ca7b81ab217e10e29d672c75b) Change pubkey comment to my Dfinity email and add some padding. ([dfinity-lab/common⁠#442](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/442))
ggreif pushed a commit that referenced this pull request Jul 8, 2021
@dfinity-bot @ggreif
build: niv common: update 8a83ce5b -> b9272f9e (#1748)
30507b8 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@8a83ce5b...b9272f9e](dfinity-lab/common@8a83ce5...b9272f9)

* [`d2e06bd5`](dfinity-lab/common@d2e06bd) Add Valeriy's SSH key ([dfinity-lab/common⁠#441](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/441))
* [`b9272f9e`](dfinity-lab/common@b9272f9) Change pubkey comment to my Dfinity email and add some padding. ([dfinity-lab/common⁠#442](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/442))
ggreif pushed a commit that referenced this pull request Jul 8, 2021
@dfinity-bot @ggreif
build: niv common: update 8a83ce5b -> b9272f9e (#1748)
21f8db6 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@8a83ce5b...b9272f9e](dfinity-lab/common@8a83ce5...b9272f9)

* [`d2e06bd5`](dfinity-lab/common@d2e06bd) Add Valeriy's SSH key ([dfinity-lab/common⁠#441](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/441))
* [`b9272f9e`](dfinity-lab/common@b9272f9) Change pubkey comment to my Dfinity email and add some padding. ([dfinity-lab/common⁠#442](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/442))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chenyan-dfinity chenyan-dfinity chenyan-dfinity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hansl @chenyan-dfinity